From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Y08HCmb/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 39A1D5A0280 for ; Fri, 20 Jun 2025 11:37:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750412229; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+BCKrq1NUNxrtO6RrEDviZ0LgqPNinfjgA9gwkqsKEw=; b=Y08HCmb/uMguuPVwzE68VRRKXXoRUafTTKaYMte7hf6cXgIdBWbxL4g+K6dSn97waLxHnj gqwuu9Uf+o73ZdLTeiDDC1GZsR/vc7VSfW/okz+xDYU3zkGnzvMWLLgCY4WyUOO0l24Mwc zEgOhvvoAR18Wtyq3m20bNJxEWFM1dA= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-106-qaIDRx7rNnq-vhrQjVyG3g-1; Fri, 20 Jun 2025 05:37:07 -0400 X-MC-Unique: qaIDRx7rNnq-vhrQjVyG3g-1 X-Mimecast-MFC-AGG-ID: qaIDRx7rNnq-vhrQjVyG3g_1750412226 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a50816cc58so768995f8f.3 for ; Fri, 20 Jun 2025 02:37:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750412226; x=1751017026; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+BCKrq1NUNxrtO6RrEDviZ0LgqPNinfjgA9gwkqsKEw=; b=v7d9k9WgvBGczC3sP/Vhxp/sTmoJY2Xs8uztc1GxuqJW2H7Hd3xpiXM6UFTNAz6K7F KZfGbLXe50xDgkSFgxmEq53l7l9uQjJJ5rAnNGSXpUQsrW/XaymXK7/MmyzxZ4NB+kVV A+R2O+xiqjofyTydZYK4awgNEi9PDn2b5I5uk1W2BsG5+qf6mYgtGigURMTPiaw42cfz NrP1rfk2LcFgaxkIQRAhYFD7vUiZVBm42fy1BRdqDOiwiFVBzpA2nt3tjc99WSAcuOXm jYNhH1AkYx2ckRQHaeWVnyrFUBpB7DWOVxAT0DKbt1LOREU1xpTLJQHsKU+CNr6W5GEw n+Rg== X-Gm-Message-State: AOJu0YwyV7nJ2JKpVohsX0+/Tf4ZQTNxisK1wvYudoCHEIkscnzW/1/D 1GxfaIDGw/QIaMpKNpghhy7UQHuNJ3N/4izKbO2ygpRxhB2+gPAvu4foB2Z30VJZS5izoj6QQqE /XRZ4A9ylHXIDspYe89DR+l/zjoFB+U0aKAMQuO9j7Rb9fOmGMqJRGg== X-Gm-Gg: ASbGncshB02vR7GWn3fx+Xr2HW52ozvhtQJYwZ61otRN3My6d7G1QImHldOXPTfn1wR 3H2gARVu5nguH5gkBhVl7fvs98LNrEFeE8lvWdtILIXRHrby/qBK6m4oiqXwkh5N0M7yogmqArz ck30/ghEfVjOctkXTpjWVjYFX8LseQnkOkjFGwJZNkWOrtCGOUGWpvd+VhSCJyG7bFPxTsG3+2I kEDFbq2rJ0/04qQ9vkMC+wfEbhkFlW0na0/bPKe1ZpMU+QF5RrXUBqs/F8wSde90oJiuIcsLGPs PHjDQmi6F+86PNQ+X/0SqkvgoBmggLLHVOf1dDDwJ3rDoQRIetKCV3x8gXKbxA== X-Received: by 2002:a05:6000:4021:b0:3a6:d145:e2cc with SMTP id ffacd0b85a97d-3a6d145e448mr1608588f8f.15.1750412225790; Fri, 20 Jun 2025 02:37:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGF3A+WF0F+XPimit+wqlPI9Q3lrGTloNzmK+o/X6SR3iI+/FQFt70u3W3jP09gYVRL1s9Ghw== X-Received: by 2002:a05:6000:4021:b0:3a6:d145:e2cc with SMTP id ffacd0b85a97d-3a6d145e448mr1608569f8f.15.1750412225440; Fri, 20 Jun 2025 02:37:05 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646cb5ecsm19874435e9.8.2025.06.20.02.37.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Jun 2025 02:37:05 -0700 (PDT) Message-ID: Date: Fri, 20 Jun 2025 11:37:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] style: Fix 'Return' comment style To: Stefano Brivio References: <20250619113728.953203-1-lvivier@redhat.com> <20250620112411.0d7e5be1@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20250620112411.0d7e5be1@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: J3BzHtCMTQYDBjgw92NX8MH356fk52fLwdrMufl_H1o_1750412226 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 7OXM4AAZJ43UIFLYP36F4QI2TW6QQR7D X-Message-ID-Hash: 7OXM4AAZJ43UIFLYP36F4QI2TW6QQR7D X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/06/2025 11:24, Stefano Brivio wrote: > On Thu, 19 Jun 2025 13:37:28 +0200 > Laurent Vivier wrote: > >> We always use imperative (no 'Returns:'), no tab after the ':' and >> only one space, the first character is always lowercase. >> >> [...] >> >> @@ -129,7 +129,7 @@ static int udp_vu_sock_recv(const struct ctx *c, int s, bool v6, ssize_t *dlen) >> * @toside: Address information for one side of the flow >> * @dlen: Packet data length >> * >> - * Return: Layer-4 length >> + * Return: layer-4 length > > ...unless it's a proper noun (Layer-4, Layer 4, L4...). I can fix this > up on merge, but feel free to re-post. :) > Done Thanks, Laurent