From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=blMok0g+; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 986B95A026F for ; Thu, 09 Oct 2025 09:14:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759994054; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AAy48uGftDLaljZ7XKwi+U65iI+tfyaYMqUitv57T0I=; b=blMok0g+mryrldSg6TQEO/RvM+GwNYyAXanqSyaEvf2XuQTaj38Kw8rOQp3N9jdhRNnScM nDrN/K0cA5IZykLiZPTnUpWRIaIr20m1c2CcjYiH9+F5slirt2Y5Q8dy/20sPgcI1369jD duDvi1EE0anGpAXf60yWdNwi4ATig34= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-136-bBoC8DgrN7ief0Au2k2gTA-1; Thu, 09 Oct 2025 03:14:12 -0400 X-MC-Unique: bBoC8DgrN7ief0Au2k2gTA-1 X-Mimecast-MFC-AGG-ID: bBoC8DgrN7ief0Au2k2gTA_1759994051 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3efe4fcc9ccso527858f8f.3 for ; Thu, 09 Oct 2025 00:14:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759994051; x=1760598851; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AAy48uGftDLaljZ7XKwi+U65iI+tfyaYMqUitv57T0I=; b=Q/JtXA4Uyw+JnvLVhCWfPIacS2aTPLaQQF2VAIRT1gDty93PW5GJybcq5rSDxQE9Gg DIWlvQXvIVfo0ZAFbr9xCxr3nGV+K/BvzPbtLRciTo8QSxXLHyZeTk7AO/1iMZ7E4+kR ZaV7Edd7zpApQEoJYZtLEg9QC/Skht743UtDnND7ka+4wkcla3U7fMhWW6YYL61Ph0iE zl1sVgezuBbNq4u0hpWBxDdm1STM4Qb/iMpjnTwC6of1RyXBzoYDChuXEHsTq7a7gacj RlrWlVpYwt88VjTQeC/mbVTUL/rqHhSOgh3OArlzmNwI7tBoIhzzHpZ+2UIl1W7ePCbP 3+5A== X-Gm-Message-State: AOJu0Yzia/koVmT4A3DAUeHCdPhl9a5aQw9RR6KzJid/yiy9BTtnwB0P vawONW5ip/FF45sjCR0zzFM+W4ahy11E85fu9ORDDtNyn65PQAIZ7eOwwYFCF+/LIVI7MU9ESN4 0Uf3uDyOvDjYyvY8OmUoDxan5OUbVr0cgSdmjVP9CWoVBEl1du6Lqsg== X-Gm-Gg: ASbGncsZm2rXnV6kYqH5p44GnD3RdA6i9w6T7PFJ5VdrnuyzQvu3m8uah9xT4MSq7ys Bx+eD3wF6tFShiSYRHmRDkXEaWMCIuMXGPrQvReuHjWN6RmdcBkcyubHRMkoo7Qp+p26QleflTJ DmhjYJytWIgcIoLkvDEBakopsAWXzuCEDHaQxJkfW6YfnHXF92Vves55Z8crkRcKRZQu1218n+X UuLfSRwvl8XnnEtbnVjI9BDrajCDMO7OaMjclv90cQuZ99k2aD4fjLiFlJFJ+W6HDjTHoigTDCv YIFhA4gWvrYOVU6njNMPhr4NmOLaYoVNBuIQwpIbf+XNItzBSIUJlUoD6SdlHpgeBFGjJ7ycxXb UN5UaVl3k X-Received: by 2002:a05:6000:2485:b0:425:8133:ec6c with SMTP id ffacd0b85a97d-42666ac634cmr3464767f8f.9.1759994051053; Thu, 09 Oct 2025 00:14:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/sSzewt+yChf284VmBq5ALC7dz9UWiEgknYFQD5Bi+nVUeLkYT1GfINkTvHqR/KFLUUE5Gw== X-Received: by 2002:a05:6000:2485:b0:425:8133:ec6c with SMTP id ffacd0b85a97d-42666ac634cmr3464754f8f.9.1759994050599; Thu, 09 Oct 2025 00:14:10 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4255d8a6bbesm33104844f8f.12.2025.10.09.00.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Oct 2025 00:14:10 -0700 (PDT) Message-ID: Date: Thu, 9 Oct 2025 09:14:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] tcp, flow: Replace per-connection in_epoll flag with epollfd in flow_common To: David Gibson References: <20251003152717.2437765-1-lvivier@redhat.com> <20251003152717.2437765-4-lvivier@redhat.com> <795ada45-d8ec-4ede-9b2e-54b5e1a50267@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tjkbwBO_Zv1hScHoO-4IY5QhcHfdw54-PIVDLi5i0Fk_1759994051 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: JHZFME5IVSIFLHSHQBU3OQFENA5CANJR X-Message-ID-Hash: JHZFME5IVSIFLHSHQBU3OQFENA5CANJR X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 08/10/2025 02:24, David Gibson wrote: > On Tue, Oct 07, 2025 at 03:26:23PM +0200, Laurent Vivier wrote: >> On 07/10/2025 08:07, David Gibson wrote: >>> On Fri, Oct 03, 2025 at 05:27:15PM +0200, Laurent Vivier wrote: >>>> The in_epoll boolean flag in tcp_tap_conn and tcp_splice_conn only tracked >>>> whether a connection was registered with epoll, not which epoll instance. >>>> This limited flexibility for future multi-epoll support. >>>> >>>> Replace the boolean with an epollfd field in flow_common that serves dual >>>> purpose: zero indicates not registered (replacing in_epoll=false), non-zero >>> >>> Don't use 0, since that's a valid fd. >>> >>>> stores the actual epoll fd (replacing in_epoll=true). >>> >>> I am a bit nervous about adding 31-bits to every flow, since I think >>> we're fairly close to a cacheline threshold. >>> >>> I'm not sure we really can add any less to flow_common, though, given >>> alignment. >>> >>> Then again... we probably don't need 8 bites each for TYPE and STATE, >>> so those could be packed tighter. Then we could use a limited-bits >>> index into a table of epollfds, rather than a raw fd. Much uglier, >>> but maybe worth it? >>> >> >> I tried the epollfds table. But it introduces complexity and a new shared >> data structure that we will need to manage correctly in the case of >> multithreading. I don't think it's the way to follow... > > I was assuming it would be a write-once data structure, meaning > multithreaded management shouldn't be too hard. But ok. I'm going to try that anyway: for multiqueue I would need to store the queue id in flow_common, and I have an array of queues with the epollfd, so I'll have the indirection and the number of queues is limited so it would fit in 8-bit (or less). I prepare a v3 with this change. Thanks, Laurent