From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 815775A004E for ; Tue, 06 Aug 2024 11:27:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722936465; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7bKLsHidX4+usgMgrhAbMsRalhOBX99ki9NARbDWLrY=; b=bUOjDnmz7tvgxPLSlTEAKN7aPGkqjGkskWsYCigOw5HzXll5CxCmZkKVG0WOvgOt+Y60jp WEGlLZPwKsKQlg+Yur40rrGiZWNXaVu6kgk3cFzgpkk1GWTS2OBMZZ6WtBzppbYk/EZRlx hpvD5lSDBEXS2zDuDWDt+3v2Pbzd/ko= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-427-gefw1RdeMSm_HAlV78TUcQ-1; Tue, 06 Aug 2024 05:27:44 -0400 X-MC-Unique: gefw1RdeMSm_HAlV78TUcQ-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-3685a5a765fso261570f8f.1 for ; Tue, 06 Aug 2024 02:27:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722936463; x=1723541263; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7bKLsHidX4+usgMgrhAbMsRalhOBX99ki9NARbDWLrY=; b=SeVQqwZX6CBE5momU2hhn8+AsCFspsPVKqEBM0p2/c/IR5xMXY9FfjAh6/S3RC1LLE CmU2EE5HY++vW/xOS0e7N89or6X+wrlX2FcTFA2SluSgUMLuyV138fnASKKWR0bP+6iy meor1UvWmdXFMmoQXnz3KCh6/TNcSrnEsYEyEIO+ESnqPtAYpmBZpFMV1Tt3w1067V6Z 68tz66fUd1tndPaRUy/PKsrXXAKiI93gs1Z2rdcmsevstQvPdBlNxlwNvIAzPtfjeKrf Uy1RSf6dmgFT0ZDFm9XbA18/n7G5Guw5H/NhnnqR8Q4TeX8F+Ea9Fs/GIoeuHBGqNhWh ZAtQ== X-Gm-Message-State: AOJu0Yx23m8weSCpVMiFt+YcVZnYXwpUeHbceNCHGoSRFLLTF4lq9fF9 9KwgYtBaWSCgA5jF/w/vk1ufC9ireYfJQX1UQx5fjJUmVOoM7WcAwy2kY3c3nLy6VJhK9IAhVLO d3p93G/u4VvW1Azybrn9t3PuwiACYpZSxMZ7POEee+9ez/GM7qw== X-Received: by 2002:adf:cf0a:0:b0:367:991d:8b76 with SMTP id ffacd0b85a97d-36bbc0f3655mr8723133f8f.15.1722936462774; Tue, 06 Aug 2024 02:27:42 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHDhktpZkQQe4lnYxPNmVHTS2L7roO+GWF1eoQbEkKeUtSEG3s2Q8+8QSj93axU+IIAFPdcMQ== X-Received: by 2002:adf:cf0a:0:b0:367:991d:8b76 with SMTP id ffacd0b85a97d-36bbc0f3655mr8723109f8f.15.1722936462164; Tue, 06 Aug 2024 02:27:42 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:8e19:3414:44f0:befd? ([2a01:e0a:e10:ef90:8e19:3414:44f0:befd]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbcf0cc4csm12513881f8f.3.2024.08.06.02.27.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 02:27:41 -0700 (PDT) Message-ID: Date: Tue, 6 Aug 2024 11:27:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] util: In ASSERT(), use "fprintf(stderr, ...)" rather than err(...) To: David Gibson References: <20240805141027.1502569-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: MCYWUCVLS746OKAA7CQLOIMBARFYIBBG X-Message-ID-Hash: MCYWUCVLS746OKAA7CQLOIMBARFYIBBG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/08/2024 02:27, David Gibson wrote: > On Mon, Aug 05, 2024 at 04:10:27PM +0200, Laurent Vivier wrote: >> We use our own implementation of assert() because the glic implementation >> uses syscalls that aren't in our seccomp filter, see 7a8ed9459dfe >> ("Make assertions actually useful"). And we replaced it by an err(), >> followed by an abort() (that is also catched by seccomp). > > I think Stefano's said everything I would on the change itself, but.. > >> We don't have a coredump or a backtrace but we have at least the >> error message... only if logging is enabled. > > Whether we get a coredump shouldn't be affected by our weird ASSERT() > here. If coredumps are enabled (which they're not by default on > current distros, AFAICT), we should still get a coredump with the > SIGSYS here, just as we would for a SIGABRT. > I don't know what, but there is something that prevent passts to generate a core dump (I tried abort(), (char *)0 = 0, it works with a simple program, not with passt). Moreover, if we use gdb it doesn't stop on the syscall but exit and we cannot locate the exit point. And as strace doesn't report the syscall that generates the SIGSYS, it makes hard to find which one it is. Thanks, Laurent