From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id AED365A0274 for ; Thu, 21 Mar 2024 13:21:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711023668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ulT0O7SWzbrrr6l4Ryr1yZNAMZz7NCOyeSti5IDjZDk=; b=AJ5d1oRIxtokmvmNjXcffIZYYBr2ni8kHFPQnw27IjRh/aqErKH/kxqfIm9wNMbC0aaRtk ZiJPFErBsPmg1C+fJSOvTFpNvgXurv03/i4T+0xZuIFzxHoirzE/T7eDGQR/zKkxaPkXKR zU7TIE5oaUIEJGK93u6QG8qkKPHtIFk= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-63wr47BfOMOxQuo2kr-okg-1; Thu, 21 Mar 2024 08:21:06 -0400 X-MC-Unique: 63wr47BfOMOxQuo2kr-okg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-33eca7270ccso411150f8f.1 for ; Thu, 21 Mar 2024 05:21:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711023665; x=1711628465; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ulT0O7SWzbrrr6l4Ryr1yZNAMZz7NCOyeSti5IDjZDk=; b=hN9t6gjoB2vYvLWMZPk4jnyGWJYCDZvSL7W82I9nlUz25c+cn0e3ohbCyFi7Q4jgBR xkedCFmz0Gc/zGv0GCR9FEm4B+NxDxsN/P90VHoT2MVBXBc7RMSUJPCSSienKtbSqz7o Fw9iFYgE1A3X6pAZsM9NHyydp3c6wy3/51uQypNU4kx7LA5h3PKRhBsz8tDvw7hxVFiw Yz3FLGQp6dAiiCl47e2rQ94aFunoBAQNJ8SRzBNkvSGjS+k4XOrLmdfSpok5mIrggG/j CBONIHiJ32C3sYPIotRf/jRIbrUUX8hALgpjiPJCsqR1NOVZCGsULB+MJ+B9vTZClHEj dTiQ== X-Gm-Message-State: AOJu0YzyfO6kfj9XpjYDsNS516IGRgL+8DIICoDFV39OghqbbSEATXrD 5GxJ6P1b+VTs/GZ1DwpXPnOFy7L4RWq6MiM3H2db3c74sTG18T5AJCO6NB2I+dBJ8Qn/x/PH9Of HIuakvNQT/9t9PRJmfBC+B7s+XCAnXK4ZWt6h2uJF8FfubrUdYBbnzy6mOA== X-Received: by 2002:a5d:428c:0:b0:33e:12a4:8619 with SMTP id k12-20020a5d428c000000b0033e12a48619mr2331409wrq.24.1711023665263; Thu, 21 Mar 2024 05:21:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5ALmqP34aTuCDVRfrXYYWK1sur2xDUKK7YHB2mCI3yNfYJDOHCS5su7pGsNJK2kn/ii+Fiw== X-Received: by 2002:a5d:428c:0:b0:33e:12a4:8619 with SMTP id k12-20020a5d428c000000b0033e12a48619mr2331381wrq.24.1711023664829; Thu, 21 Mar 2024 05:21:04 -0700 (PDT) Received: from [192.168.100.30] ([82.142.8.70]) by smtp.gmail.com with ESMTPSA id dd12-20020a0560001e8c00b0033eab3520a9sm17093274wrb.43.2024.03.21.05.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Mar 2024 05:21:04 -0700 (PDT) Message-ID: Date: Thu, 21 Mar 2024 13:21:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v3] tcp: Replace TCP buffer structure by an iovec array To: David Gibson References: <20240320163146.1918122-1-lvivier@redhat.com> <6d0c5777-ed50-4e99-96cb-35aa38d0e129@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: OZJ54WRXOVI6QUTKEPADEFAMR3ZXORBO X-Message-ID-Hash: OZJ54WRXOVI6QUTKEPADEFAMR3ZXORBO X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 3/21/24 11:55, David Gibson wrote: > On Thu, Mar 21, 2024 at 09:26:58AM +0100, Laurent Vivier wrote: >> On 3/21/24 02:26, David Gibson wrote: >>> On Wed, Mar 20, 2024 at 05:31:46PM +0100, Laurent Vivier wrote: >>>> To be able to provide pointers to TCP headers and IP headers without >>>> worrying about alignment in the structure, split the structure into >>>> several arrays and point to each part of the frame using an iovec array. >>>> >>>> Using iovec also allows us to simply ignore the first entry when the >>>> vnet length header is not needed. >>>> >>>> Signed-off-by: Laurent Vivier >>> >>> [snip] >>>> +static_assert(MSS4 <= sizeof(tcp4_payload[0].data)); >>> >>> This generates a clang-tidy warning, because apparently the C11 >>> version of static_assert() requires a message - making it optional is >>> a C2x extension. >>> >>> Laurent, I know you're having trouble getting the full testsuite to >>> run (but some ideas on that later today, I hope). But could you >>> please add a "make cppcheck" and "make clang-tidy" to your pre-post >>> routine. >>> >> >> I'll do. >> Thank you to have checked that. >> Are there any other commands to run before to send? >> Something like scripts/chekpatch.pl we have in QEMU? >> >> I have always the same problem with the test suite, even after a "make >> realclean" in test (see attachment) >> How to debug? > > Huh. Guest kernel can't find root. That's not a fault I was > expecting (and alas, won't be helped by the patch I have in the > works). > > What's really weird is I don't see any signs of loading the initrd > before that failure, and with the mbuto images we're using we should > never *leave* the initrd. Which kind of makes sense - if it's not > seeing the initrd, then there is indeed no root to mount. > > Can you gran the full qemu command line it's trying to use? > My file mbuto seems to be empty: $ cd test/ $ make ./mbuto/mbuto -p ./passt.mem.mbuto -c lz4 -f mbuto.mem.img Applying profile from file ./passt.mem.mbuto depmod: WARNING: could not open modules.builtin.modinfo at /tmp/tmp.0Xr88SNogx/lib/modules/6.7.9-200.fc39.x86_64: No such file or directory Size: bin 4.9M lib 15M kmod 218k total 20M compressed 4.1k KERNEL=/boot/vmlinuz-6.7.9-200.fc39.x86_64 INITRD=/home/lvivier/Projects/passt/test/mbuto.mem.img initramfs mounted at: /tmp/tmp.0Xr88SNogx $ ls -l /home/lvivier/Projects/passt/test/mbuto.mem.img -rw-r--r--. 1 lvivier lvivier 50 Mar 21 13:17 /home/lvivier/Projects/passt/test/mbuto.mem.img $ gzip -d - < /home/lvivier/Projects/passt/test/mbuto.mem.img|hexdump -C 00000000 30 37 30 37 30 31 30 30 30 30 30 30 30 30 30 30 |0707010000000000| 00000010 30 30 30 30 30 30 30 30 30 30 30 30 30 30 30 30 |0000000000000000| 00000020 30 30 30 30 30 30 30 30 30 30 30 30 30 31 30 30 |0000000000000100| 00000030 30 30 30 30 30 30 30 30 30 30 30 30 30 30 30 30 |0000000000000000| * 00000060 30 30 30 30 30 42 30 30 30 30 30 30 30 30 54 52 |00000B00000000TR| 00000070 41 49 4c 45 52 21 21 21 00 00 00 00 00 00 00 00 |AILER!!!........| 00000080 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| * 00000200 Thanks, Laurent