From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=VFFvrZ99; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 94D9D5A061E for ; Wed, 13 Nov 2024 08:13:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731482028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Lt4QVY1gCzYByjEKvEzN+cF2wAZ8rUJ/SHGOaQmth/g=; b=VFFvrZ99NHH+FjVN5q+N9vrd+Ncags0JRgdXFejLZP/8P/l7SIYR/XEFh9DDUj8uLBrO5c UVsHX3NhG1KgkdijxFSj78+cSzJYX7YclN9VCHwQTiGLxvsY3wZcNqYnJV+qRWcMaLR1YI 4yAppm104NIkAlpTrMPYRxbffsgwXtU= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-623-VQWeMvqjPS6_WXMepjJXeQ-1; Wed, 13 Nov 2024 02:13:46 -0500 X-MC-Unique: VQWeMvqjPS6_WXMepjJXeQ-1 X-Mimecast-MFC-AGG-ID: VQWeMvqjPS6_WXMepjJXeQ Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-37d603515cfso3424360f8f.1 for ; Tue, 12 Nov 2024 23:13:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731482025; x=1732086825; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Lt4QVY1gCzYByjEKvEzN+cF2wAZ8rUJ/SHGOaQmth/g=; b=lMXCu0n3HiqsfV/01Yg6TlGrCwG5NwvfXsf8t4o6zsi6QrC9cJ2pHRTY/dp/fBUW0s jCXut2hy3E1TA0YlFFE1hkbRj3Et+pFchlLUVs/3S0/pkiHjXxp2rAQn+aOxasbIwhow b3s8gDQCvjjeM4z5dvW2oR2puRZrToNA89voi5KcDsbnrhFXSCPg6gubhDH3trWA3knA BUC5mvMGsisJjMRP32GZcbtlsrooV6gCdGz1V3XtSIpb4m89XELDC04W0AO7huLdjj8D OruoDEkqo7v9OfK63I9I2YHHw1l3lB/rW0+yYMmD9FgOkr+hU1JvUzPcvIFd1AjqY+NF iCjw== X-Gm-Message-State: AOJu0YzQ25ur2JnBFLBqZJqE8SyqQZZ+jMPUrQNFQP7CvxcvUoIHB8mT c5JQ+bKPKxEoRxlBoVNLN98LszX9eSPZ7TjOIineW5Jb5ZzdSLqyOWTFU8qUz6t3BNfnKQqB1M7 0mjtqJzhiAZ5OoG+8xklYehUuzil0yBuXdiAG9UEA0GTDJxp6NvMFD9lCsg== X-Received: by 2002:a5d:64c5:0:b0:37d:3973:cb8d with SMTP id ffacd0b85a97d-381f18672d9mr16739067f8f.24.1731482025498; Tue, 12 Nov 2024 23:13:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEeHtbbNihb3SSlTem1cwWp2zXiBn1yAMhbOyvFkxUcrU9HherBE5t8qDSkq5qP+gGL/XdRkQ== X-Received: by 2002:a5d:64c5:0:b0:37d:3973:cb8d with SMTP id ffacd0b85a97d-381f18672d9mr16739057f8f.24.1731482025190; Tue, 12 Nov 2024 23:13:45 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed970e23sm17379869f8f.18.2024.11.12.23.13.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Nov 2024 23:13:44 -0800 (PST) Message-ID: Date: Wed, 13 Nov 2024 08:13:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 07/12] vhost-user: add vhost-user To: David Gibson References: <20241108103733.3554357-1-lvivier@redhat.com> <20241108103733.3554357-8-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cuN29jaUs2midtE3u6mJs6tqRZo__T8ad5qduiEVwt8_1731482026 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: EGB64FUXAY5PTTQBTAKEZIJ4EUDUDLOL X-Message-ID-Hash: EGB64FUXAY5PTTQBTAKEZIJ4EUDUDLOL X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/11/2024 03:47, David Gibson wrote: >> + if (flow_sidx_valid(sidx)) { >> + flow_sidx_t fromsidx = flow_sidx_opposite(sidx); >> + struct udp_flow *uflow = udp_at_sidx(sidx); >> + >> + flow_err(uflow, >> + "No support for forwarding UDP from %s to %s", >> + pif_name(pif_at_sidx(fromsidx)), >> + pif_name(pif)); >> + } else { >> + debug("Discarding 1 datagram without flow"); >> + } >> + >> + continue; >> + } >> + >> + toside = flowside_at_sidx(sidx); >> + >> + v6 = !(inany_v4(&toside->eaddr) && inany_v4(&toside->oaddr)); >> + >> + iov_used = udp_vu_sock_recv(c, ref.fd, events, v6, &dlen); >> + if (iov_used <= 0) >> + break; >> + >> + udp_vu_prepare(c, toside, dlen); >> + if (*c->pcap) { >> + udp_vu_csum(toside, iov_used); >> + pcap_iov(iov_vu, iov_used, >> + sizeof(struct virtio_net_hdr_mrg_rxbuf)); >> + } >> + vu_flush(vdev, vq, elem, iov_used); > Do you really want to flush on every datagram? To do like that avoids complexity in the code, but you're right it could be improved but I would prefer to do that once this series is merged with a follow up code. This kind of change is prone to introduce bugs... Thanks, Laurent