From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=GpTOb+KG; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 1E3E15A0623 for ; Thu, 14 Nov 2024 16:16:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731597414; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=p0iHPE3D0nkGZTDp4z1MBMnv/ilmexVwr0c5LYlKTqs=; b=GpTOb+KGzFxJKD+taLD+I0DzL7VVXhf46Tc/IEBNBBxgO/LjQI7RhbZ/i7FcUKnDFsf0S/ OBdOz5v9ymLosTauqhVctFqzeYT/HEdgblQoI7Md+PkXBPS+7JTKD/5qZL4PY1Z3oAvtli zYUP0PbpEJiPb3PaHLmW4MKxC1QPJKg= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-62-g2f_nJRqPXm4vT7kAY_nbw-1; Thu, 14 Nov 2024 10:16:51 -0500 X-MC-Unique: g2f_nJRqPXm4vT7kAY_nbw-1 X-Mimecast-MFC-AGG-ID: g2f_nJRqPXm4vT7kAY_nbw Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-460dd31b4c1so10522081cf.1 for ; Thu, 14 Nov 2024 07:16:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731597411; x=1732202211; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p0iHPE3D0nkGZTDp4z1MBMnv/ilmexVwr0c5LYlKTqs=; b=VoWW2EpMWtH3SnrzV7WCqUixa8zOm+B8IsgbffCMDetfQZuZx5SZ4Rk+pFrLbAnKp7 HPtnnpn7+E4Ev089Zxl8j7xHppE3EAvorvq1z/s1aWqc3wTflGFPzYfCp55N4H4mn9JC Zn56TTQ/8jtXn7Ge0jxcvlyIx9AflGQ18uE6FYMkGDKa6Qv8ACJM7ro9aQu2UQU/i2kh A9Xl81Cm75CndhKYKcqmMuF0hHQxbBgmA4KQEfWncjPhmB1y7W/8cBRl6C80ckt5Iw+9 A6N/4fk1BOeooKV6ismvYHil/bUJsfvmqr1YlaeHVmL2SpTfsMMPXtcRR/rCvLsNYPMs HGJg== X-Gm-Message-State: AOJu0Yyk8qg3t2+vm4nn4RcDZAK8TPIWItk7uLeXMeXyNO8v3u8HoEvf TDF4C/y38AYJdBfOxLoF9msLiewJ0OJadcIRoqaztAm9UdmB5GNKoZG+/wPEIzd+mlmYNLL6bHk aPlEnJJX+FX3Ovy6W4rwa8PxOZcdr/I+1TV6sh5c+gJ+2W76bFJOvSJPQDA== X-Received: by 2002:a05:622a:144:b0:460:42f7:fa3f with SMTP id d75a77b69052e-46358f2472dmr29741881cf.19.1731597411132; Thu, 14 Nov 2024 07:16:51 -0800 (PST) X-Google-Smtp-Source: AGHT+IFLlHD8jy6deTMcqBl5VE21QHYJwYoWgxlR8ra/PqPcewZFdjUoX9Mig9nlsdN5SbDZdcfrog== X-Received: by 2002:a05:622a:144:b0:460:42f7:fa3f with SMTP id d75a77b69052e-46358f2472dmr29741461cf.19.1731597410745; Thu, 14 Nov 2024 07:16:50 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4635a9e97b8sm6654591cf.25.2024.11.14.07.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 07:16:50 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 16:16:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 7/8] vhost-user: add vhost-user To: Stefano Brivio References: <20241010122903.1188992-1-lvivier@redhat.com> <20241010122903.1188992-8-lvivier@redhat.com> <20241017021034.437f3757@elisabeth> <880fe7a3-4925-49a0-8253-e130f976039e@redhat.com> <20241114152312.7c5ac1cd@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241114152312.7c5ac1cd@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 79wT3jq_WNiwPLlweDtnovOLLEtZf6RoLbuyTxIDWIc_1731597411 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 2XU5232YE6L6CCJKJK4FVUWD3Q5UZ234 X-Message-ID-Hash: 2XU5232YE6L6CCJKJK4FVUWD3Q5UZ234 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 14/11/2024 15:23, Stefano Brivio wrote: > On Thu, 14 Nov 2024 11:20:09 +0100 > Laurent Vivier wrote: > >> On 17/10/2024 02:10, Stefano Brivio wrote: >>>> + if (frame_size == 0) >>>> + first = &iov_vu[i + 1]; >>>> + >>>> + if (iov_vu[i + 1].iov_len > (size_t)len) >>>> + iov_vu[i + 1].iov_len = len; >>>> + >>>> + len -= iov_vu[i + 1].iov_len; >>>> + iov_used++; >>>> + >>>> + frame_size += iov_vu[i + 1].iov_len; >>>> + num_buffers++; >>>> + >>>> + if (frame_size >= mss || len == 0 || >>>> + i + 1 == iov_cnt || !vu_has_feature(vdev, VIRTIO_NET_F_MRG_RXBUF)) { >>>> + if (i + 1 == iov_cnt) >>>> + check = NULL; >>>> + >>>> + /* restore first iovec base: point to vnet header */ >>>> + vu_set_vnethdr(vdev, first, num_buffers, l2_hdrlen); >>>> + >>>> + tcp_vu_prepare(c, conn, first, frame_size, &check); >>>> + if (*c->pcap) { >>>> + tcp_vu_update_check(tapside, first, num_buffers); >>>> + pcap_iov(first, num_buffers, >>>> + sizeof(struct virtio_net_hdr_mrg_rxbuf)); >>>> + } >>>> + >>>> + conn->seq_to_tap += frame_size; >>> We always increase this, even if, later... >>> >>>> + >>>> + frame_size = 0; >>>> + num_buffers = 0; >>>> + } >>>> + } >>>> + >>>> + /* release unused buffers */ >>>> + vu_queue_rewind(vq, iov_cnt - iov_used); >>>> + >>>> + /* send packets */ >>>> + vu_flush(vdev, vq, elem, iov_used); >>> we fail to send packets, that is, even if vu_queue_fill_by_index() >>> returns early because (!vq->vring.avail). >> >> vring.avail is a pointer to a structure. vring.avail is NULL if there is something wrong >> during the initialization. It's imported code, I think it's only a sanity check. >> So in theory vu_flush() cannot fail. > > Oh, I see now. I actually think it's preferable to crash in that > (theoretically impossible) case, without even an ASSERT() (we would > dereference a NULL pointer, eventually, even if not here). > So what you propose is to remove the "if (!vq->vring.avail) return;"? Thanks Laurent