From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ReAum/8t; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B885D5A026F for ; Tue, 04 Nov 2025 16:18:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1762269486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DaoEopDIVunTJv3fwpZadFhwL6vj5FPk6HbQIdgjvSI=; b=ReAum/8tODdmcEiYr0ebxRrvSJMxc++jaaqlqaZCWBN5DKPZsQF8JIviMIhiIvpxw97H6w BY9s8p9J6Lj/GGgEbgZG0mist/4CGJ+Wr3wAL7WJgmi+AzldP7VqIhCW+nkUTAkt4c74i5 /SPivFDajuF+Ckr8DZEWn1UWRC+hFwQ= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-wB-JP5fTP36dD4tsVIrBQA-1; Tue, 04 Nov 2025 10:18:05 -0500 X-MC-Unique: wB-JP5fTP36dD4tsVIrBQA-1 X-Mimecast-MFC-AGG-ID: wB-JP5fTP36dD4tsVIrBQA_1762269484 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-429c7b0ae36so1986429f8f.0 for ; Tue, 04 Nov 2025 07:18:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762269484; x=1762874284; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DaoEopDIVunTJv3fwpZadFhwL6vj5FPk6HbQIdgjvSI=; b=Yiejd8SG5EJgEgNlbXkPkzBwmEiwaiqCtO3J8lBSyml5a6FIudyznv5GCCKkQvW43E /vlcTZTjTVLAUgLsiaa7+Fu3Rq1HSvhpNciAk5KAb5NdZiVZXCpbDpMFlG3au98kN1RT oR07xtxQSTLRJrxOhe7KGxTapJAQ5eyXvgANZCztFIRJ+8IYe+jmyzgPOlrq1DMVyriu S1aO2abf/Le6+LGpgHEfvAZ+4UAVDRaFky81KS2c0kcjg5lgGpVQdMZyRX/5gpSnl5jr NmrRtsAk8xPZ1uvOqXp0n2GBe07Yop+gens6BYUmDj57ghEXE78yByxry8zz+RJx6t1w dc9w== X-Forwarded-Encrypted: i=1; AJvYcCXJLh9n5oeiKel1mCQ/EJOeNqXsb72fkBfyz/c3ynqoFrcs709HTD6k2u2JWqJ5Qd9Gm2MHUu5ziJU=@passt.top X-Gm-Message-State: AOJu0YxzzVYh5h+ju3Q5akSkVHF+ZkNgC1sRyl9VWEdZb/4miLA+XU0O haiJnCuWKv4TLBigaNmiivYeoNiJdzxSRcgPKdXiWjnh5JZ510nBjXVQVrCpt8me8LwxhDo2dr3 duU7sx4yDaF97SjQ9E9JXvuDm3yedFehAuaTFYy5pcaHEM/Nzj59a+A== X-Gm-Gg: ASbGnctPB4lcMiCfQIUnE0/JEkc1HWreAehrDR+7sGUbqQ5wvwcvQvnlVMig8cyJOKc 6Vt4RRC4qq37wF/HYcMwHxXirjHWyXOw+67BTPvaPDxKFXyDzTAOo1PtHYr0AnkmuTfOvIxQkwV qKw3DSRyYZ6sgVh1cV3rnglCjeAK0OxtpiEcwYqydlbW2xcCK5J9AettyyEif6+cLjo1i2AJRT0 75JchftuPJ2XKOCfRJRCragvs+/bg+XOIx2CKEtyMj+x1YrYvMCHqSgkkZO0oz6KC0wU9NnTRJw +JUNswl1B1ornqf7dZcMZnsS5zgUN+38yncXFqfEqkqb06kRGJaAl4LLEJ2Wb16i2OIfJ+fnmfi 3oI1uQZFMp2hOM7OdkxNpFBk9j71CQR0fBeyKew== X-Received: by 2002:a05:6000:2087:b0:429:a89d:ecef with SMTP id ffacd0b85a97d-429dbce5dfdmr3171249f8f.13.1762269483899; Tue, 04 Nov 2025 07:18:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHCwRBni7sKMk9P1Ig8kQ4513IFdjd4MPcIoS3rNxkGLSGl4lISkDDU7QbAUpvp/TZ7PAJZ7Q== X-Received: by 2002:a05:6000:2087:b0:429:a89d:ecef with SMTP id ffacd0b85a97d-429dbce5dfdmr3171222f8f.13.1762269483484; Tue, 04 Nov 2025 07:18:03 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47751794620sm91777575e9.6.2025.11.04.07.18.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Nov 2025 07:18:03 -0800 (PST) Message-ID: Date: Tue, 4 Nov 2025 16:18:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 2/5] tcp: Fix coding style for comment to enum tcp_iov_parts To: Stefano Brivio , passt-dev@passt.top References: <20251103101612.1412079-1-sbrivio@redhat.com> <20251103101612.1412079-3-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251103101612.1412079-3-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: KpS-HibndWtqIdfNklVhRYvQAd8v4XMvYYvJjX0XE_A_1762269484 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 5OTIF3QN6BKL4CFKS4JPQSMJ4EIVGSDU X-Message-ID-Hash: 5OTIF3QN6BKL4CFKS4JPQSMJ4EIVGSDU X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/3/25 11:16, Stefano Brivio wrote: > ...as I'm going to add a new value to it. > > Fixes: 95601237ef82 ("tcp: Replace TCP buffer structure by an iovec array") > Signed-off-by: Stefano Brivio > --- > tcp_internal.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcp_internal.h b/tcp_internal.h > index f55025c..19e8922 100644 > --- a/tcp_internal.h > +++ b/tcp_internal.h > @@ -57,7 +57,7 @@ > #define CONN_V4(conn) (!!inany_v4(&TAPFLOW(conn)->oaddr)) > #define CONN_V6(conn) (!CONN_V4(conn)) > > -/* > +/** > * enum tcp_iov_parts - I/O vector parts for one TCP frame > * @TCP_IOV_TAP tap backend specific header > * @TCP_IOV_ETH Ethernet header Reviewed-by: Laurent Vivier