From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=V+eHXSx/; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 934C25A0279 for ; Thu, 11 Sep 2025 02:38:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757551123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ubXwCRxPss9LtkvrfarURPg8SY0/qqb/rTk589H3r5I=; b=V+eHXSx/7JGGhmFAzTpAH8fJYqJxMAThUQAt+LlXEgVpW8cltaP7fEn9YTagnSxWtFIvje Irafv0iiM8ZQBd2nLSyIcydy6DtVeRDqW2sVSbs6Xsfw1TXUv2fCkXMeVYW1qEMlAo1EdL Fk2wuI+21kqIn2w91jaawBfw1FGQrhQ= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-225-8MSYO9nRP9Gvg7Cso1FLLw-1; Wed, 10 Sep 2025 20:38:37 -0400 X-MC-Unique: 8MSYO9nRP9Gvg7Cso1FLLw-1 X-Mimecast-MFC-AGG-ID: 8MSYO9nRP9Gvg7Cso1FLLw_1757551117 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-7248ed9f932so1778096d6.3 for ; Wed, 10 Sep 2025 17:38:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757551117; x=1758155917; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ubXwCRxPss9LtkvrfarURPg8SY0/qqb/rTk589H3r5I=; b=LQZf2rw/XepyOXoeqruXsUb1L9BEb4KGJ9dbsSrvkznM/mD18vztCz1OMrGgCDOtCA OnDYwpInZAuD6QcOQ3GrM7jahhXUdBOsCahJb22QL6qOgRnBhYbcIS5MVrM0l4tJCPbj Fn/hf32Y1fpQLjxHnF4OUEnRtm5YU+DONXALXf+ZoQPL7XZRdC3j5prcd4LUx9WEB93d 1oAv2222IVpkKCg1UGXlCNgwtZ5BvmpAklSdQNgvBDT+r9EH+2HYbTt3qTE5dpDJHb0w 4PphwD0HHV97GdUbFv+nCJIfVRGH3tV7t74tr+4Npt479N6PZxTFiu1fOtgC+MQtSeNb D9nQ== X-Forwarded-Encrypted: i=1; AJvYcCUYPgQ8nBpwVQfln4mThTzSzM9H6UwDDMY2VjWgsBq8HgEjYzNszcNnQ55dG3y5n7l3KFCBV2vEswU=@passt.top X-Gm-Message-State: AOJu0YzIinWEM2sIcBBb9xnsYJ8EFtMcZ2GgCSdsfb6Ubstqv7oW1a70 esLs4ss0vZLXtXucw0e6qLYN//69fAeYXxLH6qSWGarWPbx1iavDj9L9KUuCdbIl2+KrlbXRmWF 8nMXVvR1B6TMhA6iHAT7Pfq7n/4rP7eIWJ9mAO3VjOM6/EPOevpLu+A== X-Gm-Gg: ASbGncvbhfIZO2dwhcwYxqlU2TKPPhDF4en4wrnvK8q5WSzgAMn5U5dl4UpINm/EC8d LYBVV+EpVjrpnhclzZl1xxkfzFFduiEbBM1JrWBjUuLNpwP0dBewO1Tu02uOaeIpzpukto33syZ pUU/Kermv3qF6pXVZKUd7veXbUsV/E9m3qpUPeKE6C0yGdw5+FT4H4RmB5hEKELng9UnpFCabaJ hOwNsCC4/GC+qZGbFwafaxxGijXvL4gnPdjJ1OzDfcbfRgx6kzysTATslv6MXZNmHmM0LB3c3Lg NsXapdg2UH/1Qe2T6EL0KCIzHCxD+pBfYUUdzSfmt3vZZHlur8f/lI779c6N8eZ/uRyZTEynf3B 7GU/7eueVug== X-Received: by 2002:a05:620a:1994:b0:81d:4345:6e9a with SMTP id af79cd13be357-81d43456fc9mr657215585a.56.1757551117174; Wed, 10 Sep 2025 17:38:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF4uGRLQB3kI0ycQypdPUxkCiLWsjkeDadSMuzfpWIUS8P3WcuSXvx5lsy+lD2rxTa5gyUnQg== X-Received: by 2002:a05:620a:1994:b0:81d:4345:6e9a with SMTP id af79cd13be357-81d43456fc9mr657213285a.56.1757551116663; Wed, 10 Sep 2025 17:38:36 -0700 (PDT) Received: from ?IPV6:2001:4958:2206:8901:6025:1483:4146:72dd? ([2001:4958:2206:8901:6025:1483:4146:72dd]) by smtp.gmail.com with ESMTPSA id af79cd13be357-820cd70141esm9620385a.36.2025.09.10.17.38.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Sep 2025 17:38:36 -0700 (PDT) Message-ID: Date: Wed, 10 Sep 2025 20:38:35 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] tcp: Don't send FIN segment to guest yet if we have pending unacknowledged data To: Stefano Brivio , passt-dev@passt.top References: <20250909181655.2990223-1-sbrivio@redhat.com> <20250909181655.2990223-9-sbrivio@redhat.com> From: Jon Maloy In-Reply-To: <20250909181655.2990223-9-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Mb8gcaLTutEbc5CY9bOn-V5R2GbeHBKsSAj-RL6Csmc_1757551117 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Message-ID-Hash: ZP7KLSAA7RCK6HCICMF5AKGIHP3KD23Q X-Message-ID-Hash: ZP7KLSAA7RCK6HCICMF5AKGIHP3KD23Q X-MailFrom: jmaloy@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Paul Holzinger , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: DQoNCk9uIDIwMjUtMDktMDkgMTQ6MTYsIFN0ZWZhbm8gQnJpdmlvIHdyb3RlOg0KPiBGb3Igc29t ZSByZWFzb24sIHRjcF92dV9kYXRhX2Zyb21fc29jaygpIGFscmVhZHkgdGFrZXMgY2FyZSBvZiB0 aGlzLA0KPiBidXQgdGhlIG5vbi12aG9zdC11c2VyIHZlcnNpb24gaWdub3JlcyB0aGlzIHBvc3Np YmlsaXR5IGFuZCBqdXN0IHNlbmRzDQo+IG91dCBhIEZJTiBzZWdtZW50IHdoZW5ldmVyIHdlIGlu ZmVyIHdlIHJlY2VpdmVkIG9uZSBob3N0LXNpZGUsDQo+IHJlZ2FyZGxlc3Mgb2YgdGhlIGZhY3Qg dGhhdCB3ZSBtaWdodCBoYXZlIHVuYWNrbm93bGVkZ2VkIGRhdGEgc3RpbGwgdG8NCj4gc2VuZC4N Cj4gDQo+IFNvbWV3aGF0IHN1cnByaXNpbmdseSwgdGhpcyBkaWRuJ3QgY2F1c2UgYW55IGlzc3Vl IHRvIGJlIHJlcG9ydGVkIHlldCwNCj4gdW50aWwgNi4xNy1yYzEgYW5kIDFkMmZiYWFkN2NkOCAo InRjcDogc3Ryb25nZXIgc2tfcmN2YnVmIGNoZWNrcyIpDQo+IGNhbWUgYXJvdW5kLCBsZWFkaW5n IHRvIHRoZSBmb2xsb3dpbmcgcmVwb3J0IGZyb20gUGF1bCwgd2hvIGhpdCB0aGlzDQo+IHJ1bm5p bmcgUG9kbWFuIHRlc3RzOg0KPiANCj4gICAgNDM5ICAgMC4wMzMwMzIgIDE2OS4yNTQuMS4yIOKG kiAxOTIuMTY4LjEyMi4xMDAgNjU1NDAgVENQIDU2NjAyIOKGkiA1Nzg5IFtQU0gsIEFDS10gU2Vx PTEwMzM2MzYxIEFjaz0xIFdpbj02NTUzNiBMZW49NjU0ODANCj4gICAgNDQwICAgMC4wMzMwNTUg IDE2OS4yNTQuMS4yIOKGkiAxOTIuMTY4LjEyMi4xMDAgMzAzMjQgVENQIFtUQ1AgV2luZG93IEZ1 bGxdIDU2NjAyIOKGkiA1Nzg5IFtQU0gsIEFDS10gU2VxPTEwNDAxODQxIEFjaz0xIFdpbj02NTUz NiBMZW49MzAyNjQNCj4gDQo+IHdlJ3JlIHNlbmRpbmcgZGF0YSB0byB0aGUgY29udGFpbmVyLCB1 cCB0byB0aGUgZWRnZSBvZiB0aGUgd2luZG93DQo+IA0KPiAgICA0NDEgICAwLjAzMzA1OSAxOTIu MTY4LjEyMi4xMDAg4oaSIDE2OS4yNTQuMS4yICA2MCBUQ1AgNTc4OSDihpIgNTY2MDIgW0FDS10g U2VxPTEgQWNrPTEwNDAxODQxIFdpbj04Mzk2OCBMZW49MA0KPiANCj4gYW5kIHRoZSBjb250YWlu ZXIgYWNrbm93bGVkZ2VzIGl0DQo+IA0KPiAgICA0NDIgICAwLjAzMzA5MSAgMTY5LjI1NC4xLjIg 4oaSIDE5Mi4xNjguMTIyLjEwMCA1MzcxNiBUQ1AgNTY2MDIg4oaSIDU3ODkgW1BTSCwgQUNLXSBT ZXE9MTA0MzIxMDUgQWNrPTEgV2luPTY1NTM2IExlbj01MzY1Ng0KPiANCj4gd2Ugc2VuZCBtb3Jl IGRhdGEsIGFsbCB3ZSBwb3NzaWJseSBjYW4sIGluIHdpbmRvdw0KPiANCj4gICAgNDQzICAgMC4w MzMxMjYgMTkyLjE2OC4xMjIuMTAwIOKGkiAxNjkuMjU0LjEuMiAgNjAgVENQIFtUQ1AgWmVyb1dp bmRvd10gNTc4OSDihpIgNTY2MDIgW0FDS10gU2VxPTEgQWNrPTEwNDMyMTA1IFdpbj0wIExlbj0w DQo+IA0KPiBhbmQgdGhlIGNvbnRhaW5lciBzaHJpbmtzIHRoZSB3aW5kb3cgZHVlIHRvIHRoZSBp c3N1ZSBpbnRyb2R1Y2VkDQo+IGJ5IGtlcm5lbCBjb21taXQgZTIxNDI4MjVjMTIwICgibmV0OiB0 Y3A6IHNlbmQgemVyby13aW5kb3cgQUNLIHdoZW4gbm8NCj4gbWVtb3J5IikuIFdpdGggYSBwcmV2 aW91cyBwYXRjaCBmcm9tIHRoaXMgc2VyaWVzLCB3ZSByZXdpbmQgdGhlDQo+IHNlcXVlbmNlLCBt ZWFuaW5nIHRoYXQgd2UgYXNzaWduIGNvbm4tPnNlcV90b190YXAgZnJvbQ0KPiBjb25uLT5zZXFf YWNrX2Zyb21fdGFwLCBzbyB0aGF0IHdlJ2xsIHJldHJhbnNtaXQgdGhpcyBzZWdtZW50LCBieQ0K PiByZWFkaW5nIGFnYWluIGZyb20gdGhlIHNvY2tldCwgYW5kIGluY3JlYXNpbmcgY29ubi0+c2Vx X3RvX3RhcA0KPiBvbmNlIG1vcmUuDQo+IA0KPiBIb3dldmVyOg0KPiANCj4gICAgNDQ0ICAgMC4w MzMxNDQgIDE2OS4yNTQuMS4yIOKGkiAxOTIuMTY4LjEyMi4xMDAgNjAgVENQIDU2NjAyIOKGkiA1 Nzg5IFtGSU4sIFBTSCwgQUNLXSBTZXE9MTA0ODU3NjEgQWNrPTEgV2luPTY1NTM2IExlbj0wDQo+ IA0KPiB3ZSBldmVudHVhbGx5IGdldCBhIHplcm8tbGVuZ3RoIHJlYWQgZnJvbSB0aGUgc29ja2V0 IGFuZCB3ZSBtaXNzIHRoZQ0KPiBmYWN0IHRoYXQgY29ubi0+c2VxX3RvX3RhcCAhPSBjb25uLT5z ZXFfYWNrX2Zyb21fdGFwLCBzbyB3ZSBzZW5kIGENCj4gRklOIGZsYWcgd2l0aCB0aGUgbW9zdCBy ZWNlbnQgc2VxdWVuY2UuIFRoZSBrZXJuZWwgaW5zaXN0czoNCj4gDQo+ICAgIDQ0NSAgIDAuMDMz MTQ3IDE5Mi4xNjguMTIyLjEwMCDihpIgMTY5LjI1NC4xLjIgIDYwIFRDUCBbVENQIFplcm9XaW5k b3ddIDU3ODkg4oaSIDU2NjAyIFtBQ0tdIFNlcT0xIEFjaz0xMDQzMjEwNSBXaW49MCBMZW49MA0K PiANCj4gd2l0aCBpdHMgYnVnZ3kgemVyby13aW5kb3cgdXBkYXRlLCBidXQ6DQo+IA0KPiAgICA0 NDYgICAwLjAzMzE1MiAxOTIuMTY4LjEyMi4xMDAg4oaSIDE2OS4yNTQuMS4yICA2MCBUQ1AgW1RD UCBXaW5kb3cgVXBkYXRlXSA1Nzg5IOKGkiA1NjYwMiBbQUNLXSBTZXE9MSBBY2s9MTA0MzIxMDUg V2luPTY5MTIwIExlbj0wDQo+ICAgIDQ0NyAgIDAuMDMzMjAyIDE5Mi4xNjguMTIyLjEwMCDihpIg MTY5LjI1NC4xLjIgIDYwIFRDUCBbVENQIFdpbmRvdyBVcGRhdGVdIDU3ODkg4oaSIDU2NjAyIFtB Q0tdIFNlcT0xIEFjaz0xMDQzMjEwNSBXaW49MTQyODQ4IExlbj0wDQo+IA0KPiB3ZSBkb24ndCBy ZXNldCB0aGUgVEFQX0ZJTl9TRU5UIGZsYWcgYW55bW9yZSwgYW5kIGRvbid0IHJlc2VuZA0KPiB0 aGUgRklOIHNlZ21lbnQgKG5vciBkYXRhKSwgYXMgd2UgYWxyZWFkeSByZXdvdW5kIHRoZSBzZXF1 ZW5jZQ0KPiBlYXJsaWVyLg0KPiANCj4gVG8gc29sdmUgdGhpcywgaG9sZCBvZmYgdGhlIEZJTiBz ZWdtZW50IHVudGlsIHdlIGdldCBhIHplcm8tbGVuZ3RoDQo+IHJlYWQgZnJvbSB0aGUgc29ja2V0 ICphbmQqIHdlIGtub3cgdGhhdCB0aGVyZSdzIG5vIHVuYWNrbm93bGVkZ2VkDQo+IHBlbmRpbmcg ZGF0YSwgYWxzbyB3aXRob3V0IHZob3N0LXVzZXIsIGluIHRjcF9idWZfZGF0YV9mcm9tX3NvY2so KS4NCj4gDQo+IFJlcG9ydGVkLWJ5OiBQYXVsIEhvbHppbmdlciA8cGhvbHppbmdAcmVkaGF0LmNv bT4NCj4gU2lnbmVkLW9mZi1ieTogU3RlZmFubyBCcml2aW8gPHNicml2aW9AcmVkaGF0LmNvbT4N Cg0KUmV2aWV3ZWQtYnk6IEpvbiBNYWxveSA8am1hbG95QHJlZGhhdC5jb20+DQoNCj4gLS0tDQo+ ICAgdGNwX2J1Zi5jIHwgNSArKysrLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMo KyksIDEgZGVsZXRpb24oLSkNCj4gDQo+IGRpZmYgLS1naXQgYS90Y3BfYnVmLmMgYi90Y3BfYnVm LmMNCj4gaW5kZXggNGViYjAxMy4uNDliZGRiZSAxMDA2NDQNCj4gLS0tIGEvdGNwX2J1Zi5jDQo+ ICsrKyBiL3RjcF9idWYuYw0KPiBAQCAtMzYzLDcgKzM2MywxMCBAQCBpbnQgdGNwX2J1Zl9kYXRh X2Zyb21fc29jayhjb25zdCBzdHJ1Y3QgY3R4ICpjLCBzdHJ1Y3QgdGNwX3RhcF9jb25uICpjb25u KQ0KPiAgIAl9DQo+ICAgDQo+ICAgCWlmICghbGVuKSB7DQo+IC0JCWlmICgoY29ubi0+ZXZlbnRz ICYgKFNPQ0tfRklOX1JDVkQgfCBUQVBfRklOX1NFTlQpKSA9PSBTT0NLX0ZJTl9SQ1ZEKSB7DQo+ ICsJCWlmIChhbHJlYWR5X3NlbnQpIHsNCj4gKwkJCWNvbm5fZmxhZyhjLCBjb25uLCBTVEFMTEVE KTsNCj4gKwkJfSBlbHNlIGlmICgoY29ubi0+ZXZlbnRzICYgKFNPQ0tfRklOX1JDVkQgfCBUQVBf RklOX1NFTlQpKSA9PQ0KPiArCQkJICAgU09DS19GSU5fUkNWRCkgew0KPiAgIAkJCWludCByZXQg PSB0Y3BfYnVmX3NlbmRfZmxhZyhjLCBjb25uLCBGSU4gfCBBQ0spOw0KPiAgIAkJCWlmIChyZXQp IHsNCj4gICAJCQkJdGNwX3JzdChjLCBjb25uKTsNCg0K