From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=O62ofV6B; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 484115A026F for ; Tue, 21 Oct 2025 14:14:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761048848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=mqT0IOZiULRO50aztOLa63SQSkpNDQPnM+ZdUAQ9HMM=; b=O62ofV6BOX6TjZ+xgWym9Ndk+8IifmKNjQ3ec6dFwev0tw3CNCLKS7XgppUeJZh7I1/2so i7BHjBTevrQJjzXAxQZWAHNLmf+pDtsCdUil5wX3ld+hVnOtc/CayN7fsCw5a9VvsHmZUC sASsEclDNhVop+s/CuH7nJ9eieDp5Is= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-676-Dq5Go-7OPo6t6jugXCVt4A-1; Tue, 21 Oct 2025 08:14:06 -0400 X-MC-Unique: Dq5Go-7OPo6t6jugXCVt4A-1 X-Mimecast-MFC-AGG-ID: Dq5Go-7OPo6t6jugXCVt4A_1761048845 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3f7b5c27d41so3314554f8f.0 for ; Tue, 21 Oct 2025 05:14:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761048845; x=1761653645; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mqT0IOZiULRO50aztOLa63SQSkpNDQPnM+ZdUAQ9HMM=; b=RAkwghtv+qVy3evNCh9vnIVFq/bX+NxrLGfOY1eMXyADQD7NuhOuOcg4aW2hx0bfX4 H4ApEvF0LKvHuTO2t2EUzmKCGFZktFsm8O3/tee3pxGAFCLjXsO5g3hKm+0Ft/a50SkM CY8/+QkDcl08Yt1kvhmDvr9jo1JaTxYYMLIIXlVXm1NYzV5fauWx5VSQw7lj+wz5F3C1 1/QG21L3B+PLT6iSkhqVBTNsi4gPT2JEv9bIIXLCOY5YQm5ex1YuE2uWzLV7msktbV9l yG7X7V75gi5OZ6bs2EfvIaIvj+1R0X0Vkt5aF3FeCu9AcBb9+Nko2DZ22xXmdCLlaFUn CHGg== X-Gm-Message-State: AOJu0Yzikl1Secr6eQ/crMr6luAHRpk1oKYe2tMDDp3TUOdhgV3Ip9ox loHVcQWnG6JBsECNPa1YqTVCsOqOFPjx/JSgLbHWcorHyo9cM8mP0eyV89KhuJSpStFXR6nlQgR 53NS+d6IeuN/exV/1gt8nuOd0NuJcTfY498X2IdWRTr5AbDaUeoNb/PtzEkm4aQ== X-Gm-Gg: ASbGnctYwJVqyxXWLTml1P2XH7oti34bDy1ldPrRvDSPxeotAqZFP0kmKrCz7/ZKLlY M9h4w7ZoVnNnMYL/LEL54y0C9H496WlG8+/2Hw6g+HzRFTK79mE+Y15oD3JOrLvBD6j76Rri+2Z 810Z7HjoAhCTy14u4rpNu7SlSQbjsfiAeGKT1Ry3YDokCRA9riAwB6UwJnZK7I27Nla0TiLYcM+ uBmyyWBiM0oD1a/y5DQZZzUef3yrnsei9HxuiJD7IAeE1TZAP5YtpQypEAS9r23VTKLOtu+17Js 72vde6b8xXlXcKxkJl+V9k3YU5RRxNfCiTglduVfn9EnfhZUbE37DKPrefhuRwiX2XJ9nWPFrn0 pka9sj8d5EIcTHJMrU4tylPQUHfZlE7kIM17hhg== X-Received: by 2002:a05:6000:2486:b0:426:dac0:8ee8 with SMTP id ffacd0b85a97d-42704b4daa0mr13962490f8f.10.1761048844907; Tue, 21 Oct 2025 05:14:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBcG2YnPBC3c8BmRSEkSujEOlVNYIwiLgUCYlpSCpblDSGxCm7bt4SUtErXM+AREOeRKOb3w== X-Received: by 2002:a05:6000:2486:b0:426:dac0:8ee8 with SMTP id ffacd0b85a97d-42704b4daa0mr13962463f8f.10.1761048844425; Tue, 21 Oct 2025 05:14:04 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5bab52sm19864412f8f.22.2025.10.21.05.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 05:14:03 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 14:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/7] tcp, flow: Replace per-connection in_epoll flag with threadnb in flow_common To: David Gibson References: <20251017103129.229412-1-lvivier@redhat.com> <20251017103129.229412-5-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: cM4tBz-nbAFrK61F6rug_yI6aF0NgBt31wlvrXFQLpg_1761048845 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: CWMHA4EK4Y5ANLAPYRY3Z6PEHZXA7TZH X-Message-ID-Hash: CWMHA4EK4Y5ANLAPYRY3Z6PEHZXA7TZH X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/10/2025 03:34, David Gibson wrote: >> @@ -570,7 +572,8 @@ static void tcp_timer_ctl(const struct ctx *c, struct tcp_tap_conn *conn) >> } >> conn->timer = fd; >> >> - if (epoll_ctl(c->epollfd, EPOLL_CTL_ADD, conn->timer, &ev)) { >> + if (epoll_ctl(flow_epollfd(&conn->f), EPOLL_CTL_ADD, >> + conn->timer, &ev)) { > Possibly a question for an earlier patch, but is there a reason we > can't use epoll_add() here? > Yes, the fd we use in epoll_ctl() and the fd stored in ref are not the same. The fd in ref is conn->sock (epoll_add() takes fd from ref) but in epoll_ctl() we add conn->timer (the fd from timerfd_create()). Thanks, Laurent