From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=DC+lE9HL; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id B13085A004C for ; Thu, 17 Oct 2024 13:54:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729166085; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Aym6n2nmP7mwy+IKhm5GvGyPz88UiEKGBh8sR0rTd4Y=; b=DC+lE9HLkKV9bVY8bTHlJ2JmBsQ1nnQNLZJAKgP4KLMI62kUU2Aogt0s+8lmu/r3TPxmli VU9owztnBImS8dST/5bf3Ky0SJn8yI1mokY8GYick3RiH+hjhEYHUtmtLnCk2M8PMv/9uB aku/gIw1a3Y01k5lMeA3eL7e0LfVB/g= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-480-xoMmQrGSNl21zJ7w8fC8_g-1; Thu, 17 Oct 2024 07:54:42 -0400 X-MC-Unique: xoMmQrGSNl21zJ7w8fC8_g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-43159603c92so4604715e9.2 for ; Thu, 17 Oct 2024 04:54:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729166081; x=1729770881; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Aym6n2nmP7mwy+IKhm5GvGyPz88UiEKGBh8sR0rTd4Y=; b=QONLsK5zPSBPEH2FZou4ctUH0lPvhXvOLGwl6oNYj/Xds+EmpmtHRSNDJ2B8fJEAjN hMJRCdnnw32qwrIRSTb7oswynyEFK+ns+T4AlGxqDAOS47hbUwrD1Jvk4GLQglGJLBR6 zV8T1g6i4lv72/x/5xxe54+IHcMO4K/FWlwMeQXdcSuDTzdC90W4GqQC+LP2gLwAsDec Peqroi3+Rw27FZrKzqWjvUQ7x/qdSFDgoTGjYYj1lk1qcWTspeYYvrqw+FtuTwV5oh7i 7vGP3pnrpC/dlPiQEt8IcGCjDyeHeeuXdZluR5Rj5DlzfVEovWmXqOz/0jWJAHGHW4A5 tqRQ== X-Forwarded-Encrypted: i=1; AJvYcCXb/NPs9hli+WNYkPPX5ZT7mNTLFsSmx4lREqfD5UJbE5GgDSm2To/v/ozLQ8NrCIlJP0jxD6+MzZU=@passt.top X-Gm-Message-State: AOJu0Yxa+CTEBykfRfBpFzLkeKtOFFNMJCI+HsEbr0+lwLazzOuM0AHf mlDlOHJNUTRabcoHchOccD/Tuq+Ii4x1SnUJAMDbs/MJ/KSUMArNdOlx/ElsALpV+mznW0r9Ziy ql9ExiXJpJTBXw8wef2Tb6F9YIhRhsL9tLkCZaA8+n1vtfXHX+Q== X-Received: by 2002:a05:600c:510e:b0:42e:8d0d:bca5 with SMTP id 5b1f17b1804b1-431255d4dafmr143408025e9.2.1729166080999; Thu, 17 Oct 2024 04:54:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3a+j/ACvL5kRaJqcewYjLCiL0bbkkS6C8zj4GYFCgVObyOfwnmbfclZp13R4z5xPryf4n2A== X-Received: by 2002:a05:600c:510e:b0:42e:8d0d:bca5 with SMTP id 5b1f17b1804b1-431255d4dafmr143407795e9.2.1729166080581; Thu, 17 Oct 2024 04:54:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43158c4d9desm23703465e9.35.2024.10.17.04.54.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 04:54:39 -0700 (PDT) Message-ID: Date: Thu, 17 Oct 2024 13:54:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 7/8] vhost-user: add vhost-user To: Stefano Brivio References: <20241010122903.1188992-1-lvivier@redhat.com> <20241010122903.1188992-8-lvivier@redhat.com> <20241015215438.1595b4d7@elisabeth> <20241017021031.1adb421e@elisabeth> <20241017132503.0d174463@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241017132503.0d174463@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 6TQZPOUQ2KL7HVSFR6VYW33TG72AEGPP X-Message-ID-Hash: 6TQZPOUQ2KL7HVSFR6VYW33TG72AEGPP X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson , passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 17/10/2024 13:25, Stefano Brivio wrote: > On Thu, 17 Oct 2024 02:10:31 +0200 > Stefano Brivio wrote: > >> On Wed, 16 Oct 2024 11:41:34 +1100 >> David Gibson wrote: >> >>> On Tue, Oct 15, 2024 at 09:54:38PM +0200, Stefano Brivio wrote: >>>> [Still partial review] >>> [snip] >>>>> + if (peek_offset_cap) >>>>> + already_sent = 0; >>>>> + >>>>> + iov_vu[0].iov_base = tcp_buf_discard; >>>>> + iov_vu[0].iov_len = already_sent; >>>> >>>> I think I had a similar comment to a previous revision. Now, I haven't >>>> tested this (yet) on a kernel with support for SO_PEEK_OFF on TCP, but >>>> I think this should eventually follow the same logic as the (updated) >>>> tcp_buf_data_from_sock(): we should use tcp_buf_discard only if >>>> (!peek_offset_cap). >>>> >>>> It's fine to always initialise VIRTQUEUE_MAX_SIZE iov_vu items, >>>> starting from 1, for simplicity. But I'm not sure if it's safe to pass a >>>> zero iov_len if (peek_offset_cap). >>> >>>> I'll test that (unless you already did) -- if it works, we can fix this >>>> up later as well. >>> >>> I believe I tested it at some point, and I think we're already using >>> it somewhere. >> >> I tested it again just to be sure on a recent net.git kernel: sometimes >> the first test in passt_vu_in_ns/tcp, "TCP/IPv4: host to guest: big >> transfer" hangs on my setup, sometimes it's the "TCP/IPv4: ns to guest >> (using loopback address): big transfer" test instead. >> >> I can reproduce at least one of the two issues consistently (tests >> stopped 5 times out of 5). >> >> The socat client completes the transfer, the server is still waiting >> for something. I haven't taken captures yet or tried to re-send from >> the client. > > ...Laurent, let me know if I should dig into this any further. > > For reference, the kernel commit introducing SO_PEEK_OFF support for TCP > on IPv6 is be9a4fb831b8 ("tcp: add SO_PEEK_OFF socket option tor > TCPv6"). Without that commit, passt won't set peek_offset_cap. > > It was added in 6.11-rc5, so it's part of kernel-6.11.3-200.fc40 (latest > stable kernel) for Fedora 40. passt will print "SO_PEEK_OFF supported" > if you run it with -d -f. > I have this kernel on my laptop... but I need to reboot. I will dig into this. Thanks, Laurent