From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=mur.at Authentication-Results: passt.top; dkim=pass (3072-bit key; unprotected) header.d=mur.at header.i=@mur.at header.a=rsa-sha256 header.s=dkim2 header.b=V7egp967; dkim-atps=neutral Received: from efeu.mur.at (efeu.mur.at [IPv6:2a02:3e0::42]) by passt.top (Postfix) with ESMTPS id 0EF575A0275 for ; Sat, 19 Sep 2026 14:56:47 +0200 (CEST) Received: from [192.168.4.117] (lan1.raspi.ma39.ffgraz.net [10.12.1.243]) by efeu.mur.at (Postfix) with ESMTPSA id 5679646080; Sat, 19 Sep 2026 14:56:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mur.at; s=dkim2; t=1789822606; bh=eFEAF8xkuUSUE5Ewwu5XP54DsrcyApd7PoFK9L4e4j8=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=V7egp967bfHVsvFOH7hIHUNqpNO+/kznNFYT9ztZKk4jwnvXGzgX7YwgeMJc+JlPQ Ol/bWTJ9CEmOKi9v2HIXfTtYwYgaQl0iK9mi4xE3/bpA25FM3tuUl1FwSpMEvSnhIQ wa0KqcT1rmjEfZT98pdbg3tCrbqmzgIlTUqYOjWPW62/AufkMb2CJPD3H6mAB0XYOQ TMjcrBhufXpQa3xKCOr7WQfBDes0FSWSFetLslT0b1tA+pjmVWPvcw2vmLZrt8fyNy yt5UFKIDblmzWD1q57H3LFf/Ioo2xWwwLoVvWrFinVvfzXKAQPlld3r5NKcDivjljH UuW0tX7nzWfCHOJCVVlMkiyhO8d62ZNUBkOJnGZsSh+22d8CNTR6WVixUAWX9QVdcw zk3oiRrI84daBr3CLsUQdQaGOKSj7FX/+hgkL2Oguxidj9Hr7uRsAgALJ2sENoGGam 2WPk0e9KDVdcmi35HBJtmSO8F7EpDi3fNkr5aSjMEHcVkhMhVhd Message-ID: Date: Sat, 19 Sep 2026 14:56:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Martin Schitter Subject: Re: [PATCH v2 2/3] Timekeeping: Resolving Route Dependencies To: Stefano Brivio References: <20260908181631.537802-1-ms+git@mur.at> <20260908181631.537802-3-ms+git@mur.at> <20260917210818.4900083a@elisabeth> Content-Language: de-DE, en-US In-Reply-To: <20260917210818.4900083a@elisabeth> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MailFrom: ms+git@mur.at X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: RUYR5MJ6WHJFCF2VE2DLI3MHUU42E722 X-Message-ID-Hash: RUYR5MJ6WHJFCF2VE2DLI3MHUU42E722 X-Mailman-Approved-At: Sun, 20 Sep 2026 11:27:02 +0200 CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 9/17/26 21:08, Stefano Brivio wrote: >> + clock_gettime(CLOCK_MONOTONIC, &now); >> + debug("route dependency handling time: %f s", >> + (now.tv_sec - start.tv_sec) + (now.tv_nsec - start.tv_nsec)/1.0e9); > > And anyway, I'm not sure I see the value of this. Which other functions > should we profile? Does it help at all to do this once you're done > developing it? > > I would suggest to simply drop this patch. I understand you needed that > for development but you already explain in the commit message for 3/3 > how it improves thing, and that's all the documentation we possibly > need for the future, I think. For this reason I placed these profiling related changes in a separate patch. They can be easily ignored. Nevertheless, it's still very important to optimize and profile the actual handling of huge routing tables. The original implementation was really horrible in this regard.