From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=UdHp/Or0; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id E38B15A0265 for ; Wed, 06 May 2026 09:06:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778051170; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BOx9x9LSMyCXz0ZLH4VVh0EgPziKuTXXlXseO2kRNmY=; b=UdHp/Or0DAzO3TMWzTd1JXhW1G5AygcRpPiHu10BLS1rg9ai/6kJYh3iW8NZhHl84fBFCg jc8AMPpEUqFheRkMD+oo3UHyrI6n4ioWe7AG2O4kh4GYRTfdqYZrt4i1vnBhXtIhVQr00d 6980OAtzjeXW96a9TDMtR3UyN/FYh1A= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-302-b5sekEp3M5GeuBGCcJIF3w-1; Wed, 06 May 2026 03:06:09 -0400 X-MC-Unique: b5sekEp3M5GeuBGCcJIF3w-1 X-Mimecast-MFC-AGG-ID: b5sekEp3M5GeuBGCcJIF3w_1778051168 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48919890a95so39642375e9.2 for ; Wed, 06 May 2026 00:06:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778051168; x=1778655968; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BOx9x9LSMyCXz0ZLH4VVh0EgPziKuTXXlXseO2kRNmY=; b=FR56BA//+HMPrXP+Bcbqp4YGYs0CAKg839J2ynQ3WNawXmT8tQ5qOHcwVJ5q980YXB JY8gxG30nWPdTFUQX3Qt+WesM1YM5QrECC5qIZdfWgrikuNPKjpyBHLur/XGQkCdY+K1 j+cJVsXX2+Efqu8serHT+BxGhfjJMKwQ4qbqfjEltG7LQnV17ikONNOV/LWSBmA7ttQe 3FsEm4KEp3AWFS2ijDtMsZ5YOGfbw0UTE3Ge6F5H5thm33ZQZ++7LfRHiQzmK6I8stjQ 3BS/fGZrVpS4OiKbmS5+qvuogO6MnPC8MNyCaimo0sxHcbOxip5tSw3rItTPshxDknPf U5qg== X-Gm-Message-State: AOJu0Ywnb2gp8N5L3SQ23sgVS4Wi4ULEIdcxaj4UYqVP2RfDuyrkHurw f21wTY/LQ9Zg06OCExi4yC31nBzN8m/B1wJpSA+4VcRGFlk4rjn6MumGQMAe5iVpo/wOMb5POJv KMEfklGBOeeexSiFGO5GVV/dBuaWSwsqDSkviYPTacF5doCdKkYnIXg== X-Gm-Gg: AeBDiesdMM0JQkvvv05yyYB/bZO5B5gFNJy77DXMqzkLsOtgqfxTxC3OWs/O6IDS2hQ FVEH31NM0drUXmiAPWTOvJJ/Tzjj2FX54woJ+aHAmrGA+UHz5oNnwaVB5aYmFvV9qh6BdnjlgGR 5KMOhSJeNIYsArAsAn9CJ951F9j5+auEIpQ/kIeez81tSMxTEXZTTpeSo56UCbDSf+iHNVaNswn DnzJxyNyfN2tX0BPWUKQpFBZQmg2r2B7OqHHwke9LNgwxysG5a4L2kLEjQfHj+9DdGWNNO6KNQe zv3xCQ8jXnLy9dVqpoZ+ijKg/A9cNwEh660v5mUsp60gLEAKzzrX7dQonC5mBcPlL3dtCvHSu34 xuJahncXey77apWnQm5whXP19BSCoEHXoMU0SwLG+VYyPOrwwqyBFjOwTD+3oE3sgCA== X-Received: by 2002:a05:600d:18:b0:488:b811:51c4 with SMTP id 5b1f17b1804b1-48e51f3c4f4mr28970575e9.25.1778051168066; Wed, 06 May 2026 00:06:08 -0700 (PDT) X-Received: by 2002:a05:600d:18:b0:488:b811:51c4 with SMTP id 5b1f17b1804b1-48e51f3c4f4mr28970105e9.25.1778051167589; Wed, 06 May 2026 00:06:07 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e539109b7sm22441135e9.15.2026.05.06.00.06.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 00:06:06 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 09:06:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 10/19] pesto, conf: Have pesto connect to passt and check versions To: David Gibson , Stefano Brivio References: <20260505234719.1437340-1-sbrivio@redhat.com> <20260505234719.1437340-11-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: HRFYt18ffJ3J2nd3cw2kexW5rLZpT_p4K-tDoIKEgWo_1778051168 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 3Z4L4XLKS56LYKDSSJGPS42Y4ISZ4BLK X-Message-ID-Hash: 3Z4L4XLKS56LYKDSSJGPS42Y4ISZ4BLK X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/6/26 07:38, David Gibson wrote: > On Wed, May 06, 2026 at 01:47:10AM +0200, Stefano Brivio wrote: >> From: David Gibson >> >> Start implementing pesto in earnest. Create a control/configuration >> socket in passt. Have pesto connect to it and retrieve a server greeting >> Perform some basic version checking. >> >> Signed-off-by: David Gibson >> [sbrivio: Avoid potential recursive calling between conf_accept() and >> conf_close(), reported by clang-tidy] > > Huh. For some reason that warning didn't trip for me. Although it's > technically true they can mutually recurse, I believe they're both > tail calls, so it shouldn't eat the stack. > >> [sbrivio: In conf(), check we're not exceeding sizeof(c->control_path) >> instead of sizeof(c->socket_path), and, in pesto's main(), print >> argv[optind] instead of argv[1] to indicate an invalid socket path, >> both reported by Jon Maloy] >> [sbrivio: In pesto's main(), drop unnecessary newline from error >> message, reported by Laurent] >> [sbrivio: Don't use SOCK_NONBLOCK on accept4(), as that only applies >> to the *new* file descriptor, which we don't want -- set O_NONBLOCK >> on the listening file descriptor using fcntl()] > > Making the new (accepted) socket non-blocking was the intended > behaviour here. We also want non-blocking for the listening socket, > but that was already done in feab892c7 ("tap, repair: Use > SOCK_NONBLOCK and SOCK_CLOEXEC on Unix sockets"). This patch has been dropped since v6 of the series. Thanks, Laurent