From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hZXoGNo5; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id C72105A004C for ; Thu, 05 Sep 2024 11:58:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725530315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0lurpYjiE5DKYB6la8FNPhD75uyRpfUsv872Lyl7NAM=; b=hZXoGNo5rwofN6kUV2Y/sjZDi6l6gxr9Xp6pG2x4Y6d0SXNaV/Hq4f6kC+swzdufOmYuVX /lXrzvGoJhkmIfSrDkUiRyxNrkmSASUqsR96XgrLMd7+D6SDRNOwkVW9uNNYb72J4X84ql xNDYJn0/JrXb19LusFBdKuF2rZWJCQY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-602-W_nZO3FlOAuSbPGiDoxIBg-1; Thu, 05 Sep 2024 05:58:34 -0400 X-MC-Unique: W_nZO3FlOAuSbPGiDoxIBg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42c7aa6c13cso4842105e9.1 for ; Thu, 05 Sep 2024 02:58:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725530313; x=1726135113; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0lurpYjiE5DKYB6la8FNPhD75uyRpfUsv872Lyl7NAM=; b=gC4DD26GA/l/279b1PNkrQj8sUSZBVTJuoLUiu+tBj2Y1JwcP5R+PkLPkKHyUdDGKz a7wxKjvO6wCyqrPUgVxlXxyV3xqq9LXLTCPgcz2RjwTxOkqAAC7wU3djLas4CtchryjN vDutxQtLDw8ahzg5ol607X2HEkaOK3106s8p2YDs6EaabIh5lJwyGkqAbeNpLifmlgLQ 44DfNfStZQ7fWr0OP46j0+ExBhB+R9/vyJsRTVfXkkZPGDj/S6Ov8gNl3TK15D8TMUIK Url2s66frzKtOsVETt+fNOBkHGXku1Oceawe2g2DXCollNUBHpx2mNgtaOi5Jug1Q6iH owsg== X-Gm-Message-State: AOJu0YxptnfLSidWWMl1nij1/ElvQZFRrQ+oQ6kNPMgy4BthIM/QXAQh DOQ/qJcmHyB9HPLPIn/k72ron94HfluvjufmihNDhGF0novoUKSUp8vb6w8wDAz6f8Xf4LHGrm1 IfKddbTczSjXZKoyUP0pdfc5ZGtj1N+JQKnFPDP0KYfJ+iwoCKi8xPMSGmw== X-Received: by 2002:a05:600c:3b9f:b0:426:6e8b:3dc5 with SMTP id 5b1f17b1804b1-42bbb440c8bmr160410655e9.32.1725530312952; Thu, 05 Sep 2024 02:58:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHE7y21SwLC1ug0wzJhehcAA6FOzoOspkjel0YJLCbDXZWDWlQhmB8SbcDob1AlDXG2QT/aSA== X-Received: by 2002:a05:600c:3b9f:b0:426:6e8b:3dc5 with SMTP id 5b1f17b1804b1-42bbb440c8bmr160410285e9.32.1725530311741; Thu, 05 Sep 2024 02:58:31 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-374caf10f37sm10277862f8f.28.2024.09.05.02.58.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Sep 2024 02:58:31 -0700 (PDT) Message-ID: Date: Thu, 5 Sep 2024 11:58:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/4] vhost-user: introduce vhost-user API To: David Gibson References: <20240815155024.827956-1-lvivier@redhat.com> <20240815155024.827956-4-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: B3DXSCKPI7ILZZHML3MEUWPZJQ2MRBD4 X-Message-ID-Hash: B3DXSCKPI7ILZZHML3MEUWPZJQ2MRBD4 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 26/08/2024 07:26, David Gibson wrote: >> +/** >> + * vu_set_features_exec() - Enable features of the back-end >> + * @vdev: Vhost-user device >> + * @vmsg: Vhost-user message >> + * >> + * Return: false as no reply is requested >> + */ >> +static bool vu_set_features_exec(struct vu_dev *vdev, >> + struct vhost_user_msg *msg) >> +{ >> + debug("u64: 0x%016"PRIx64, msg->payload.u64); > A number of these debug() messages look like they'd be pretty cryptic, > with no indication of which part of passt they're coming from. This > one is especially bad. We have in the main loop calling each vu_ function a trace: debug("================ Vhost user message ================"); debug("Request: %s (%d)", vu_request_to_string(msg.hdr.request), msg.hdr.request); debug("Flags: 0x%x", msg.hdr.flags); debug("Size: %u", msg.hdr.size); That will give: 33.1458: passt: epoll event on vhost-user command socket 73 (events: 0x00000001) 33.1458: ================ Vhost user message ================ 33.1458: Request: VHOST_USER_SET_FEATURES (2) 33.1458: Flags: 0x1 33.1458: Size: 8 33.1458: u64: 0x0000000140008000 I think this provides enough context to understand the trace. Thanks, Laurent