Re: [PATCH 1/2] tcp: add SO_PEEK_OFF socket option tor TCPv6

[Jon Maloy <jmaloy@redhat.com>]

On 2024-08-23 19:51, Jason Xing wrote:
> On Sat, Aug 24, 2024 at 5:19 AM <jmaloy@redhat.com> wrote:
>> From: Jon Maloy <jmaloy@redhat.com>
>>
>> When we added the SO_PEEK_OFF socket option to TCP we forgot
>> to add it even for TCP on IPv6.
> Even though you said "we forgot", I'm not sure if this patch series
> belongs to net-next material...
I agree regarding the fix.
The selftest is new however, and belongs in net-next because of that.
Since I made it one series I decided for net-next, but I leave it to the 
discretion of Jakub and the maintainer of the linux-kselftest system to 
decide where they go.

///jon

>
>> We do that here.
>>
>> Fixes: 05ea491641d3 ("tcp: add support for SO_PEEK_OFF socket option")
>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>> Reviewed-by: Stefano Brivio <sbrivio@redhat.com>
>> Tested-by: Stefano Brivio <sbrivio@redhat.com>
>> Signed-off-by: Jon Maloy <jmaloy@redhat.com>
> Reviewed-by: Jason Xing <kerneljasonxing@gmail.com>
>
> You seem to forget to carry Eric's Reviewed-by tag, please see the link :)
> https://lore.kernel.org/all/CANn89iJmdGdAN1OZEfoM2LNVOewkYDuPXObRoNWhGyn93P=8OQ@mail.gmail.com/
>
> Thanks,
> Jason
>