public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v2 6/6] test: Add multiqueue support to vhost-user test infrastructure
Date: Thu, 27 Nov 2025 10:20:37 +0100	[thread overview]
Message-ID: <cca29f2d-4ec1-451b-860c-11e159abc61a@redhat.com> (raw)
In-Reply-To: <aSZ30ulJ3YgXlb2c@zatzit>

On 11/26/25 04:45, David Gibson wrote:
>> +
>> +		if [ ${VHOST_USER_MQ} -gt 1 ]; then
>> +			__qemu_netdev="${__qemu_netdev}			       \
>> +			-device virtio-net,netdev=v,mq=true		       \
>> +			-netdev vhost-user,id=v,chardev=c,queues=${VHOST_USER_MQ}"
>> +		else
>> +			__qemu_netdev="${__qemu_netdev}			       \
>> +			-device virtio-net,netdev=v			       \
>> +			-netdev vhost-user,id=v,chardev=c"
> Is there a diffence for qemu between omitting queues= and using
> queues=1?  If not we can simplify this.  For the passt option it's
> worth explicitly not-setting it for the single-queue case, so that
> we're exercising the command line option as well.  But exercising
> qemu's options is not our concern, so we can use queues=1 if it means
> the same thing as omitting it entirely.

I think the important parameter here is mq=true that will set or not the feature. This 
exercise the interface between QEMU and passt. I will try to see if we can set queues 
unconditionally (with 1 or more).

Thanks,
Laurent


  reply	other threads:[~2025-11-27  9:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-21 16:58 [PATCH v2 0/6] vhost-user: Add multiqueue support Laurent Vivier
2025-11-21 16:58 ` [PATCH v2 1/6] tap: Remove pool parameter from tap4_handler() and tap6_handler() Laurent Vivier
2025-11-21 16:58 ` [PATCH v2 2/6] vhost-user: Enable multiqueue Laurent Vivier
2025-11-26  2:20   ` David Gibson
2025-11-26  8:04     ` Laurent Vivier
2025-11-21 16:58 ` [PATCH v2 3/6] vhost-user: Add queue pair parameter throughout the network stack Laurent Vivier
2025-11-26  2:35   ` David Gibson
2025-11-21 16:59 ` [PATCH v2 4/6] tap: Add queue pair parameter throughout the packet processing path Laurent Vivier
2025-11-26  3:16   ` David Gibson
2025-11-21 16:59 ` [PATCH v2 5/6] flow: Add queue pair tracking to flow management Laurent Vivier
2025-11-26  3:41   ` David Gibson
2025-11-27  9:17     ` Laurent Vivier
2025-11-28  0:53       ` David Gibson
2025-11-21 16:59 ` [PATCH v2 6/6] test: Add multiqueue support to vhost-user test infrastructure Laurent Vivier
2025-11-26  3:45   ` David Gibson
2025-11-27  9:20     ` Laurent Vivier [this message]
2025-11-28  0:54       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cca29f2d-4ec1-451b-860c-11e159abc61a@redhat.com \
    --to=lvivier@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).