public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
blob ccd98ff3aa360911986dc47826cb47485ce454bf 7692 bytes (raw)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
 
// SPDX-License-Identifier: GPL-2.0-or-later

/* PASST - Plug A Simple Socket Transport
 *  for qemu/UNIX domain socket mode
 *
 * PASTA - Pack A Subtle Tap Abstraction
 *  for network namespace/tap device mode
 *
 * packet.c - Packet abstraction: add packets to pool, flush, get packet data
 *
 * Copyright (c) 2020-2021 Red Hat GmbH
 * Author: Stefano Brivio <sbrivio@redhat.com>
 */

#include <limits.h>
#include <stddef.h>
#include <stdint.h>

#include <netinet/ip6.h>

#include "packet.h"
#include "util.h"
#include "log.h"

/**
 * packet_check_range() - Check if a memory range is valid for a pool
 * @p:		Packet pool
 * @ptr:	Start of desired data range
 * @len:	Length of desired data range
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 *
 * Return: 0 if the range is valid, -1 otherwise
 */
static int packet_check_range(const struct pool *p, const char *ptr, size_t len,
			      const char *func, int line)
{
	if (len > PACKET_MAX_LEN) {
		debug("packet range length %zu (max %zu), %s:%i",
		      len, PACKET_MAX_LEN, func, line);
		return -1;
	}

	if (p->memory) {
		int ret;

		ret = vu_packet_check_range(p->memory, ptr, len);

		if (ret == -1)
			debug("cannot find region, %s:%i", func, line);

		return ret;
	}

	if (ptr < p->buf) {
		debug("packet range start %p before buffer start %p, %s:%i",
		      (void *)ptr, (void *)p->buf, func, line);
		return -1;
	}

	if (len > p->buf_size) {
		debug("packet range length %zu larger than buffer %zu, %s:%i",
		      len, p->buf_size, func, line);
		return -1;
	}

	if ((size_t)(ptr - p->buf) > p->buf_size - len) {
		debug("packet range %p, len %zu after buffer end %p, %s:%i",
		      (void *)ptr, len, (void *)(p->buf + p->buf_size),
		      func, line);
		return -1;
	}

	return 0;
}
/**
 * pool_full() - Is a packet pool full?
 * @p:		Pointer to packet pool
 *
 * Return: true if the pool is full, false if more packets can be added
 */
bool pool_full(const struct pool *p)
{
	return p->count >= p->size;
}

/**
 * packet_iov_max_cnt() - Return the maximum number of iovec we can store
 * @p:		Pointer to packet pool
 *
 * Return: the maximum number of iovec we can store in the memory of
 *         the pool buffer
 */
static size_t packet_iov_max_cnt(const struct pool *p)
{
	return p->buf_size / sizeof(struct iovec);
}

/**
 * packet_iov_idx() - For a given packet index, return the iovec index and
 * 		      the number of iovec entry of the packet
 * @p:		Pointer to packet pool
 * @idx:	Index of packet descriptor in pool
 * @iov_cnt:	Pointer to store the number of the iovec entry of the packet
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 *
 * Return: the iovec index for the given packet index, @iov_cnt is set
 *         to the number of the iovec entry of the packet
 */
static int packet_iov_idx(const struct pool *p, size_t idx, size_t *iov_cnt,
			  const char *func, int line)
{
	size_t iov_idx, max = packet_iov_max_cnt(p);

	iov_idx = (size_t)p->pkt[idx].iov_base;
	*iov_cnt = p->pkt[idx].iov_len;

	ASSERT_WITH_MSG(iov_idx + *iov_cnt <= max,
		       "Corrupt iov entry: (%zu, %zu), max: %zu, %s:%i",
			iov_idx, *iov_cnt, max, func, line);

	return iov_idx;
}

/**
 * packet_iov_next_idx() - Give the the next available iovec index
 * @p:		Pointer to packet pool
 * @idx:	Index of packet descriptor in pool
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 *
 * Return: the next available iovec index
 */
static size_t packet_iov_next_idx(const struct pool *p, size_t idx,
				  const char *func, int line)
{
	size_t iov_idx, iov_cnt;

	if (idx == 0)
		return 0;

	iov_idx = packet_iov_idx(p, idx - 1, &iov_cnt, func, line);

	return iov_idx + iov_cnt;
}

/**
 * packet_iov_data() - For a given packet index, provide the iovec array
 * @p:		Pointer to packet pool
 * @idx:	Index of packet descriptor in pool
 * @data:	iov_tail to store iovec array and count
 * 		(offset is always set to 0)
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 */
static void packet_iov_data(const struct pool *p, size_t idx,
			    struct iov_tail *data,
			    const char *func, int line)
{
	struct iovec *iov = (struct iovec *)p->buf;
	size_t iov_idx, iov_cnt;

	iov_idx = packet_iov_idx(p, idx, &iov_cnt, func, line);

	data->iov = &iov[iov_idx];
	data->cnt = iov_cnt;
	data->off = 0;
}

/**
 * packet_iov_check_range() - Check if iovec array is valid for a pool
 * @p:		Pointer to packet pool
 * @data:	iov_tail that stores the iovec array to check
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 *
 * Return: 0 if the range is valid, -1 otherwise
 */
static int packet_iov_check_range(const struct pool *p,
				  const struct iov_tail *data,
				  const char *func, int line)
{
	size_t offset, i;

	offset = data->off;
	for (i = 0; i < data->cnt; i++) {
		int ret;

		ret = packet_check_range(p,
				(char *)data->iov[i].iov_base + offset,
				data->iov[i].iov_len - offset,
				func, line);
		if (ret)
			return ret;
		offset = 0;
	}

	return 0;
}

/**
 * packet_add_do() - Add data as packet descriptor to given pool
 * @p:		Existing pool
 * @data:	Data to add
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 */
void packet_add_do(struct pool *p, struct iov_tail *data,
		   const char *func, int line)
{
	size_t idx = p->count;
	const char *start;
	size_t len;

	if (pool_full(p)) {
		debug("add packet index %zu to pool with size %zu, %s:%i",
		      idx, p->size, func, line);
		return;
	}

	if (!iov_tail_prune(data))
		return;

	if (packet_iov_check_range(p, data, func, line))
		return;

	if (p->memory) {
		size_t iov_max_cnt = packet_iov_max_cnt(p);
		struct iovec *iov = (struct iovec *)p->buf;
		size_t iov_idx;
		int iov_cnt;

		iov_idx = packet_iov_next_idx(p, idx, func, line);

		iov_cnt = iov_tail_slice(&iov[iov_idx], iov_max_cnt - iov_idx,
					 data, NULL);
		if (iov_cnt < 0) {
			debug("add iov (%zu,%zu) to buf with size %zu, %s:%i",
			      iov_idx, data->cnt, iov_max_cnt, func, line);
			return;
		}

		len = iov_cnt;
		/* NOLINTNEXTLINE(performance-no-int-to-ptr) */
		start = (char *)iov_idx;
	} else {
		len = data->iov[0].iov_len - data->off;
		start = (char *)data->iov[0].iov_base + data->off;
	}
	p->pkt[idx].iov_base = (void *)start;
	p->pkt[idx].iov_len = len;

	p->count++;
}

/**
 * packet_data_do() - Get data range from packet descriptor from given pool
 * @p:		Packet pool
 * @idx:	Index of packet descriptor in pool
 * @data:	IOV tail to store the address of the data (output)
 * @func:	For tracing: name of calling function, NULL means no trace()
 * @line:	For tracing: caller line of function call
 *
 * Return: true if @data contains valid data, false otherwise
 */
bool packet_data_do(const struct pool *p, size_t idx,
		    struct iov_tail *data,
		    const char *func, int line)
{
	ASSERT_WITH_MSG(p->count <= p->size,
			"Corrupt pool count: %zu, size: %zu, %s:%i",
			p->count, p->size, func, line);

	if (idx >= p->count) {
		debug("packet %zu from pool size: %zu, count: %zu, "
		      "%s:%i", idx, p->size, p->count, func, line);
		return false;
	}

	if (p->memory) {
		packet_iov_data(p, idx, data, func, line);
	} else {
		data->cnt = 1;
		data->off = 0;
		data->iov = &p->pkt[idx];
	}

	ASSERT_WITH_MSG(!packet_iov_check_range(p, data, func, line),
			"Corrupt packet pool, %s:%i", func, line);

	return true;
}

/**
 * pool_flush() - Flush a packet pool
 * @p:		Pointer to packet pool
 */
void pool_flush(struct pool *p)
{
	p->count = 0;
}

debug log:

solving ccd98ff3aa36 ...
found ccd98ff3aa36 in https://archives.passt.top/passt-dev/20250417165136.2688884-30-lvivier@redhat.com/
found 0a2ad28d3d25 in https://archives.passt.top/passt-dev/20250416152605.3947623-29-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250417165136.2688884-29-lvivier@redhat.com/
found 53ede9fcb509 in https://archives.passt.top/passt-dev/20250417165136.2688884-21-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250416152605.3947623-21-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250415094300.65794-21-lvivier@redhat.com/
found 7489010e02eb in https://archives.passt.top/passt-dev/20250417165136.2688884-19-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250416152605.3947623-19-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250415094300.65794-19-lvivier@redhat.com/
found b6de869db176 in https://archives.passt.top/passt-dev/20250417165136.2688884-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250416152605.3947623-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250415094300.65794-8-lvivier@redhat.com/
found 675bccf4d787 in https://archives.passt.top/passt-dev/20250417165136.2688884-7-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250416152605.3947623-7-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250415094300.65794-7-lvivier@redhat.com/
found 98ded4e27aae in https://archives.passt.top/passt-dev/20250417165136.2688884-6-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250416152605.3947623-6-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250415094300.65794-6-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20250411131031.1398006-6-lvivier@redhat.com/
found 72c61580be1e in https://passt.top/passt
preparing index
index prepared:
100644 72c61580be1e532c1399b32b9bec9006ef67cf63	packet.c

applying [1/7] https://archives.passt.top/passt-dev/20250417165136.2688884-6-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 72c61580be1e..98ded4e27aae 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250416152605.3947623-6-lvivier@redhat.com/ for 98ded4e27aae
skipping https://archives.passt.top/passt-dev/20250415094300.65794-6-lvivier@redhat.com/ for 98ded4e27aae
skipping https://archives.passt.top/passt-dev/20250411131031.1398006-6-lvivier@redhat.com/ for 98ded4e27aae
index at:
100644 98ded4e27aaeffc39f5ad1a55e8d9368f1e8d9ba	packet.c

applying [2/7] https://archives.passt.top/passt-dev/20250417165136.2688884-7-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 98ded4e27aae..675bccf4d787 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250416152605.3947623-7-lvivier@redhat.com/ for 675bccf4d787
skipping https://archives.passt.top/passt-dev/20250415094300.65794-7-lvivier@redhat.com/ for 675bccf4d787
index at:
100644 675bccf4d7878be9415fb1676fd589712b0b5d48	packet.c

applying [3/7] https://archives.passt.top/passt-dev/20250417165136.2688884-8-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 675bccf4d787..b6de869db176 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250416152605.3947623-8-lvivier@redhat.com/ for b6de869db176
skipping https://archives.passt.top/passt-dev/20250415094300.65794-8-lvivier@redhat.com/ for b6de869db176
index at:
100644 b6de869db1765f8b85d65260246bb0eb1e883372	packet.c

applying [4/7] https://archives.passt.top/passt-dev/20250417165136.2688884-19-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index b6de869db176..7489010e02eb 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250416152605.3947623-19-lvivier@redhat.com/ for 7489010e02eb
skipping https://archives.passt.top/passt-dev/20250415094300.65794-19-lvivier@redhat.com/ for 7489010e02eb
index at:
100644 7489010e02eb3f633c52b8687835c2977a78f787	packet.c

applying [5/7] https://archives.passt.top/passt-dev/20250417165136.2688884-21-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 7489010e02eb..53ede9fcb509 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250416152605.3947623-21-lvivier@redhat.com/ for 53ede9fcb509
skipping https://archives.passt.top/passt-dev/20250415094300.65794-21-lvivier@redhat.com/ for 53ede9fcb509
index at:
100644 53ede9fcb50945049ad2d027583d6b1ce5eb707b	packet.c

applying [6/7] https://archives.passt.top/passt-dev/20250416152605.3947623-29-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 53ede9fcb509..0a2ad28d3d25 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20250417165136.2688884-29-lvivier@redhat.com/ for 0a2ad28d3d25
index at:
100644 0a2ad28d3d25b6897216eb077c9a141097a8fe8d	packet.c

applying [7/7] https://archives.passt.top/passt-dev/20250417165136.2688884-30-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index 0a2ad28d3d25..ccd98ff3aa36 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

index at:
100644 ccd98ff3aa360911986dc47826cb47485ce454bf	packet.c

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).