From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 2E9505A0265 for ; Tue, 10 Nov 2026 10:47:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1794304056; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nSrsRFnomsIQMKp23t5qrvSIr1tGqiTPfUx2kD8k3cc=; b=jNqdoSiw3apBaIdw4FWMJK2gnbMHaOntoLeZK8p6JVm6TSvNk9o/cCQXs3VhxVlBOPNTDg ixHwpowI2K9nI5V6NrMMIyr9zUBAmFgE3hZXevVgQw3yuv6b3T3GDqFGXc0zAgY2/q9LlF H1/mdKrZXsDKxcZqgZ+xKrqXLA/DU2Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-7P8vxRzDPeGRET3Pfmi3oQ-1; Tue, 10 Nov 2026 04:47:34 -0500 X-MC-Unique: 7P8vxRzDPeGRET3Pfmi3oQ-1 X-Mimecast-MFC-AGG-ID: 7P8vxRzDPeGRET3Pfmi3oQ_1794304053 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4a318cd95e8so14510755e9.0 for ; Tue, 10 Nov 2026 01:47:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794304053; x=1794908853; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=nSrsRFnomsIQMKp23t5qrvSIr1tGqiTPfUx2kD8k3cc=; b=DcztPWAf6i2MBPt6EF7qY1PyowyxZzb4cfmuERGAMvFT/I54bxWIVT+HUXlsAKpP2F TtS5tsrvDwp2eLYiZfHDE6DwJyVHi6fQhkYQpZHUa3xOLkEKnx32jORJxnJF/wkikEaF n10CjEHLvt1imyLF7jPOo/XgBLVoLyNyHSOFrtwtwxdBP5gB4y+oj3RvZ7AcqXMP/Gfy wcwbTvKI5lR0bJkfOr3J6cDDbK2hNqfcDd/Np01RA4MaZeP1QH2DJVFoJcFH+/lLufBJ PPJu5oTjSlGFm/xy73JDS5v6u6YxHvmo1kjsL0ZTaMfv44ZEozNmDAAXBcqXAS3Agtf6 ewaw== X-Forwarded-Encrypted: i=1; AL+hErEOg+iaSilhNykX5IYpD99FKLdA4aIllfNJEPJgehdQjqZxS+4SHzZ38n3pD1EgUCeX760Z2yEuk7w=@passt.top X-Gm-Message-State: APuU4Z/yig+ibgdSC17vd13f4pPJVjvzYJNyk6PDY44Ib45DYFHuy4zQ aYDH/3WD2JXPnRsAioMpD/g0i1PfFLCMl/hAp2jVI72zb7MREi4/KtN1qJh7/bgONC/eRoYvDhQ fodirKgHnR490+uRMMh5094o5tbTnk12wo3Es09O9Qm1mKjPO1SlfAQ== X-Gm-Gg: AYBFou3bkCa3259kPhfxYv6UhMfQIJyBr409NW9/na51oJjI9mSwye00dVI+Hjtu/cx 2CJ0K9ohs9lCTeyeHOrD4U7kIQAKDv4xh5gmBNCGjYYCcp9Apfv/RPhiXRis0Sa5v1N8fGK2X3T QiW41rWAFgDsPtSb9Y4gmV7vPUqP8cNEgYwMjuvZd8qzsW9jLHrsZJ7JzjINzAvjmB2kN12a+ma PTrv4uvze7CYYpjZRgdtQm/kTvv2Pk6rm2CRezfB9Dpqau843TC/W8tIjKUUQ+/laHU0ec1aMr7 QZKzxRDVSoaoTGD0rm0iMkJOP9ecujXnMzfxqV4IOWCr5eZo6XP6ACR3hpTxot7zVVK6KVuqRF+ EEdVpdMpizuiKh/UA4hxo3vsL/dyKWpHOdURZG7zB3HUlzS3avL3jmHs2rwdpMbq18pnccAcPO3 0N1yCzTZVvYkAH+3T9 X-Received: by 2002:a05:600c:5249:b0:4a1:88df:8a2a with SMTP id 5b1f17b1804b1-4ba0234d88amr34466935e9.13.1794304053419; Tue, 10 Nov 2026 01:47:33 -0800 (PST) X-Received: by 2002:a05:600c:5249:b0:4a1:88df:8a2a with SMTP id 5b1f17b1804b1-4ba0234d88amr34466495e9.13.1794304053002; Tue, 10 Nov 2026 01:47:33 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b? ([2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4ba02005946sm59321105e9.1.2026.11.10.01.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2026 01:47:32 -0800 (PST) Message-ID: Date: Tue, 10 Nov 2026 10:47:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tcp_vu: Fix assert/error-check order in tcp_vu_sock_recv() To: Stefano Brivio , Jon Maloy References: <20261109221342.380271-1-jmaloy@redhat.com> <20261110102925.1fbb87ff@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20261110102925.1fbb87ff@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2CbM0fjax5ERs5CeDFFdGTyItwTlGe2VhBX8P37bnVU_1794304053 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: VO73H3D3EZPSM2YXXSKMQXMROFDUO575 X-Message-ID-Hash: VO73H3D3EZPSM2YXXSKMQXMROFDUO575 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: david@gibson.dropbear.id.au, passt-dev@passt.top, contact@jbartunek.de X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/10/26 10:29, Stefano Brivio wrote: > [Cc: Johannes, Laurent] > > Thanks for the patch and the explanation, but shouldn't this be: > > On Mon, 9 Nov 2026 17:13:42 -0500 > Jon Maloy wrote: > > From: Johannes Bartunek > > and: > >> iov_tail_clone() returns a ssize_t. However, the assert comparing >> it against (ARRAY_SIZE(iov_msg) - j), which yields size_t, comes >> before the negative-value check. Hence, when iov_tail_clone() fails >> and returns -1, the signed-to-unsigned promotion turns -1 into >> SIZE_MAX, and causes the assert to fire. >> >> We fix this by moving the error check before the assert, while casting >> the counter and the index inside the assert to size_t. > > Reported-by: Johannes Bartunek > Suggested-by: Laurent Vivier Not exactly... > > ? > >> Signed-off-by: Jon Maloy >> --- >> tcp_vu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tcp_vu.c b/tcp_vu.c >> index 868a35b9..c052d8e2 100644 >> --- a/tcp_vu.c >> +++ b/tcp_vu.c >> @@ -291,9 +291,9 @@ static ssize_t tcp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, >> >> cnt = iov_tail_clone(&iov_msg[j], ARRAY_SIZE(iov_msg) - j, >> &data); >> - assert(cnt < ARRAY_SIZE(iov_msg) - j); >> if (cnt < 0) >> die("Missing entries in iov_msg"); >> + assert((size_t)cnt < ARRAY_SIZE(iov_msg) - (size_t)j); The real fix is: assert((size_t)cnt <= ARRAY_SIZE(iov_msg) - (size_t)j); >> >> j += cnt; >> } > Thanks, Laurent