From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=QfqOJ2ES; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 826825A0271 for ; Thu, 08 Jan 2026 11:51:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1767869469; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k/fZyLDpIMfQ8N5Rm9MoWq3hYsG/NzL9k3rx9Zduuo0=; b=QfqOJ2ESu+shVE4uRNZnZwOQK0cqs+RPXQUJiNxUdiYC/bjxqgi5/cy7Xdorocl9PEyLOd jQFRWnVM8faifQbxK2NCNBY39IXxRgySCBvBV/ir5i0/mvOknkiHRqRKiD3MY8GoRSwmLT jxEbo4Go7RwEW+UhOqXVFabqJ//ByMs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-FDtHzqkMPwKpnUqZg25rzA-1; Thu, 08 Jan 2026 05:51:07 -0500 X-MC-Unique: FDtHzqkMPwKpnUqZg25rzA-1 X-Mimecast-MFC-AGG-ID: FDtHzqkMPwKpnUqZg25rzA_1767869467 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-430fc83f58dso1671413f8f.2 for ; Thu, 08 Jan 2026 02:51:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767869466; x=1768474266; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=k/fZyLDpIMfQ8N5Rm9MoWq3hYsG/NzL9k3rx9Zduuo0=; b=qHB0FBcGS/s/IY1/N4brQWQREQ+RQKe6577aGA1qRFc7lk49Jjmta3cZTqz/GeHjuy FE35kVG9kBOOlgRlyqn5YMpYTsUvFX2Kc8+LwjB+L8axmh03xJtLwD5BuVK2BzWkSNN0 30cHc+nnpJuFEzC8jllw781JMBS7E3VZYOH5QTPYnF8O7lBkt+6XOv5fDfR+G4CWhfNJ HYLdDvaS4l1KWzOMi33bZ+OVkWEd+B2LE4BzbvEWvib6c3+qR98tFuSql2vIveq8ZsXz 6uUwIDFjtOgNOox0QdABK0TD83IexToAAvjlvxYrrGT5BZtKAWxb8TdEcTnJpLdnPzia Ra7A== X-Forwarded-Encrypted: i=1; AJvYcCXV1vCXMv9O3Px39O7oNzmIt5LLSuDFMxgaOulobwrRFWkWkb9h/PYUJi4HXvSj/NTsX9WH8ba8EUU=@passt.top X-Gm-Message-State: AOJu0YzE7+BlQ6NJP7weD1WhF5HpDWQKz8VJ7UMhuIDBfR3C9NM5hY8C iRnNQAtPv8lyGnZs61FsKPdczkW4WXFW7wsxJ0E5jwVDwIReo9yat6wz8C1PFY1ZOtfRAK3g6EX rH4gL/qHs5HUzN5I9ifVryCEVEbZ7ySwmxiUpmgj7nXIpR/sqXLq/zfS72+Oe2w== X-Gm-Gg: AY/fxX4S/R+LY0tuEmxtkMRz/spaXXNE1mO3nTQUPpyXD2INqLVfHdjTkG7F9sJJyYX X+ekd8WflTUJfMYydI8/ehFXMNGdQ/XCzH2rPbnKqBMGornrv5BQebIDwl3HtvqirdN+T1kELof QcxRMkCdaPNp92kRbDGHPSuEN9RWXK8RFWfFekXc+jrOPIAE7RGpv4b/Z5yGddJXmKOQfcFLDdK DTEeS1guxjOv8tGKsm7elaU/rWop+7+1V7EHfBZexvRfBHyAbYPQVafgGkHOwvBifAlZWDWjbwc jBHDZEqHDjvoC1UQ3EC/4MZe6Z9UhgLC1Ux+lqInIqhrt3DDTKBSoIplCruc4qyn4mTyohNNjP7 QLvGbPHC2UiKcz6QfBZuOaWssX4KSMMGPufSPNTBVTksbF5HC X-Received: by 2002:a05:6000:2311:b0:432:aa61:a06e with SMTP id ffacd0b85a97d-432c374fc59mr7586224f8f.32.1767869466506; Thu, 08 Jan 2026 02:51:06 -0800 (PST) X-Google-Smtp-Source: AGHT+IEVjnLZvxiu4kz/PVdX4ITTr8XYpW2HUcaZqnRoZKv+zoriJwItAendhL0t5FG5drYLMCnawQ== X-Received: by 2002:a05:6000:2311:b0:432:aa61:a06e with SMTP id ffacd0b85a97d-432c374fc59mr7586190f8f.32.1767869466050; Thu, 08 Jan 2026 02:51:06 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0dade5sm15915586f8f.9.2026.01.08.02.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Jan 2026 02:51:05 -0800 (PST) Message-ID: Date: Thu, 8 Jan 2026 11:51:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] tcp: Remove unused tcp_epoll_ref To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260108021450.2650004-1-david@gibson.dropbear.id.au> <20260108021450.2650004-2-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260108021450.2650004-2-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: uEmy9bKBfFtBeOanSSUjfPXZfUTetWS2yN002CgPJz8_1767869467 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 7DMTBB4YLABWW7URD26XWRWMIE5H3LEJ X-Message-ID-Hash: 7DMTBB4YLABWW7URD26XWRWMIE5H3LEJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 1/8/26 03:14, David Gibson wrote: > This union has been unused for some time. Remove it. > > Signed-off-by: David Gibson > --- > tcp.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/tcp.h b/tcp.h > index 9dd88762..516dfef5 100644 > --- a/tcp.h > +++ b/tcp.h > @@ -30,16 +30,6 @@ void tcp_update_l2_buf(const unsigned char *eth_d); > > extern bool peek_offset_cap; > > -/** > - * union tcp_epoll_ref - epoll reference portion for TCP connections > - * @index: Index of connection in table > - * @u32: Opaque u32 value of reference > - */ > -union tcp_epoll_ref { > - uint32_t index:20; > - uint32_t u32; > -}; > - > /** > * union tcp_listen_epoll_ref - epoll reference portion for TCP listening > * @port: Bound port number of the socket Reviewed-by: Laurent Vivier