public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Max Chernoff <git@maxchernoff.ca>
To: Stefano Brivio <sbrivio@redhat.com>
Cc: Danish Prakash <contact@danishpraka.sh>,
	passt-dev@passt.top, pholzing@redhat.com
Subject: Re: [PATCH v2] contrib/selinux: use regex instead of SELinux template
Date: Thu, 06 Nov 2025 05:09:35 -0700	[thread overview]
Message-ID: <d25970aaa804dfb1a200d9194d9bc6fe4078c76c.camel@maxchernoff.ca> (raw)
In-Reply-To: <20251105163137.424a6537@elisabeth>

Hi Stefano,

On Wed, 2025-11-05 at 16:31 +0100, Stefano Brivio wrote:
> On Wed, 05 Nov 2025 03:28:22 -0700
> Max Chernoff <git@maxchernoff.ca> wrote:
> > On Tue, 2025-11-04 at 22:13 +0100, Stefano Brivio wrote:
> > > Max, thanks for testing and reviewing, I took the liberty to translate
> > > your comments into Tested-by: and Reviewed-by: tags as they clearly
> > > seemed to indicate that.
> >
> > Ah, thanks for that! I'm still fairly new to the patch-on-a-mailing-list
> > workflow, so is there something that I should have done differently?
>
> We use pretty much the same tags as the Linux kernel does:
>
>   https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
>
> [...]
>
> So, here, you could have simply replied with:
>
>     Reviewed-by: Max Chernoff <git@maxchernoff.ca>
>     Tested-by: Max Chernoff <git@maxchernoff.ca>
>
> to unequivocally state what you did with that submission.

Thanks for the pointer! I'll make sure to remember that for next time.

Thanks,
-- Max

      reply	other threads:[~2025-11-06 12:09 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  7:40 [PATCH] contrib/selinux: use regex instead of non-standard bash macro Danish Prakash
2025-10-16  8:21 ` Stefano Brivio
2025-10-16 10:56   ` Max Chernoff
2025-10-27  8:49     ` Danish Prakash
2025-10-27  9:07       ` Stefano Brivio
2025-10-27  9:41         ` Max Chernoff
2025-10-28  6:28         ` Danish Prakash
2025-10-28 23:17           ` Stefano Brivio
2025-10-30  8:20             ` [PATCH v2] contrib/selinux: use regex instead of SELinux template Danish Prakash
2025-10-30  8:37             ` [PATCH] contrib/selinux: use regex instead of non-standard bash macro Danish Prakash
2025-10-30  8:43               ` Stefano Brivio
2025-10-30 10:06                 ` Stefano Brivio
2025-10-30 10:50                   ` Danish Prakash
2025-10-30 10:49             ` [PATCH v2] contrib/selinux: use regex instead of SELinux template Danish Prakash
2025-11-04  6:48               ` Max Chernoff
2025-11-04 21:13               ` Stefano Brivio
2025-11-05 10:28                 ` Max Chernoff
2025-11-05 15:31                   ` Stefano Brivio
2025-11-06 12:09                     ` Max Chernoff [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d25970aaa804dfb1a200d9194d9bc6fe4078c76c.camel@maxchernoff.ca \
    --to=git@maxchernoff.ca \
    --cc=contact@danishpraka.sh \
    --cc=passt-dev@passt.top \
    --cc=pholzing@redhat.com \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).