From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=maxchernoff.ca Authentication-Results: passt.top; dkim=pass (2048-bit key; secure) header.d=maxchernoff.ca header.i=@maxchernoff.ca header.a=rsa-sha256 header.s=key1 header.b=u4bpBNK1; dkim-atps=neutral Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) by passt.top (Postfix) with ESMTPS id 5997E5A026F for ; Thu, 06 Nov 2025 13:09:39 +0100 (CET) Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=maxchernoff.ca; s=key1; t=1762430979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y+exdhG3GYupZ9l3NtMIYtYMP/tFR8PnH4GaXuzPCl8=; b=u4bpBNK1vyk1qB+1bjz+bOKfscC9XZhvaVRy24rXkJBjU/TbZgnfTvunmwXWn4RbMR2QFw ZyAyCZCxDo+LS2+Eo+fwGGfWyWNsBSlcqGKJaBRI5W5kvE1fuWcRnxkr1xkWNNuDZ4BcH8 hd1IY4VUWhNHqDOd4vGLtLJE0R1KhNIc9JtFwMkxLpeHGvjPsA0C8cg3EyM9gt5IGYoXpi K4W7ajKQjxYid+qAIrqKyoA/Fe5lQd7kUcqsgab38SxMLiEJDnJJdRvy/aF04JwmEhUJE3 MGTEBfObBQEr8eaLpegNtgdLWCrZGNvLMROkYSnBK8nA1cZPxGfZVhIfRXy0RA== Subject: Re: [PATCH v2] contrib/selinux: use regex instead of SELinux template X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Max Chernoff To: Stefano Brivio Date: Thu, 06 Nov 2025 05:09:35 -0700 In-Reply-To: <20251105163137.424a6537@elisabeth> References: <20251029001704.43f73a42@elisabeth> <20251030104925.529411-1-contact@danishpraka.sh> <20251104221344.5ba5355d@elisabeth> <20251105163137.424a6537@elisabeth> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-MailFrom: git@maxchernoff.ca X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation Message-ID-Hash: ZIIZQ2S5ANYD6LSIUZ6DYC374CO4LYSU X-Message-ID-Hash: ZIIZQ2S5ANYD6LSIUZ6DYC374CO4LYSU X-Mailman-Approved-At: Thu, 06 Nov 2025 13:17:02 +0100 CC: Danish Prakash , passt-dev@passt.top, pholzing@redhat.com X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Stefano, On Wed, 2025-11-05 at 16:31 +0100, Stefano Brivio wrote: > On Wed, 05 Nov 2025 03:28:22 -0700 > Max Chernoff wrote: > > On Tue, 2025-11-04 at 22:13 +0100, Stefano Brivio wrote: > > > Max, thanks for testing and reviewing, I took the liberty to translat= e > > > your comments into Tested-by: and Reviewed-by: tags as they clearly > > > seemed to indicate that. > > > > Ah, thanks for that! I'm still fairly new to the patch-on-a-mailing-lis= t > > workflow, so is there something that I should have done differently? > > We use pretty much the same tags as the Linux kernel does: > > https://docs.kernel.org/process/submitting-patches.html#using-reported-= by-tested-by-reviewed-by-suggested-by-and-fixes > > [...] > > So, here, you could have simply replied with: > > Reviewed-by: Max Chernoff > Tested-by: Max Chernoff > > to unequivocally state what you did with that submission. Thanks for the pointer! I'll make sure to remember that for next time. Thanks, -- Max