From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=none (p=none dis=none) header.from=jbartunek.de Received: from relay.yourmailgateway.de (relay.yourmailgateway.de [188.68.63.98]) by passt.top (Postfix) with ESMTPS id 7DF3F5A0265 for ; Mon, 09 Nov 2026 21:01:41 +0100 (CET) Received: from mors-relay-2501.netcup.net (localhost [127.0.0.1]) by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4jNgfF2Fpvz6TZB; Mon, 9 Nov 2026 21:01:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=jbartunek.de; s=key2; t=1794254501; bh=MKVOCeN5ew87/Gvk1zmtYmihtSHRwLpcfgaA0RHnKyI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gZd/95cTv8Q0NzJvO5N5f5+NVTWsHtWO6clrqSlEQuKK+4xAKF9TP6MiXRp3pXhHU q1mNSx75BkaUTIl/exnUlbBAyWXDhaaYML22HOj3mnuCbOSOGcvJaNq+TQbwGBtpAz wPNZ75uacGlpj1WDjBEF+lbonXJv9TyLWPOvUKgODXtpht5Gcs20ErqHs5z5IO637v AAgby8pLDrmsKR60a6ukjDZrtKES/hTrJXvY54qOBOJIFLnIPfHzNvx6M9ZPye+tms N5CX5NancaW89GwCb8LKj8upxw2E31QBEi5XnNEv8kNYfbIX07HiMREfPsPHXqaQt/ q0mfaenGz8p2w== Received: from policy02-mors.netcup.net (unknown [46.38.225.35]) by mors-relay-2501.netcup.net (Postfix) with ESMTPS id 4jNgfF1Y8Tz4xrp; Mon, 9 Nov 2026 21:01:41 +0100 (CET) Received: from mxe998.netcup.net (unknown [10.243.12.53]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4jNgfD6SrJz8svY; Mon, 9 Nov 2026 21:01:40 +0100 (CET) Received: from webmail01.netcup.net (unknown [46.38.249.153]) by mxe998.netcup.net (Postfix) with ESMTPSA id 57FBC600B4; Mon, 9 Nov 2026 21:01:32 +0100 (CET) Authentication-Results: mxe998; spf=pass (sender IP is 46.38.249.153) smtp.mailfrom=contact@jbartunek.de smtp.helo=webmail01.netcup.net Received-SPF: pass (mxe998: connection is authenticated) MIME-Version: 1.0 Date: Mon, 09 Nov 2026 20:01:31 +0000 From: contact@jbartunek.de To: Laurent Vivier Subject: Re: passt crashes a) hides error b) assert tripped In-Reply-To: <0667ba95-3ecf-4cb5-837b-6d8f59f13074@redhat.com> References: <497c627fe936ed0f8c5635a2dfed1666@jbartunek.de> <0667ba95-3ecf-4cb5-837b-6d8f59f13074@redhat.com> Message-ID: X-Sender: contact@jbartunek.de Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <179425449250.501363.4142266326134417734@mxe998.netcup.net> X-NC-CID: CpEtO9QOVhRSpaayX5D8dL1XFCFRGOfoMRAkrfDG6Z7Rsz72 Message-ID-Hash: FCTCSO2RGKQGQZTRCNBHVNUDMAN6PXTB X-Message-ID-Hash: FCTCSO2RGKQGQZTRCNBHVNUDMAN6PXTB X-MailFrom: contact@jbartunek.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi Laurent, Thanks for getting back to me so quickly! On 2026-11-09 08:12, Laurent Vivier wrote: > > In fact the assertion should be: > > assert((size_t)cnt <= ARRAY_SIZE(iov_msg) - j); > > Could you try to update it and move it after the "if (cnt < 0) > die("Missing entries in iov_msg");"? Sure I used ``` diff --git a/tcp_vu.c b/tcp_vu.c index 868a35b..cee9cf6 100644 --- a/tcp_vu.c +++ b/tcp_vu.c @@ -291,9 +291,9 @@ static ssize_t tcp_vu_sock_recv(const struct ctx *c, struct vu_virtq *vq, cnt = iov_tail_clone(&iov_msg[j], ARRAY_SIZE(iov_msg) - j, &data); - assert(cnt < ARRAY_SIZE(iov_msg) - j); if (cnt < 0) die("Missing entries in iov_msg"); + assert((size_t)cnt <= ARRAY_SIZE(iov_msg) - (size_t)j); j += cnt; } ``` on top of `2026_10_02.cba3570` (note the additional cast for j). I tried it again with my setup: 0 crashes, it just works (TM), large download all. Thank you so much! All the best, John