public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Paul Holzinger <pholzing@redhat.com>
To: Stefano Brivio <sbrivio@redhat.com>, passt-dev@passt.top
Cc: David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3] treewide: Introduce 'local mode' for disconnected setups
Date: Tue, 26 Nov 2024 14:49:19 +0100	[thread overview]
Message-ID: <d64f570a-c2a2-4298-8d53-78f2fd5188ff@redhat.com> (raw)
In-Reply-To: <20241126055429.1610735-1-sbrivio@redhat.com>


On 26/11/2024 06:54, Stefano Brivio wrote:
> There are setups where no host interface is available or configured
> at all, intentionally or not, temporarily or not, but users expect
> (Podman) containers to run in any case as they did with slirp4netns,
> and we're now getting reports that we broke such setups at a rather
> alarming rate.
>
> To this end, if we don't find any usable host interface, instead of
> exiting:
>
> - for IPv4, use 169.254.2.1 as guest/container address and 169.254.2.2
>    as default gateway
>
> - for IPv6, don't assign any address (forcibly disable DHCPv6), and
>    use the *first* link-local address we observe to represent the
>    guest/container. Advertise fe80::1 as default gateway
>
> - use 'tap0' as default interface name for pasta
>
> Change ifi4 and ifi6 in struct ctx to int and accept a special -1
> value meaning that no host interface was selected, but the IP family
> is enabled. The fact that the kernel uses unsigned int values for
> those is not an issue as 1. one can't create so many interfaces
> anyway and 2. we otherwise handle those values transparently.
>
> Fix a botched conditional in conf_print() to actually skip printing
> DHCPv6 information if DHCPv6 is disabled (and skip printing NDP
> information if NDP is disabled).
>
> Link: https://github.com/containers/podman/issues/24614
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Tested-by: Paul Holzinger <pholzing@redhat.com>

As mentioned on IRC I noticed a problem in Podman with this as we ignore 
link local addresses when adding host entries but that is a Podman bug 
and must be fixed there.


-- 
Paul Holzinger


  reply	other threads:[~2024-11-26 13:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26  5:54 [PATCH v3] treewide: Introduce 'local mode' for disconnected setups Stefano Brivio
2024-11-26 13:49 ` Paul Holzinger [this message]
2024-11-27  1:51 ` David Gibson
2024-11-27  4:27   ` Stefano Brivio
2024-11-27 12:35     ` Paul Holzinger
2024-11-27 12:48       ` Stefano Brivio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d64f570a-c2a2-4298-8d53-78f2fd5188ff@redhat.com \
    --to=pholzing@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    --cc=sbrivio@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).