From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=hxGLVxJD; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E9AFB5A0269 for ; Mon, 11 May 2026 15:31:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778506261; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=b25KBfV+87oXLwnQMXs611KXAmE8cQlD9W6bMV5mUaA=; b=hxGLVxJD3786bGmu5NFCLquq5dmtxwxwNXdmpgEtM0WOwncqu3YM675I/kVQitESxIMgIU 4Kw9ZDi+0Ho+EncN7iSi2Qu911dZuy7ZTnJLcPVd6dL5ZfLQZ9WO+RyHZYuhQn0x3ABD/z WR0vLjyixzVsIZAtRcymjWZe3jgjhBY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-649-mNumBVimNzijoUUPk-fGeg-1; Mon, 11 May 2026 09:30:59 -0400 X-MC-Unique: mNumBVimNzijoUUPk-fGeg-1 X-Mimecast-MFC-AGG-ID: mNumBVimNzijoUUPk-fGeg_1778506258 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48d046fac74so25227415e9.3 for ; Mon, 11 May 2026 06:30:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778506258; x=1779111058; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b25KBfV+87oXLwnQMXs611KXAmE8cQlD9W6bMV5mUaA=; b=hHIGJd3t10zryXC9vWa+H6FfRnnL/AExnrh5cwTC8au+6xbmnHtjL4iinO18tDox8Z rXpDbjAfGwSxfHrlHELO0JdSH0YIuw9UMFkePeCabIAEs+C1HnCbnV/7Y4ruuZc9oX34 lWBII7hHQrLnGbXlsDUEnqj1r5xsTGePf3eQe4kTBXZ8vDewLzzRJuOhiqTLVnWFFX58 FigetgdpfFPS5ODfSx8MWOpBn48gFcs/rg4kSqxXRwmJ4eL0fGwaxD1CtuXVFJqzKuT1 8mzg+G/prOU2QgL1lAGtQBwxLbUyWxccgqoNMEc4cx8Q4eSeRWlH5RTCGRrVW1TOesnS WnJQ== X-Forwarded-Encrypted: i=1; AFNElJ/EEVM1r+5wmt5I8Jy84tvpOosxiCWUlqO2Ew+UmWuVCGrvaoqK0HDqTEtLpWCGIjcsRVlMQAghv5w=@passt.top X-Gm-Message-State: AOJu0YwLo/qRP/yOr10+b1kCDvht8l4qsBsK6n9yt3geoJwqIyx6mtnC 8NGkoTw2KwHyTFGx+FRsQVhOzru9Pmgrh2L/xVDehMYjkX2OCWV3n2kBqW3/F8GPnZ1kmicopuh gn9aNVdcmZHOyTEQBBosFU9Fddlo/oHMDcWlgw8xGOVtUU06Dlgwjvg== X-Gm-Gg: Acq92OFJO/uQ59CcFIdipkfGtVpzNaT5NZIjxy+2hVmTt3vdw0EB2OWuwYqilTEvzq9 4ZNYVhiHIRlHojLblj2g11L88fYjQ0PMBllf4TjD6kR5y9bwmiAzk+iREiLZaj3kSy2O1Qm5UFg Us0GH4voW7nEen3cAoEnL1Af3Dh8U7huhXU2+470LMZxxHRZU17J3wcHUZ7w2IExbL+O05DTVIE umjQuGTfWnk0WtixJyess52mTx8MNO++UjIl83OOwqxELZ8gB6IgnLMs9r17bHy92rIoEe3fSsa tWnvBvlPO5soweTEn7WkfGKHuUDoBojj0E6cYp/HgaWxyM/bUbjW5X47DnExyjScktL6UAi62Kv yUGAt184BAYEO9jtKoo67ansSyiJXift57m5FZdI1evwbYemDeSRa9icPdAXvMjnK6w== X-Received: by 2002:a05:600c:1797:b0:48d:366:b962 with SMTP id 5b1f17b1804b1-48e51e0a8a8mr205595985e9.6.1778506257782; Mon, 11 May 2026 06:30:57 -0700 (PDT) X-Received: by 2002:a05:600c:1797:b0:48d:366:b962 with SMTP id 5b1f17b1804b1-48e51e0a8a8mr205595655e9.6.1778506257198; Mon, 11 May 2026 06:30:57 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-454913049ecsm25087189f8f.19.2026.05.11.06.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 06:30:56 -0700 (PDT) Message-ID: Date: Mon, 11 May 2026 15:30:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/8] treewide: Make some additional variables static To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-8-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-8-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: wnkDE3Llv-o4kWofXxoK75rXPxGkhE0utkVdI7-gRdc_1778506258 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: FSGTCLAGJWWZNI3BVSTEDZDXUB6EZJSR X-Message-ID-Hash: FSGTCLAGJWWZNI3BVSTEDZDXUB6EZJSR X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > Mark a number of extra variables local to a single module as static. > > Signed-off-by: David Gibson Reviewed-by: Laurent Vivier > --- > conf.c | 2 +- > log.c | 2 +- > tcp.c | 6 +++--- > tcp_buf.c | 4 ++-- > 4 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/conf.c b/conf.c > index 8acf66cc..029b9c7c 100644 > --- a/conf.c > +++ b/conf.c > @@ -67,7 +67,7 @@ > {{{ 0xfe, 0x80, 0, 0, 0, 0, 0, 0, \ > 0, 0, 0, 0, 0, 0, 0, 0x01 }}} > > -const char *pasta_default_ifn = "tap0"; > +static const char *pasta_default_ifn = "tap0"; > > /** > * add_dns4() - Possibly add the IPv4 address of a DNS resolver to configuration > diff --git a/log.c b/log.c > index 21e3673e..cbac2efd 100644 > --- a/log.c > +++ b/log.c > @@ -85,7 +85,7 @@ static int logtime_fmt(char *buf, size_t size, const struct timespec *ts) > } > > /* Prefixes for log file messages, indexed by priority */ > -const char *logfile_prefix[] = { > +static const char *logfile_prefix[] = { > NULL, NULL, NULL, /* Unused: LOG_EMERG, LOG_ALERT, LOG_CRIT */ > "ERROR: ", > "WARNING: ", > diff --git a/tcp.c b/tcp.c > index 92d9797a..d6a9ba28 100644 > --- a/tcp.c > +++ b/tcp.c > @@ -370,8 +370,8 @@ enum { > */ > #define TCP_MIGRATE_SND_QUEUE_MAX (64 << 20) > #define TCP_MIGRATE_RCV_QUEUE_MAX (64 << 20) > -uint8_t tcp_migrate_snd_queue [TCP_MIGRATE_SND_QUEUE_MAX]; > -uint8_t tcp_migrate_rcv_queue [TCP_MIGRATE_RCV_QUEUE_MAX]; > +static uint8_t tcp_migrate_snd_queue [TCP_MIGRATE_SND_QUEUE_MAX]; > +static uint8_t tcp_migrate_rcv_queue [TCP_MIGRATE_RCV_QUEUE_MAX]; > > #define TCP_MIGRATE_RESTORE_CHUNK_MIN 1024 /* Try smaller when above this */ > > @@ -420,7 +420,7 @@ char tcp_buf_discard [BUF_DISCARD_SIZE]; > bool peek_offset_cap; > > /* Size of data returned by TCP_INFO getsockopt() */ > -socklen_t tcp_info_size; > +static socklen_t tcp_info_size; > > #define tcp_info_cap(f_) \ > ((offsetof(struct tcp_info_linux, tcpi_##f_) + \ > diff --git a/tcp_buf.c b/tcp_buf.c > index 41965b10..a092cb37 100644 > --- a/tcp_buf.c > +++ b/tcp_buf.c > @@ -45,8 +45,8 @@ static struct ethhdr tcp_eth_hdr[TCP_FRAMES_MEM]; > static struct tap_hdr tcp_payload_tap_hdr[TCP_FRAMES_MEM]; > > /* IP headers for IPv4 and IPv6 */ > -struct iphdr tcp4_payload_ip[TCP_FRAMES_MEM]; > -struct ipv6hdr tcp6_payload_ip[TCP_FRAMES_MEM]; > +static struct iphdr tcp4_payload_ip[TCP_FRAMES_MEM]; > +static struct ipv6hdr tcp6_payload_ip[TCP_FRAMES_MEM]; > > /* TCP segments with payload for IPv4 and IPv6 frames */ > static struct tcp_payload_t tcp_payload[TCP_FRAMES_MEM];