From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aezH8jmb; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 7A3975A0262 for ; Tue, 05 May 2026 12:14:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777976046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7Mh1j8vm/KIvoziJBQKDfca1R3WzgknAuBC4vvLGJL4=; b=aezH8jmb4vdyAHtlCEdcQLZ4OiCGkzV9/WWCyp2+ZzukiZWhN8DmkDTXPRWFMW1iy/9ehR Jc3fxdF7p+IZ/EW4sNJymKmPFlRMgNi1vdQ2S1xqtm6NntuR7Cn6CPkdbMfvZRCI048pHZ oyMW25432KX52OXxXGVbr67iOh+QjgA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-694-Vx4tR6ZHNgWMzWh3jvJxKA-1; Tue, 05 May 2026 06:14:05 -0400 X-MC-Unique: Vx4tR6ZHNgWMzWh3jvJxKA-1 X-Mimecast-MFC-AGG-ID: Vx4tR6ZHNgWMzWh3jvJxKA_1777976044 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-44ffa15dc8cso432340f8f.1 for ; Tue, 05 May 2026 03:14:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777976044; x=1778580844; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7Mh1j8vm/KIvoziJBQKDfca1R3WzgknAuBC4vvLGJL4=; b=nkAu3bd8OdvXA8zzzee/yF5iT5mROHzlu1VVMSPqqtgtMuUhV4qfeG7orTR3rhqcwE +N2taUQZo8Nsi/dmKr+IAz2McLG0F59KOZSXgMNOwV9GKL3c31tjW372ZPOSrqJrlYVn FZpgmR96/vXLqgjdI8qNCTUB+GyfBFDE+oHUr+OM9mc65LFzoFPez5HRzDrPCLKVcwg1 sEmpVMLJMuxJn4WXLSk+xs46mdRuFg7Hlkq5flvtmoaPyaGcwEYbqR+eZenNlmYlEomz EK/569k7XmJgdHd1UFlc5OQYxlwVhgGb8LRPfsJxlRJSnBkH+YAfcwvVBr44xI73rJMh s7Lg== X-Forwarded-Encrypted: i=1; AFNElJ9doFnwD0YRH9r2BRm5sD6pe/1WFNfPiSAhQeDg+k2WrXwzfjAf/v01LO2cVyXW3RE99UlckY6/zWA=@passt.top X-Gm-Message-State: AOJu0YyGotImqRLZotWlvLxGDpk5HYN16rVRwD2B/cMxwszOy3aCudLd kwS22FHKQrsP49zbuKCO4ini1AHmwBv5Ht77nm4WT4S8mtT2BPjqp5rG6BQBvriNEuKQPhqzXS4 KDgBl1yVX4HTKxzfylfQJaCZSEznDjZlhCqXkfmmKgo5rZSH0rmGIHw== X-Gm-Gg: AeBDievKgCr6LM7i7khEMvsfY2cgoxfDSUV5eDrvBfMpPB9DTK0hdbxxicN40g+XMEf lUC84E+wJagEmHWqw0E+Dd5ETKJ4bGKJnNVSYWl1M23VOxfEatq/VMvFieNDHd783RvMA391Sz2 K92bul7m+BxJRHw03OxQLvWRsKy+/1quWEvyFc0Eod6LCIlO/QQqwk5BR5gQ8I+iMcXdI+6/8RI /UHuTBQ0pQxeT2QdhfaUNk18y3bgmhgF4phEZ5ZpY9gmhIRItnxocesK37g3onHL0nFcthrYPVx YsC76eGuTYYlblDyML1VRmWXzPXe6aGPxhgNRkpNozXs1fVUhzbVnY/fTavHQ6dFmdwp/GEcrr1 B6yWwg0tKhRwagmrD8htX4/vwwcN5HjwAcG6TcysHyq6C+ueTUi6krCbIxzHJ6Gq39A== X-Received: by 2002:adf:f50a:0:b0:450:d8cd:efd with SMTP id ffacd0b85a97d-450d8cd0f65mr413054f8f.1.1777976043995; Tue, 05 May 2026 03:14:03 -0700 (PDT) X-Received: by 2002:adf:f50a:0:b0:450:d8cd:efd with SMTP id ffacd0b85a97d-450d8cd0f65mr413027f8f.1.1777976043425; Tue, 05 May 2026 03:14:03 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45054b03df9sm3475009f8f.24.2026.05.05.03.14.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 May 2026 03:14:03 -0700 (PDT) Message-ID: Date: Tue, 5 May 2026 12:14:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/13] Makefile: Use make variables for static checker configuration To: David Gibson , Stefano Brivio , passt-dev@passt.top References: <20260421032338.1909084-1-david@gibson.dropbear.id.au> <20260421032338.1909084-2-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260421032338.1909084-2-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: B8w7tazt1J3OHdIJnSOVCumLziWegXJZVc8aksOgSyY_1777976044 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: DQSSCXUES5YFQLMEQBAN7VLCRC4X6KEA X-Message-ID-Hash: DQSSCXUES5YFQLMEQBAN7VLCRC4X6KEA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/21/26 05:23, David Gibson wrote: > Our cppcheck and clang-tidy rules don't really follow normal Makefile > conventions. Usually any commands other than the very basics have their > binary specified in a variable so it can be overridden on the command line > if they're in an unusual location. Implement that for $(CPPCHECK) and > $(CLANG_TIDY) > > Likewise flags to tools usually have their own Make variable. Do the same > with $(CLANG_TIDY_FLAGS) and $(CPPCHECK_FLAGS). Note that these only have > the options specifically for the static checker, not compiler flags which > we are also supplying to the static checker - those are derived from > FLAGS / CFLAGS / CPPFLAGS as before. > > As part of that we change the probing for --check-level=exhaustive from > being run as part of the cppcheck target, to being run when we build the > CPPCHECK_FLAGS variable. That doesn't make any real difference now, but > will make things nicer if we need multiple cppcheck targets in future (e.g. > for passt-repair). > > Signed-off-by: David Gibson > --- > Makefile | 32 +++++++++++++++++++------------- > 1 file changed, 19 insertions(+), 13 deletions(-) > > diff --git a/Makefile b/Makefile > index f697c12b..17e70d22 100644 > --- a/Makefile > +++ b/Makefile > @@ -174,21 +174,27 @@ docs: README.md > done < README.md; \ > ) > README.plain.md > > +CLANG_TIDY = clang-tidy > +CLANG_TIDY_FLAGS = -DCLANG_TIDY_58992 > + > clang-tidy: $(PASST_SRCS) > - clang-tidy $^ -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \ > - -DCLANG_TIDY_58992 > + $(CLANG_TIDY) $^ -- $(filter-out -pie,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) \ > + $(CLANG_TIDY_FLAGS) > > -cppcheck: $(PASST_SRCS) $(HEADERS) > - if cppcheck --check-level=exhaustive /dev/null > /dev/null 2>&1; then \ > - CPPCHECK_EXHAUSTIVE="--check-level=exhaustive"; \ > - else \ > - CPPCHECK_EXHAUSTIVE=; \ > - fi; \ > - cppcheck --std=c11 --error-exitcode=1 --enable=all --force \ > +CPPCHECK = cppcheck > +CPPCHECK_FLAGS = --std=c11 --error-exitcode=1 --enable=all --force \ > --inconclusive --library=posix --quiet \ > - $${CPPCHECK_EXHAUSTIVE} \ > --inline-suppr \ > - --suppress=missingIncludeSystem \ > + $(shell if $(CPPCHECK) --quiet --check-level=exhaustive /dev/null; then \ > + echo "--check-level=exhaustive"; \ > + else \ > + echo ""; \ > + fi) Perhaps we can add a reusable function to check flags: check_flag = $(shell $(1) $(2) >/dev/null 2>&1 && echo $(2)) Then $(call check_flag, $(CPPCHECK) /dev/null, --check-level=exhaustive) \ > + --suppress=missingIncludeSystem \ > --suppress=unusedStructMember \ > - $(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) -D CPPCHECK_6936 \ > - $^ > + -D CPPCHECK_6936 > + > +cppcheck: $(PASST_SRCS) $(HEADERS) > + $(CPPCHECK) $(CPPCHECK_FLAGS) \ > + $(filter -D%,$(FLAGS) $(CFLAGS) $(CPPFLAGS)) $^ \ > + $^ You have duplicate '$^' here.