From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=X3veMRcf; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 828555A0279 for ; Fri, 08 Aug 2025 15:57:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1754661428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=PMgYTa1IH7qXHRrdjYjdxXhVr/doMqN3HpJecbTapbg=; b=X3veMRcfD25WQef5GkKjP8xdKiJ0fEjIYqawLRVMURmhYFpz0krcwrjLXesf/DciVyeHVH zQulLJllNt+1t6fz/06XmnDO6+5VzgYMBD1QlAC1FxWy/7IOSW03rSqEvWIQqU1pndhuNH kqze0Ee1dVTJZcmmRlOLpDZVaN07Sbk= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-lFXDuPaJPHuUo-NtVQln5A-1; Fri, 08 Aug 2025 09:57:07 -0400 X-MC-Unique: lFXDuPaJPHuUo-NtVQln5A-1 X-Mimecast-MFC-AGG-ID: lFXDuPaJPHuUo-NtVQln5A_1754661426 Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-7e69c14e992so415325785a.3 for ; Fri, 08 Aug 2025 06:57:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1754661426; x=1755266226; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PMgYTa1IH7qXHRrdjYjdxXhVr/doMqN3HpJecbTapbg=; b=FlRkLZnLUGpnghgorinBaIS0hukSOBRzIqyDlGAJPVM/t0zJV1KhBNRhRGE0ZS0khR QoZPvYAxDgC05YMvl2T234dKb8NqAzeFSAd33if0i50eLzycJOBX43pTSjVK1x/94raF MxMUCshGpT0kb+4UbifgHLCcTDa4pNno8GRbj2PBSaKH8kOl7XpKr66SC1o7H1Dhxs+Q 1J+d+QcDmsIeV1Y3EtRO1NOqT9g5PIpC4RDaA+iBILkP94vr2Nzn5+s0PabzVCHN1PBg Zxw5G9f8pCRN4MYFWr+UJaRz8ZW3JVgGTeUoiJr1elC4qxT3S++2x8MpIO+LFGQ0V+Iw YvNQ== X-Gm-Message-State: AOJu0YxLU7AuQUuuNMEWhVOA7CVKxl8X6LaK8bIETGh9OQJvEPZ0qwgj MN09qQoItYIIYG+9ZqiU39pt3E7Sisrf/PhG9t6KaE8DoXXU6JhNywuKS2t3RiZoJCFlUDrDFwH EWPNi2pLMBOdhtaT0D09xgcEkxUaLTp15ZhNbeM73DWSstLKDzfg7WA== X-Gm-Gg: ASbGnctbmu8GCxKaz+XCkYuv7GPDEjLbDGZBp/0aGoghSAOuYL2y/EGiqCuzwvcDgaJ Z5l0i7BHaZY1cHKkyFy2gFaVaC0nz+o8swY/t6lINLOelmHkAIlvvq/w52yRrLPEotMKh2zXo/1 xnCbMHIky8o80H6jeICIHS0EsjUFTyHaRXzky1r98cC+j3qLXOwLxU3RvCuO3asl+2R9To0xp/k uFneqQySBPI8dAPdKBeiFQrkkOlu6xejAVFAFewtV9l4AT+X9yK6KHPFAhve2zvYaRHC3Ao504G tqptZFJyHDFoDYAcctTFoB4FZzXaqUp6vAyC3NHSf1Zh405lA0ozXqlKevd+T02KNZbDRbl/oqA z8K2bHLBi X-Received: by 2002:a05:620a:55bb:b0:7e6:9644:c993 with SMTP id af79cd13be357-7e82c65c366mr336921085a.15.1754661426474; Fri, 08 Aug 2025 06:57:06 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFo5xR7GH3f1J/hYaHLBZjc2HUI9JfhnatPJcPPq8dNbeT6BolsZqXXOXaGnFnFw6oiK8VRkw== X-Received: by 2002:a05:620a:55bb:b0:7e6:9644:c993 with SMTP id af79cd13be357-7e82c65c366mr336916785a.15.1754661425784; Fri, 08 Aug 2025 06:57:05 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e69716fa4asm882263685a.58.2025.08.08.06.57.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Aug 2025 06:57:05 -0700 (PDT) Message-ID: Date: Fri, 8 Aug 2025 15:57:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 20/30] tap: Convert tap6_handler() to iov_tail To: David Gibson References: <20250805154628.301343-1-lvivier@redhat.com> <20250805154628.301343-21-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: OUxf9uSSIwOmpkxtlopKNXrnCpP-EeGrTGnReBpbnSo_1754661426 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: LPI5CL4UZWZMTFWBOTXDJM5F6ISXEPIL X-Message-ID-Hash: LPI5CL4UZWZMTFWBOTXDJM5F6ISXEPIL X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/08/2025 08:21, David Gibson wrote: > On Tue, Aug 05, 2025 at 05:46:18PM +0200, Laurent Vivier wrote: >> Use packet_data() and extract headers using IOV_REMOVE_HEADER() >> and IOV_PEEK_HEADER() rather than packet_get(). >> >> Remove packet_get() as it is not used anymore. > > [snip] >> @@ -896,21 +896,28 @@ resume: >> for (seq_count = 0, seq = NULL; i < in->count; i++) { >> size_t l4len, plen, check; >> struct in6_addr *saddr, *daddr; >> + struct ipv6hdr ip6h_storage; >> + struct ethhdr eh_storage; >> + struct udphdr uh_storage; >> const struct ethhdr *eh; >> const struct udphdr *uh; >> struct iov_tail data; >> struct ipv6hdr *ip6h; >> uint8_t proto; >> - char *l4h; >> >> - eh = packet_get(in, i, 0, sizeof(*eh), NULL); >> + if (!packet_data(in, i, &data)) >> + return -1; >> + >> + eh = IOV_REMOVE_HEADER(&data, eh_storage); >> if (!eh) >> continue; >> >> - ip6h = packet_get(in, i, sizeof(*eh), sizeof(*ip6h), &check); >> + ip6h = IOV_PEEK_HEADER(&data, ip6h_storage); >> if (!ip6h) >> continue; > > You peek the IPv6 header here, but I haven't spotted where you remove > / drop it before... > In fact, data offset is modified by ipv6_l4hdr() that scans the headers and the data provided to ipv6_l4hdr() must point to an ipv6hdr (it provides also the proto that is alloed to do the correct IOV_PEEK_HEADER()). Thanks, Laurent