From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=iTcbK40v; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 1B6AD5A004C for ; Thu, 03 Oct 2024 16:56:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727967363; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=xguYMWgprOdsllMKb+mC4ozxlRkMKE9N+i8LAQ4ane4=; b=iTcbK40vU6CYnXg1Fdv3IH8jL/U0K4w8dOTG7jUNUJpUPXgxIDW+nodWzjkPaBF/sx8Cje ZXX1NAi8Ac17M+6ZO1j3nfZWvBYEjQ+cSFZNAMv/AW7f3PciHigAar9GMnfEhky4lnhOpA BvG/UP3W19eMXb/wYDMuqjVvuXuoaYc= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-218-YSchBWJ8MZeRp6rjf7xnGA-1; Thu, 03 Oct 2024 10:55:59 -0400 X-MC-Unique: YSchBWJ8MZeRp6rjf7xnGA-1 Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7a9a74d39b5so174193785a.2 for ; Thu, 03 Oct 2024 07:55:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727967358; x=1728572158; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xguYMWgprOdsllMKb+mC4ozxlRkMKE9N+i8LAQ4ane4=; b=aKwERwyrfFHtQCDKVETynLEByf1wkfM+JCqR4CCaNE5AUY3JHhM0eaxPwqvgBIJ4su 5E1+yeAcmRRwIyynFmAUkn/pV/NPtsdJHcQ9fYUndqVPVq8DqhHdMJnk6nP2BPxjwWkP 08IGz9pVJ5nP9K3LPYkQBmCWcpse5hr5iOvF90G5hDO3D8mcaysVysiwviPlA86QmGAm fIiHL+qjunRn/4CjZegls+S8oJnOmflX0jWSdlYxkWecBYNg2FaSF4k45vM0xyr9RIpN xxcL9ys75m6SGH7p/3jNwHWXy3S6FqTX9uXAIQBfPeJZoZtCJHyDijA0u2A7hrt5nNUv lXBw== X-Gm-Message-State: AOJu0Yw3e5wnMBgO3kHo47OaiQrLc3O7hubDPNQ/wJmOgXtj75/V2XuW Xyn75Q+ghrpjff79OVyTtJSoD0VAaodYqOPXOagl+3O5KwCWasxY5jeItQ8xYWhWIXeWmAW3Lxa KVwUqHL+6kV63UipAKqM/0+JoAYorRXkGMgY2mId/wGEH5TbISg9XlLposoYyxSRuFwzTyNPpsZ ia3Ft9gX1m6I4PaZKNI7qtWvhxbZN8s1SX X-Received: by 2002:a05:620a:bc6:b0:7a9:a1b3:2240 with SMTP id af79cd13be357-7ae6273788amr1017245585a.61.1727967358340; Thu, 03 Oct 2024 07:55:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES/wqrBriM5StXhTLYl2zPrIPjbmAVGJDuRT+cFh+aJX+Q6KBbbCSvs88VcCE9fexI8cgZ1w== X-Received: by 2002:a05:620a:bc6:b0:7a9:a1b3:2240 with SMTP id af79cd13be357-7ae6273788amr1017243285a.61.1727967357910; Thu, 03 Oct 2024 07:55:57 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7ae6b29e1f9sm57154285a.20.2024.10.03.07.55.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 07:55:57 -0700 (PDT) Message-ID: Date: Thu, 3 Oct 2024 16:55:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 4/5] tcp: Update TCP checksum using an iovec array To: passt-dev@passt.top References: <20241003145108.2227355-1-lvivier@redhat.com> <20241003145108.2227355-5-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241003145108.2227355-5-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: JPD6MUAVWKD34U7LGORPB4KKB5Q3V3RZ X-Message-ID-Hash: JPD6MUAVWKD34U7LGORPB4KKB5Q3V3RZ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 03/10/2024 16:51, Laurent Vivier wrote: > TCP header and payload are supposed to be in the same buffer, > and tcp_update_check_tcp4()/tcp_update_check_tcp6() compute > the checksum from the base address of the header using the > length of the IP payload. > > In the future (for vhost-user) we need to dispatch the TCP header and > the TCP payload through several buffers. To be able to manage that, we > provide an iovec array that points to the data of the TCP frame. > We provide also an offset to be able to provide an array that contains > the TCP frame embedded in an lower level frame, and this offset points > to the TCP header inside the iovec array. > > Signed-off-by: Laurent Vivier > --- > > Notes: > v6: > - fix clang-tidy error with ptr > - add missing static to tcp_update_check_tcp[4|6] > > v5: > - s/IPv6/IPv4/ > - reintroduce ip6h and iph to avoid iov_size() > - check pointer alignment before casting to the type > > v4: > - replace die() by err() in tcp_update_check_tcp6() too > > v3: > - replace die() by err() and return > - add more information in the error message > > v2: > - s/payload_offset/l4offset/ > - check memory address of the checksum (alignment, iovec boundaries) > > checksum.c | 1 - > iov.c | 1 - > tcp.c | 118 +++++++++++++++++++++++++++++++++++++++++++++-------- > 3 files changed, 100 insertions(+), 20 deletions(-) > ... > diff --git a/iov.c b/iov.c > index 3f9e229a305f..9116dda94247 100644 > --- a/iov.c > +++ b/iov.c > @@ -25,7 +25,6 @@ > #include "util.h" > #include "iov.h" > > - > /* iov_skip_bytes() - Skip leading bytes of an IO vector > * @iov: IO vector > * @n: Number of entries in @iov This is an unwanted change... could you remove it on merge? Thanks, Laurent