Re: [PATCH v5 02/29] iov: Introduce iov_slice(), iov_tail_slice() and iov_tail_drop().

[Laurent Vivier <lvivier@redhat.com>]

On 26/05/2025 16:19, Stefano Brivio wrote:
>> + * @dst_iov_cnt: Maximum number of elements in the destination iov array.
>> + * @iov:	 Pointer to the source array of struct iovec describing
>> + *		 the scatter/gather I/O vector to copy from.
>> + * @iov_cnt:	 Maximum number of elements in the source iov array.
>> + * @offset:	 Offset within the source iov from where copying should start.
> I would mention explicitly this is only for the first iov, otherwise it
> might look like it's a fixed offset that applies to all elements
> (...until you find the offset = 0 assignment below), say:

It's not an offset for the first iov, it's offset in the entire data.

We skip this offset using:

  i = iov_skip_bytes(iov, iov_cnt, offset, &offset);

so we skip all iov entries until 'i' and then we apply the remaining offset to entry 'i'.

Perhaps:

   @offset: Data offset within the source iov array from where copying should start

Thanks,
Laurent