From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Py/696At; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id A82055A0265 for ; Tue, 24 Feb 2026 09:01:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1771920099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=49aaVrGqQPPFuj9GiiFKLsojahBXJuk8VnNkjvtAZA4=; b=Py/696AtJBXfI0di4hRnEpYXbF2Hb2y/f469R6BVurkgF9mc79QZ47eZXfH1lckE2ApdbV mAFfd+8jgWPrIppjhYwFwtS0LNMCpS6usuhvJKnHPgR8DYVL9uhL1Rb2XAy493Ld89n2Jz 0xMzPSE0Cl5/ycEP680uk3GDLHAC1P8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-vzLaPR0VNsK2Zz88jjwVAw-1; Tue, 24 Feb 2026 03:01:35 -0500 X-MC-Unique: vzLaPR0VNsK2Zz88jjwVAw-1 X-Mimecast-MFC-AGG-ID: vzLaPR0VNsK2Zz88jjwVAw_1771920094 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43623cfb160so1646594f8f.1 for ; Tue, 24 Feb 2026 00:01:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771920094; x=1772524894; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=49aaVrGqQPPFuj9GiiFKLsojahBXJuk8VnNkjvtAZA4=; b=wL50AZfkgunjpk0fgE2seCS42tbRCnPgV3KG+eopw1olsIfn2acINTidCYsBsE2qME SyV9EQdbNRLKfk/enZqGkl69acagjIsI/sis/ClhXHiT4hbcrNgbFH/3G7RfCsLo64O+ wErHCuT0jFzYRKmhdSdSdo4bNPhvBlYu4JGXU6tzAGR6nBYvr9OclejMJIE2X6yrg0Ga 66XPzjhcqVFCVLeH53+UJ033buAENNQJCuqYevUp01o+apmtP6aI20FXg4mdMBLlDieH KZjC+jVdMuL9+9pdyDdRPMZJNQRZj4B6JpySjkIHGjyCGAbzC8HpAJHpdP6KeXRHhoFE qA8Q== X-Forwarded-Encrypted: i=1; AJvYcCU2OAdJ3QbmFWYVAxFbhVtgvKHYybG7pFs7zakR9MuacVfJmBPdldMuwx9uJcFuuhNCmbPgcMafcWk=@passt.top X-Gm-Message-State: AOJu0YxZTK92cIWnxNbIl6OE77wQh1BkkI96/F7i/rx/ATSnwTpB9Hii 0hPyuZNGVz+cvqnq+sCx3LFfeckRqSmS2JXQ38XFST+6Fz/VM7gDbl0w2upm6LTprcrj3renRO4 Vgh1t55a5dRV2gvAaAqOg8SnjLV0lttqn17TBXcxMTmZdCpeqFHW5lg== X-Gm-Gg: ATEYQzyDshB0QRwWxYyqicT9/YvVX55lNulYyaOJ/pGkARTZfwu5hrL/cc14dpr36x5 CFAL4aQmGjLgTYowAV1Tnnzu/b5r/XeHikJXxa/3GIVRFAoaUflpFdYylD8Irakx9Ef1TJxA4Ll LMlkFI9D3VHsCTWcHZES+8Qk+MbR4qoxu3mdAnDUbvJ9V/uzvNF97sd7/HlxUzGYgGbLenVUrpn FjnHcr5sZsCfrkIzdFD2zW5Zf360+Hyel86f4jYAJwDU5yxcmTKujp+9x1CK4AMSivyRq0bbxJm nQEEJiJ+x8jGrqPLad8P5ISJKsExCFzzBxBsQ9iKNZwr89A0FbTo1k/TC+BA32QBXeYteVAAVv/ UA4lVU/1KI1eUAvDuzrY0QHxZEVM86Ezs7gsm6tqD6Z7XxjT9UcKyZdS7NMxN/drx+RrsqeFdFH 5My/gjv++ega6zGpdv5yVTQQKMJlBh+nG54OoYiWmWELE6RiYHtFub/H5l X-Received: by 2002:a05:6000:4205:b0:439:881a:6578 with SMTP id ffacd0b85a97d-439881a67e8mr1135912f8f.21.1771920093740; Tue, 24 Feb 2026 00:01:33 -0800 (PST) X-Received: by 2002:a05:6000:4205:b0:439:881a:6578 with SMTP id ffacd0b85a97d-439881a67e8mr1135833f8f.21.1771920093168; Tue, 24 Feb 2026 00:01:33 -0800 (PST) Received: from ?IPV6:2a01:cb00:8ef9:5300:877b:aaab:2ea7:8695? (2a01cb008ef95300877baaab2ea78695.ipv6.abo.wanadoo.fr. [2a01:cb00:8ef9:5300:877b:aaab:2ea7:8695]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970c00485sm27719291f8f.9.2026.02.24.00.01.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Feb 2026 00:01:32 -0800 (PST) Message-ID: Date: Tue, 24 Feb 2026 09:01:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Fix build when HAS_GETRANDOM is undefined To: Peter Foley , passt-dev@passt.top References: <20260223172739.144834-1-pefoley@google.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260223172739.144834-1-pefoley@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DEGnIGBY6_qgvCEm8bJEu1WQtDmXDFQmnN51fUco0ps_1771920094 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: FUOKAYCXYR4XGRHYIWFEYCVPPTMXY5FP X-Message-ID-Hash: FUOKAYCXYR4XGRHYIWFEYCVPPTMXY5FP X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 2/23/26 18:27, Peter Foley wrote: > e.g. > util.c:1163:14: error: use of undeclared identifier 'dev_random'; did you mean 'raw_random'? > 1163 | ret = read(dev_random, (char *)buf + random_read, > > Signed-off-by: Peter Foley > --- > util.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/util.c b/util.c > index db27431..a4f2be4 100644 > --- a/util.c > +++ b/util.c > @@ -1160,7 +1160,7 @@ void raw_random(void *buf, size_t buflen) > ret = getrandom((char *)buf + random_read, > buflen - random_read, GRND_RANDOM); > #else > - ret = read(dev_random, (char *)buf + random_read, > + ret = read(fd, (char *)buf + random_read, > buflen - random_read); > #endif > > @@ -1177,7 +1177,7 @@ void raw_random(void *buf, size_t buflen) > } > > #ifndef HAS_GETRANDOM > - close(dev_random); > + close(fd); > #endif > > if (random_read < buflen) Fixes: 71d5deed5eed ("util: Add general low-level random bytes helper") Reviewed-by: Laurent Vivier