From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=FUuECPEm; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 677525A004E for ; Thu, 12 Sep 2024 13:24:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726140244; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=+FHYjeGzp4yjxyKjRRYfFvQDI//ZPuQXzVmHrMZL7cg=; b=FUuECPEmiBOETm7XzFAEnGEwAedi7WEpiyxzAfUiPnc3VFyDZB1reIe/J8au5B2Ds94nRu +jNcVPU9Yp05HzpmOU/ok+Aj/Bwob1Yyx9ocxA2zLp4j4qyHfbOiM6R6jD4XS1tQc6bHYA qV3GscE4wK6mg8ORhjsd9k11YgL2Y9k= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-ha2XQ9MKNPWTJ40wh2F4pg-1; Thu, 12 Sep 2024 07:24:03 -0400 X-MC-Unique: ha2XQ9MKNPWTJ40wh2F4pg-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-374c960ee7aso594439f8f.3 for ; Thu, 12 Sep 2024 04:24:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726140241; x=1726745041; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+FHYjeGzp4yjxyKjRRYfFvQDI//ZPuQXzVmHrMZL7cg=; b=hp/6CZd/X8E4w+hXhyRY0FiGY+Wa14R8jGFpb8Obo4Rl2TrVSO2BhemzAzRDXXPMJA ecPZ51goDE8cknwiks3cwrksSKy23aTOtH1+rXAySCA1J52FfpMwwx+GmiRSTfhnggrE MdIvdApyPpDhzUQOZEg36hxTaBtZshz8qAzh5YbAJCP605EioTZU8Q02TNIueV7DMkPo /OYrq1nA1eqArkNEMeF9tQoMy4EvaWXq7myn1ZinTD51WKJfR3S7vOHXHUpsS6sUCWeu ap8Qc90oOw7YTOcsFPJlIOnJoGPQTIy14FI+96OG5BZQLw7hmrAI9rFiD464ox/hw1BZ JlTw== X-Gm-Message-State: AOJu0YyJO0wNNkEf5HGapnCgRnPpzq9zPhHR7czej8v1CHwXwG/GNvjf /oXWOl41EO9I4FddjMOdhVgAkjiFBWo95Z6smjzQVFNFF4LmD6GkRL6pALEZgMvCVqhUySHepXm kF+AhI5zKcszAJxA9PyW10ZoPVYdMngOsNlOzBRASAt2lJdZgKQ== X-Received: by 2002:a05:6000:1207:b0:374:c29a:a0d6 with SMTP id ffacd0b85a97d-378c2cd3b50mr2004231f8f.2.1726140240924; Thu, 12 Sep 2024 04:24:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6XUJlD+5ITBOB7xo31UjI7MiJs8s4s7tJo3suDZPk/hFM5tjIht3pzBM8AGfZ8Ds3Uz4b/g== X-Received: by 2002:a05:6000:1207:b0:374:c29a:a0d6 with SMTP id ffacd0b85a97d-378c2cd3b50mr2004181f8f.2.1726140239763; Thu, 12 Sep 2024 04:23:59 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37895649733sm14139824f8f.8.2024.09.12.04.23.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Sep 2024 04:23:59 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 13:23:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] vhost-user: introduce virtio API To: Stefano Brivio References: <20240906160455.2088854-1-lvivier@redhat.com> <20240906160455.2088854-3-lvivier@redhat.com> <20240910174731.3c4db56f@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20240910174731.3c4db56f@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: ISA6CYP3KOEFNYMI7JWI6JRCDFPCYSVE X-Message-ID-Hash: ISA6CYP3KOEFNYMI7JWI6JRCDFPCYSVE X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/09/2024 17:47, Stefano Brivio wrote: >> + >> +/** >> + * virtqueue_read_indirect_desc() - Copy virtio ring descriptors from guest >> + * memory >> + * @dev: Vhost-user device >> + * @desc: Destination address to copy the descriptors to >> + * @addr: Guest memory address to copy from >> + * @len: Length of memory to copy >> + * >> + * Return: -1 if there is an error, 0 otherwise >> + */ >> +static int virtqueue_read_indirect_desc(struct vu_dev *dev, struct vring_desc *desc, >> + uint64_t addr, size_t len) >> +{ >> + uint64_t read_len; >> + >> + if (len > (VIRTQUEUE_MAX_SIZE * sizeof(struct vring_desc))) >> + return -1; >> + >> + if (len == 0) >> + return -1; >> + >> + while (len) { >> + const struct vring_desc *orig_desc; >> + >> + read_len = len; >> + orig_desc = vu_gpa_to_va(dev, &read_len, addr); > In case you missed this in my review of v3 (I'm not sure if it's a > valid concern): > > -- > Should we also return if read_len < sizeof(struct vring_desc) after > this call? Can that ever happen, if we pick a particular value of addr > so that it's almost at the end of a region? > -- In fact, read_len can be < sizeof(struct vring_desc) after this call but if orig_desc != NULL it means we can continue in another region to continue to fill the structure. If there is not enough memory to fill "len" bytes it exits with -1. Thanks, Laurent