From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=CktDaASh; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 343045A004C for ; Tue, 17 Sep 2024 12:03:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726567399; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=L2t261wUW5y4zmhx38ESQM9KU6SD/rHn0w0adI/6fdI=; b=CktDaAShxClvMq8FcBWhbdkN99E34uJVsi1c6qP4SfWkfh9VAhWac5n2GfCgdDpbMS/Pwr 1b9kSxRQpT0M+r2FJIHfzOTYlbp+bTwZrIKFV2RF+lhkeX34ioAyanqYEZAU2ozV1HTHxi Qx92I6lFp8WQJG0xWPSRU11+AQXLXiA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-412-IvB7sJjLNH2cov1FiiNsHQ-1; Tue, 17 Sep 2024 06:03:17 -0400 X-MC-Unique: IvB7sJjLNH2cov1FiiNsHQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42caf073db8so42755025e9.3 for ; Tue, 17 Sep 2024 03:03:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726567396; x=1727172196; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L2t261wUW5y4zmhx38ESQM9KU6SD/rHn0w0adI/6fdI=; b=jcLjQERt54k81SFUs0MXn0KIlqNgdYyFBqoH+bVsnW3oHHc6SyChC5gdT8+0m8VWYa DkN+uZCHdHOs3p5rPrUB/lKpd84BZDauFSTqL29f+1qgI2xrExJTbuMrLYRDuvWu0b4Z wehbbJl2/VJCSj+bdIr4a/ojZHPq7cURS2GYkM/CcP/IYzIRy5DQoEiTlv/DcAvmrje0 cdItqubLpvDcsZYSSF3s0XIeR8tii77kXpjUy4LiaLeNwYixUjrFZ6z0DWjOXtaBNZD3 cIB0OrSMVkS1fuNM6u/olpnjfY4+4yMqH/4yB9k7pR+1uebsV2gLgIE5S9VMppZe97ti ADTQ== X-Gm-Message-State: AOJu0Yw8kPNL3Nr0yueT8I6h1HaR/CIIEAo5VRUPRpAUHONrw9JzbEf7 KU2Mjx4/E0IvjH/hkZ96xyAXif/vmoyvxlyaOgkjKNUbtxv4AZCbCFsnXxT0+FFnLNkILqUk70z fVIkkBGW7z+wv8mqJHRtANRXODxScvhmWDq76J70SSn5GPF4Slc6iuascng== X-Received: by 2002:a05:600c:4f51:b0:42c:b95c:65b7 with SMTP id 5b1f17b1804b1-42cdb531b1cmr130538985e9.8.1726567395836; Tue, 17 Sep 2024 03:03:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFTmxCwdKQQPghxWav7AUgo8VFzkzel4KhXlvJKkziSmSG1IxI1MBr2gQgq4YoOZReZ+qOEg== X-Received: by 2002:a05:600c:4f51:b0:42c:b95c:65b7 with SMTP id 5b1f17b1804b1-42cdb531b1cmr130538775e9.8.1726567395286; Tue, 17 Sep 2024 03:03:15 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78? ([2a01:e0a:e10:ef90:4c84:58cb:a1ef:8b78]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42d9b189acasm131323045e9.37.2024.09.17.03.03.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 17 Sep 2024 03:03:14 -0700 (PDT) Message-ID: Date: Tue, 17 Sep 2024 12:03:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/4] vhost-user: add vhost-user To: David Gibson References: <20240913162036.3635783-1-lvivier@redhat.com> <20240913162036.3635783-5-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: BXZRPNQL3MGOFSCBAHICNUFXCS75VUZG X-Message-ID-Hash: BXZRPNQL3MGOFSCBAHICNUFXCS75VUZG X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 16/09/2024 09:00, David Gibson wrote: >> --- a/tap.c >> +++ b/tap.c >> @@ -58,6 +58,7 @@ >> #include "packet.h" >> #include "tap.h" >> #include "log.h" >> +#include "vhost_user.h" >> >> /* IPv4 (plus ARP) and IPv6 message batches from tap/guest to IP handlers */ >> static PACKET_POOL_NOINIT(pool_tap4, TAP_MSGS, pkt_buf); >> @@ -78,16 +79,22 @@ void tap_send_single(const struct ctx *c, const void *data, size_t l2len) >> struct iovec iov[2]; >> size_t iovcnt = 0; >> >> - if (c->mode == MODE_PASST) { >> + switch (c->mode) { >> + case MODE_PASST: >> iov[iovcnt] = IOV_OF_LVALUE(vnet_len); >> iovcnt++; >> - } >> - >> - iov[iovcnt].iov_base = (void *)data; >> - iov[iovcnt].iov_len = l2len; >> - iovcnt++; >> + /* fall through */ >> + case MODE_PASTA: >> + iov[iovcnt].iov_base = (void *)data; >> + iov[iovcnt].iov_len = l2len; >> + iovcnt++; >> >> - tap_send_frames(c, iov, iovcnt, 1); >> + tap_send_frames(c, iov, iovcnt, 1); >> + break; >> + case MODE_VU: >> + vu_send(c->vdev, data, l2len); > I'm a bit uneasy re-introducing a parallel send function for the slow > path, rather than using a common tap_send_frames() interface. Any > chance you can unify those sensibly? Bearing in mind that this_is_ > the slow path, so if you have to copy a bunch of stuff, that's ok. I tried but it's over complicated to take in input an iovec array and to use another iovec array (provided by the guest) to send data. It's easier to have a buffer and to copy it to the iovec array buffers of the guest. Moreover we don't need to have a tap_send_frames_vu() (see vu_handle_tx()), so we will introduce it to always send an iovec array with only one entry. Thanks, Laurent