From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=IyOfT36U; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id D0A5C5A026F for ; Tue, 07 Oct 2025 14:07:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759838865; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=OhxL8OZZz6OEdhpuPbfrn5HkEzL2NpeQYJKqqXy4ugk=; b=IyOfT36Ut3YuKBOMFupek0iGxrkuDsW/MwvcfAiYg9Yucy+SvXNogIm3kvqEnDhcRAhQLc uz2YXPyezkx2Dgn8/mQKkX6FisBQQeG65BBTEbGq71wEVrEZmoyOtooYKtHipf+Xfrb9JA Q9mijrj+l8Jp9TEyXSWA1XOWRsDE+m0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-Hyipru8HMXq0fr5f_DLEIg-1; Tue, 07 Oct 2025 08:07:42 -0400 X-MC-Unique: Hyipru8HMXq0fr5f_DLEIg-1 X-Mimecast-MFC-AGG-ID: Hyipru8HMXq0fr5f_DLEIg_1759838861 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-46e2c11b94cso32258025e9.3 for ; Tue, 07 Oct 2025 05:07:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759838861; x=1760443661; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OhxL8OZZz6OEdhpuPbfrn5HkEzL2NpeQYJKqqXy4ugk=; b=hMINL2FJUrz7McVZ8X3CDe8ZkmXBm1pDi1Gwrp1yvjnV/k8FcvL35MMCWiIinsa0Y1 0Mqjrv7dsOGyGGfYsFv9Jvpead8BkOuHa3XETIFTrRQQx8pk0FQ6He++ypdA280jiweU HHJCY71w8sP5rHQr1UkBAXQ6LSmnTyyRJL/FQIC0pn7muIB+x8TBbfJixZfO2zsfBUc1 K/kboVdUJUfxX+/dKvsYKJsR7sj2RE6OxBKoWUSjBCUde7zI8BmLJ/eqlg3L+srcRK4O VW1JVhIDKq66mnnZWLyDONxywW+y/AX22sC5K5YYSjOcZOJW9Csx3NMsqMysA45BAGGY aZbA== X-Gm-Message-State: AOJu0Yx9DHlylXnVYM5zqMH8tem6+mNKhYDuBrizEPxM+YWl/PULmYVy AdYHdMBs6wHHXp2C8RdCmIvR/qTB5UVLqA2fKH1Vl5u69erHz5hjeJA2X4UQgSEeiUgseeoBJin tltAduPytiQ4VgtCZlQQDHgfR9TNcWBplBrkFijrpza1CQ5V51RMrWA== X-Gm-Gg: ASbGncsKhRP3pfO8kFoEiYV3ATAMGWbw2WfCISGm1BlQfLaooQJR7hDItYmWEf9//YE Hm/0lf1yTG3V7+AvgG9kMJfL+UvYNkwH8Aq4pKXePrGGlWsLY+v7LQKiiKd6R8tv1kBLiyhf8gU y3wS3M2sYn0Bj0FdtxcUnWRvCvS+4TNm2OWzkZ8zM2/Gwp28Gc6jfGeYPEdBxvpCaEbf+Lq5xWZ aFOkEnWRcfkn8Y3viaRShtyE8kT4cTlpu3sDThGtXfb2KQXr7VU27tsRrW1+2XV0N/xpEZyk2Ay yFghE2gO5zN7YhabFvzfJIjsXtFj4TLb+NQuqS/trMltF8GCzSWeuicyyQs9HxXQJlMWgYLvPRp JZ6tIUb/W X-Received: by 2002:a05:600c:354d:b0:46e:6a6a:5cf7 with SMTP id 5b1f17b1804b1-46e711026c4mr112590275e9.12.1759838861210; Tue, 07 Oct 2025 05:07:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXQ/bqwWrWvYPqSw4K8rLIm/KP/zpOqH6BUwOglx+uaydsbj/cOBxNwzDW/JVvm46jEKsDwg== X-Received: by 2002:a05:600c:354d:b0:46e:6a6a:5cf7 with SMTP id 5b1f17b1804b1-46e711026c4mr112590005e9.12.1759838860674; Tue, 07 Oct 2025 05:07:40 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e61a0241bsm291883325e9.11.2025.10.07.05.07.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Oct 2025 05:07:40 -0700 (PDT) Message-ID: Date: Tue, 7 Oct 2025 14:07:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] tcp, flow: Replace per-connection in_epoll flag with epollfd in flow_common To: Stefano Brivio , David Gibson References: <20251003152717.2437765-1-lvivier@redhat.com> <20251003152717.2437765-4-lvivier@redhat.com> <20251007115117.3ba165a4@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20251007115117.3ba165a4@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: H2X6RELh0Kdt4df1tKZ75WpB3Br2pRz69lHiX3CSb6c_1759838861 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: EQ25F7BAZPBVMMFZ7LLYGSAMVMEYZIKJ X-Message-ID-Hash: EQ25F7BAZPBVMMFZ7LLYGSAMVMEYZIKJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 07/10/2025 11:51, Stefano Brivio wrote: > On Tue, 7 Oct 2025 17:07:37 +1100 > David Gibson wrote: > >> On Fri, Oct 03, 2025 at 05:27:15PM +0200, Laurent Vivier wrote: >>> The in_epoll boolean flag in tcp_tap_conn and tcp_splice_conn only tracked >>> whether a connection was registered with epoll, not which epoll instance. >>> This limited flexibility for future multi-epoll support. >>> >>> Replace the boolean with an epollfd field in flow_common that serves dual >>> purpose: zero indicates not registered (replacing in_epoll=false), non-zero >> >> Don't use 0, since that's a valid fd. >> >>> stores the actual epoll fd (replacing in_epoll=true). >> >> I am a bit nervous about adding 31-bits to every flow, since I think >> we're fairly close to a cacheline threshold. > > I mentioned to Laurent in our weekly call on Monday the same concern > and that I would look into it (first step, I would say, actually check > with pahole?) and, if it's an issue, into possible tricks to avoid > making the struct too big. I still plan to do this. > I think it already doesn't fit in a cacheline: struct flow_common { enum flow_state state:8; /* 0: 0 4 */ enum flow_type type:8; /* 0: 8 4 */ /* Bitfield combined with next fields */ uint8_t pif[2]; /* 2 2 */ struct flowside side[2]; /* 4 72 */ /* size: 76, cachelines: 2, members: 4 */ /* last cacheline: 12 bytes */ }; Laurent