From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Lw6JeQiJ; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B3B515A0282 for ; Tue, 27 May 2025 15:16:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748351768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dsz1aOHfUZGo1Ui2D3oIjc2p8br7ObKeotk8N29rOaI=; b=Lw6JeQiJOBwvWtt9gpPVDj+t5q2dqkhEBoj5aQqzIY62ScJ1ow37SVO75ByM7YtEkCxlGm xbWgz/eIT9yMYPysCG/gLxn2CnMe0nyqGVh/RTVmKDDNmhc2nPAA8Ri3jYA8c76WVEfXLv s0B36SlY9UxXpme5fFfxhX0mugbXIw4= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-18-vtDocgGWNvGCpNhRsIpHdg-1; Tue, 27 May 2025 09:16:07 -0400 X-MC-Unique: vtDocgGWNvGCpNhRsIpHdg-1 X-Mimecast-MFC-AGG-ID: vtDocgGWNvGCpNhRsIpHdg_1748351766 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-39ee4b91d1cso2026998f8f.0 for ; Tue, 27 May 2025 06:16:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748351765; x=1748956565; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dsz1aOHfUZGo1Ui2D3oIjc2p8br7ObKeotk8N29rOaI=; b=PlNjbonAPbBDMWSlpdD2pQVxAOntVvJkUJ7EKmgQJJkytCzNvt4OcuZVp/8sKzKQHK Kcg77hEu7xdgBtnj67ivnvQpq8bXowjTRyiHvmdxF2msxAR+fti27KhXxAbF+BwEZnuB JCwrwfmVdmnE6xiBwQTJoR8+TRl37KW7N4E1+8F8dY9JTocSZI9VHdT2U+xJ7M8eiX+l o0ctWoVBcM4yvK1lJkfpIC+GpNM0ecIFThVVCkvACRU0t5vX0moL8eryKQmrU/RkN2fG b/CtKRNeqCSiY1105ewr3Htp/3luN6pUgsciogXdL3nO/qpgjBqieG8q65aZDS/WM2lc wF4A== X-Gm-Message-State: AOJu0YxKoTutWwZTr4hKVym3uYbKMuE7sx179YV14D9ny7vJ2na1NiUk ZDVQRfRA8KWS9gW/HoixKtbGKuJj9lfoC2Qd5G7hdktDwoprcXUjUFjjVbtXLzcQNPQgHQ7f0Kg YBRdc55eE+HRslI4WOeR7j0Xrc4Stfxop4HYyui4r2fy5w0n7ALWAVnJOFWtWkw== X-Gm-Gg: ASbGnctaOKTh+jBkQynF14BxPmyZZk5d1B5mOp4S4XiUPTfcEbn4rymPqWs10FZ/vXV EF81gpKRWOX2Do8FqDKficWIxTgAYFUDoaTriRJXRrLeie7qqKgy4xMZNjCPrV1/3bpckWctS/q NuCsL8zQm2XBedrYIeuH0vkyKDOVaJ4AwC81CYG9XC0vnXo+v3TEmOR7kPxnLcOoZvfOuflDNqg BdLSdFnw3SiF/rUDJbaAe/MEZ5qUAP4f5R5S5ms+aS+7O9UtLCPiaz5RD9A2edCSzVGcTq0Z39e /ImsM+GUQOn9yn/U1NGu3ET0HyAryAu2eaCGsxRu/T4qLwgCgy0= X-Received: by 2002:a5d:5f55:0:b0:3a4:d685:3de7 with SMTP id ffacd0b85a97d-3a4e5e5d6d4mr719833f8f.8.1748351765604; Tue, 27 May 2025 06:16:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHTWHc8T61jgDME/M7b+3im1839rMuK5IKNIIu4x8RXhM4qXbGR31IjH2/UarSrg1MxSE3hWA== X-Received: by 2002:a5d:5f55:0:b0:3a4:d685:3de7 with SMTP id ffacd0b85a97d-3a4e5e5d6d4mr719797f8f.8.1748351765167; Tue, 27 May 2025 06:16:05 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4cc52ab88sm10863396f8f.11.2025.05.27.06.16.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 May 2025 06:16:04 -0700 (PDT) Message-ID: Date: Tue, 27 May 2025 15:16:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 29/29] packet: use buf to store iovec array To: Stefano Brivio References: <20250417165136.2688884-1-lvivier@redhat.com> <20250417165136.2688884-30-lvivier@redhat.com> <20250526162146.52d68c66@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20250526162146.52d68c66@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: kfID1NhOGDezWpU08AWhSvHrQm5k22DNkJoa8EBQxtQ_1748351766 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: XMNPHDCLB35QW3H34UGXZMENR6TVNKSL X-Message-ID-Hash: XMNPHDCLB35QW3H34UGXZMENR6TVNKSL X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 26/05/2025 16:21, Stefano Brivio wrote: > On Thu, 17 Apr 2025 18:51:36 +0200 > Laurent Vivier wrote: > >> When we use vhost-user we don't use the memory buffer >> of the pool to store the packet, so we can use it to >> store iovec array that points to the memory provided >> by vhost-user. >> >> Signed-off-by: Laurent Vivier >> --- >> packet.c | 163 +++++++++++++++++++++++++++++++++++++++++++++++++------ >> 1 file changed, 147 insertions(+), 16 deletions(-) >... >> +/** >> + * packet_iov_next_idx() - Give the the next available iovec index >> + * @p: Pointer to packet pool >> + * @idx: Index of packet descriptor in pool >> + * @func: For tracing: name of calling function >> + * @line: For tracing: caller line of function call >> + * >> + * Return: the next available iovec index >> + */ >> +static size_t packet_iov_next_idx(const struct pool *p, size_t idx, >> + const char *func, int line) >> +{ >> + size_t iov_idx, iov_cnt; >> + >> + if (idx == 0) >> + return 0; > > I'm a bit lost here. Why is 0 a special value now? See below: we use "idx - 1" > >> + >> + iov_idx = packet_iov_idx(p, idx - 1, &iov_cnt, func, line); >> + >> + return iov_idx + iov_cnt; >> +} >> + The next available iovec index for a given packet index is computed using the information from the previous packet index: We take first available iovec index after the iovecs used by the previous packet. The next available iovec index is the iovec index base of the previous packet plus all the iovecs used by the previous packet: next available iovec index = (base iovec index of previous packet) + (number of iovec used by previous packet) So, for the first packet (packet index 0), the first available iovec index is 0, we can't compute it from the previous packet because it doesn't exist (and all the iovec are free and available) Thanks, Laurent