From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Uo5PeomR; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 2AE255A0271 for ; Thu, 27 Nov 2025 10:17:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1764235069; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=svyEXT5UYX4k7sfUQ6qiPZ5wA6ZNlDAO0m8EjH+KESA=; b=Uo5PeomRi74HPaVa5mQkj/hUTnyN/XB8HO+SVYR66Vt3UQVWrsQ5BzH1BoWWLtfk+1t0Q3 ge1vaPpN/nRmMDJxZh+a/d8W+LhjvTjfvmR9tZxipKCsL61VBAbf4Hx/K8Md/o5NvgnJnu yJ77ccqi740x25kGDMo0QhRbj5tCS2E= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-192-5rJLjQP8ON6Xjs9A-hA_aA-1; Thu, 27 Nov 2025 04:17:46 -0500 X-MC-Unique: 5rJLjQP8ON6Xjs9A-hA_aA-1 X-Mimecast-MFC-AGG-ID: 5rJLjQP8ON6Xjs9A-hA_aA_1764235065 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-429cceeeb96so406169f8f.1 for ; Thu, 27 Nov 2025 01:17:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764235065; x=1764839865; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=svyEXT5UYX4k7sfUQ6qiPZ5wA6ZNlDAO0m8EjH+KESA=; b=Ejt7jFe3Ss/yCc40MEgiqBWVtmiUc44vPsPIq0VJ+c6mrNPb+KIWROgPJLKDGuUpBX aV1bo+f4TaTuxBqXDCse4pv5TvsjzVIagVuWMC8NCnrPSEu7u5vJcpRPPU4h7hCqSJAV y1ahBaTnpi6KGfykDFn1V3LMvTAhvfHLBp5gE09hFmJ/OGPM/dB4Yzx1q8qylmYoCGZb WrWy3pmMxn465SeU3PyM/pqY37O06RxfLDdKTvfkjKLjux/hLYli0KRgZDxBuwT7SI97 Q5+x/HLC+DhduHs5IxH4WN/Rezl2Sf586yZw6JKz9M/OE/9anc0r+S/WPp61lE1M8snK kf4w== X-Gm-Message-State: AOJu0Ywt3rb9fhOySv5rHW0PeuXR/AXCQjvRo17ja1mSqaqht0Um2kgi OPAGGjg61uWAM5wNETA24wiLwu8+lRrMRRI0PB6jYkvIEhllj+qSK7OslBvhHJHCrLOz4Ihn3DP l23x41QNy6nhYIquKy901mtvAZ6z5CSwtFjAVkgJQw/qlQRxa3DqkeQ== X-Gm-Gg: ASbGncsfLb8J7z0arTAOxCUYgnoVQl7IFQJGrTVvboFb9ql+jDkTCc0sAJhf54Hs21X IOztilhxK4chtQYR6u97HcpDPWSWTQh2f9dhzP560fCMfzdo9vbq8wMr5PQSfIQ39kNm5iqdiSW Q+3oxGB2cD0saDh4jTjRqeLfMEcgVBvd1sJtUgPISkzdtCjKHjig3W5MAFe1VSxcf3hs9Xg6NWm UPnbllh1RukrRobEf1eljolkvdyTR4doB5RTRgkxfJlH2Eo/WWKeag3rlDgCmp++DyjmFQyMWsO QinU3B2DSBgaD3YuGJSsvHduhYcOZIU01umqydex2e1bGSfsy5rYdWGJShrkwzCzAClzytW7v97 p/LkZBpHyYj5wUUl5y3QkPGq5q6xhkxNLOXQcQzo74uBfgugm X-Received: by 2002:a05:6000:2311:b0:429:8d0f:e92 with SMTP id ffacd0b85a97d-42cc1abe1b2mr24477839f8f.6.1764235065359; Thu, 27 Nov 2025 01:17:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcWOiOmHFAlllXxVwzEg2YkdPXCasCftoemPkEnt51EKCMFyl23jC462y2/xJONXrKaKozCA== X-Received: by 2002:a05:6000:2311:b0:429:8d0f:e92 with SMTP id ffacd0b85a97d-42cc1abe1b2mr24477804f8f.6.1764235064888; Thu, 27 Nov 2025 01:17:44 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42e1ca1a3e4sm2412919f8f.25.2025.11.27.01.17.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Nov 2025 01:17:44 -0800 (PST) Message-ID: Date: Thu, 27 Nov 2025 10:17:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] flow: Add queue pair tracking to flow management To: David Gibson References: <20251121165902.1014964-1-lvivier@redhat.com> <20251121165902.1014964-6-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ENIJdNliltq6I5qfO60hVlDLQvk97clqWPAlsrPNYGs_1764235065 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 3T3O2ZP72NVHXJ3OTTHQCNKMC4O25CTR X-Message-ID-Hash: 3T3O2ZP72NVHXJ3OTTHQCNKMC4O25CTR X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/26/25 04:41, David Gibson wrote: >> +/** >> + * flow_qp() - Get the queue pair for a flow >> + * @f: Flow to query (may be NULL) >> + * >> + * Return: queue pair number for the flow, or 0 if flow is NULL or has no >> + * valid queue pair assignment >> + */ >> +unsigned int flow_qp(const struct flow_common *f) >> +{ >> + if (f == NULL || f->qpair == FLOW_QPAIR_INVALID) > Are there any instances where you actually want to pass a NULL flow to > this? > > If you're going to return 0 anyway, why not just set f->qpair to 0 by > default, rather than using FLOW_QPAIR_INVALID? > In fact, in the multithread part I need to know if the queue pair has been set or not. I agree that we should avoid this if possible because it takes one slot in the array. And as we have 16 qpairs we must use 5 bit (we need 17 values) rather than 4 bit. I'm reworking the multithread part, I will see if I can remove this. Thanks, Laurent