From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=I7/QjHm8; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id E74385A0619 for ; Wed, 22 Oct 2025 08:49:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761115782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=0MVPq1TqU0S2JQLM0gkJEV+Nh6JwsEVOkQRU3NqA2Is=; b=I7/QjHm8SN/nDjd9QjvSbTjdUMJ23BJYHbPmzcmwXo6ivtSLnsEg9ya7rLyjymtmfpfhif 7nLzNIxAxwoV3oQ4XWT3+adq1rUFLAbp2n5oG+nKBXhZm3Hm2BnItWMVNEvHiEKOtP6Tqw RsK8NEExWJjOHUjy/ZbjLObgu/ll6NI= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-471-fh3A8wBKOt-Jf6WEKWv25Q-1; Wed, 22 Oct 2025 02:49:41 -0400 X-MC-Unique: fh3A8wBKOt-Jf6WEKWv25Q-1 X-Mimecast-MFC-AGG-ID: fh3A8wBKOt-Jf6WEKWv25Q_1761115780 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47106a388cfso29300695e9.0 for ; Tue, 21 Oct 2025 23:49:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761115780; x=1761720580; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0MVPq1TqU0S2JQLM0gkJEV+Nh6JwsEVOkQRU3NqA2Is=; b=LBrbvS4Yb/1LjQ08GwahVqaMq5t7U0oCHr6QsORzk7XhKOiXSAfQifMNyaUswRXx6o gravo4kpp+74NrKP5wPF8pP1J7OQ8UATqMdrpfctgxnLyh/TkmHiIH0RIkR0I4Z2i/kh ko1JwCJ9+ADDAB1ZZ8mUl6jLpJ7HMysMNw2D75q+BpRGOkjN+ozPhAElzSR8bugL9JCK MlSr3rGlf/1TzXalO2hC1aWHo57jOddusEBbntBYWU9Aou/34G7LI2Pkhs5TPtl7XSFD KTdg4F6sdPBtEQ5JJWNebN/ledz5dhjtIaLu8/JkT4RXjzhFjAPnfmnWWt251f7e9U/R KFYg== X-Gm-Message-State: AOJu0Yxf54wkyvmgUs81gARKV9uLLROVxJQkSKIqGdZJHMESmeQEeGT0 GZIm0P9dqBWey0FFYOFdCw+skTerd8V1IhwjNThlTL0pHznPhzaG9CGmmJC+UEx6SZQmCH5t3Ds xysH+sw7tg3Fefm8acI4h4jZAEKZaZSjG3PtHtYWAKW+bxkpdy28vllJpS3fG/g== X-Gm-Gg: ASbGncs/w0XbNeT8GKXZcrxySnFUeUki6GskTdfH3wYUM/tkoK+qO0ytn0H0W8cATbp mW5w59CWIJFNkxM3X9ziElq1Vl/jbKBlAJY/EkSDwNH5aCUddKPPSDq32mXfZ7PJkm3yAJawnEz tc9lyJ7qPEJ348JrI40V2h2zo6EBHds/SCLbAM8xBE1Bwe5bInJiiOmuPV0iP/vCI7Vhc8hQNVq ltkAzDa3H3T4px4bayUy1KTKcdEJXL0vZw0gPGkfE6d8h5nFyMHJ35WpM+5JAcmyN26DfJL6x49 HDAlaUL0Nl05W7oC245axO2CDbpHJcLBwtiMnjWA8fOKK0nCTa6hqI/N6nQ+iDWM28ccAM4hj3w CXKfZKs/kO9sA8BKBYKfVXpMQxcCnhi525muqNQ== X-Received: by 2002:a05:600c:1d9b:b0:471:7a:791a with SMTP id 5b1f17b1804b1-4711787672dmr147274575e9.7.1761115780123; Tue, 21 Oct 2025 23:49:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEjbzteHin9UIX63Eg0jqB/qGMPsGvlWgfDYIEcd6HPMNBJFE4PNr0GBXxLzlOs7db99QQRtg== X-Received: by 2002:a05:600c:1d9b:b0:471:7a:791a with SMTP id 5b1f17b1804b1-4711787672dmr147274315e9.7.1761115779350; Tue, 21 Oct 2025 23:49:39 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-475c428c62fsm29147795e9.8.2025.10.21.23.49.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 23:49:38 -0700 (PDT) Message-ID: Date: Wed, 22 Oct 2025 08:49:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 7/7] passt: Move main event loop processing into passt_worker() To: David Gibson References: <20251017103129.229412-1-lvivier@redhat.com> <20251017103129.229412-8-lvivier@redhat.com> <997ad29f-4c62-495b-b4bf-7405dbc55537@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: nG7eO66f_6PLO89YyA5PVXw9kt_w98F1mEfvQqu7Mpg_1761115780 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: DTMLHELZIPZA3QN3I2OKILUVWBDKCOIZ X-Message-ID-Hash: DTMLHELZIPZA3QN3I2OKILUVWBDKCOIZ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 22/10/2025 02:53, David Gibson wrote: > On Tue, Oct 21, 2025 at 10:00:58AM +0200, Laurent Vivier wrote: >> On 20/10/2025 03:43, David Gibson wrote: >>> On Fri, Oct 17, 2025 at 12:31:29PM +0200, Laurent Vivier wrote: >>>> Extract the epoll event processing logic from main() into a separate >>>> passt_worker() function. This refactoring prepares the code for future >>>> threading support where passt_worker() will be called as a worker thread >>>> callback. >>>> >>>> The new function handles: >>>> - Processing epoll events and dispatching to protocol handlers >>>> - Event statistics tracking and printing >>>> - Post-handler periodic tasks (timers, deferred work) >>>> - Migration handling >>>> >>>> No functional changes, purely a code restructuring. >>>> >>>> Signed-off-by: Laurent Vivier >>> >>> Looks good as far as it goes, and I've though often in the past that >>> it would make more sense for the "engine" to go in its own function. >>> >>> Wondering if it would make more sense to include the epoll_wait() >>> itself and the loop in this function, rather than leaving that >>> outside. >>> >> >> When I introduce the multithreading and the multiqueue, as the thread is >> driven by the epollfd, the events are managed by the multiqueue part and the >> epollfd by the multithread part. >> >> The "threading" worker is: >> >> static void *threading_worker(void *opaque) >> { >> struct threading_context *tc = opaque; >> >> while (true) { >> struct epoll_event events[NUM_EPOLL_EVENTS]; >> int nfds; >> >> nfds = epoll_wait(tc->epollfd, events, NUM_EPOLL_EVENTS, >> TIMER_INTERVAL); >> if (nfds == -1 && errno != EINTR) >> die_perror("epoll_wait() failed"); >> >> tc->worker(tc->opaque, nfds, events); > > IIUC the point here is that eventually the epoll_wait() will be > common, but the worker might be different for different threads. Is > that correct? > Yes, we can have the passt_worker() for all threads, but we can also have a specific worker for passt main (with netlink, listen, ...), a specific for TX vhost-user (with kickfd), and another one for RX (with all the ICMP, UDP, TCP sockets). Thanks, Laurent