From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=cgt4ff3W; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id DA7135A026F for ; Tue, 21 Oct 2025 13:52:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761047552; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=KXQkQMHlPP2RObzXKGnjQ29nCNIU+fqg7TUny36YcYQ=; b=cgt4ff3WCjSOuD2QVJPoNn8DpsAqu4h7npdgjErYJmKHMl2OZVnU3mseIpEbd81aFrtyuz l7FB+C3R34Jb+1mbgyhFjJvVXk72qpnZa8pLdBP96jqO+IjCLKW1WFtcRHXtksLUL+IcJs vBIpT/E4eU2qEqAtRoovpjGU5wlKszw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-487-shd34iR3P5SrIW4cmceayg-1; Tue, 21 Oct 2025 07:52:29 -0400 X-MC-Unique: shd34iR3P5SrIW4cmceayg-1 X-Mimecast-MFC-AGG-ID: shd34iR3P5SrIW4cmceayg_1761047548 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4710c04a403so58084425e9.3 for ; Tue, 21 Oct 2025 04:52:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761047547; x=1761652347; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KXQkQMHlPP2RObzXKGnjQ29nCNIU+fqg7TUny36YcYQ=; b=oLauX9ZOkEaXlsFawZXsQ1+rd8NPdNdtsYsml1f7sJEpwaMgsvUqYqnRaPZEI8QoX+ adgKbKQJa6gX+jx4VBDKf7hnlQyoaaZM2Bk0w+sfz0pDrGb+6FRw2IDLQ4DBG9lUMXSk XtrxETGvwR56RaZ5x4jNMPA0GzHaoq4ipYhn6WgFuJ/v7zSCRsDV4VSU2LcbZvsscrFK 1FEoGmhnnnJGIuzY6I6JTmve6Np/32/37OsVv01/QOL9p8F2sxbuFgm38trhbSOaBPzJ YZcnc5mVIwu9Tt2hsN7gNpUfr1pIm8fyv9RVWa8ht5djDMWod5FcYpyfzLCzscTm2lrQ dVxQ== X-Gm-Message-State: AOJu0YyuJXyQQzJZDNxHfrMSiQFnqLHHlaK3DyB1CatyPkTTtev0yEUo /UpFgAr1gNYvjBcJfQlQqXH2XFTH8wJMf5dJNynlm90PnwDfBX41RHonFv3uFV/ZeQUgkkT/3Cv 3+xsJkjVShT6r8XrRJxmwfjWYQDUpZA/9jNvlqviTTZHDVquyLTn9JbhyWDlbZQ== X-Gm-Gg: ASbGncsWh2Xl6LyjJpW1Uxc9empFQi3/8TXOVrFteKxQvwlIXD43rPYav3Xd9eIcSM2 4awNNC1mnV8luaSQ33q1GPP7rD71XhZ9ZAK5bqg2XnCc3fI7+BlWJmbwejlEGdFhn6v2XNyh5Mv T2wZzfDL1CCMK9WY7KfweTrdI0jvQM04xBvNbOLPbniCg7A4upk80OQFZjOBl+M9h0atZGfLX9S dseMpqCYcD+hZF2ZRggvpTO053GxlL5fhYIXIZWBfL5Fxz4tXm++ASn+GLhZ9W86uXtBw+pPasH +RCG5t1kbtqItS5CVLyifKvqay5Ge4fMYWJTC8yZr1C8qJvrsb0JSl/aQSBJZr8BuzPhQEpc1u/ QozvPGcikxyNYU9u3OO0Lr1oN3MYG27uGAght4A== X-Received: by 2002:a05:600c:3b83:b0:46e:3d41:6001 with SMTP id 5b1f17b1804b1-47117925171mr169161855e9.34.1761047547592; Tue, 21 Oct 2025 04:52:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFRIeZp8jHHuAqvjTO71R268p9Z0yNdNlRdos47kqxBGGDBUWBKUHHHyJQxgheEj8St+V7Osw== X-Received: by 2002:a05:600c:3b83:b0:46e:3d41:6001 with SMTP id 5b1f17b1804b1-47117925171mr169161405e9.34.1761047547016; Tue, 21 Oct 2025 04:52:27 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47494b22536sm16413855e9.5.2025.10.21.04.52.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Oct 2025 04:52:26 -0700 (PDT) Message-ID: Date: Tue, 21 Oct 2025 13:52:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] epoll_ctl: Extract epoll operations To: David Gibson References: <20251017103129.229412-1-lvivier@redhat.com> <20251017103129.229412-3-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: MBb1qG_jInhVkyC-pZ3EfTvye8R9EAf22aroDVi8Mtk_1761047548 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: TKLLR4YBEEXV7IYSYRGM5HRBCVKCT2UA X-Message-ID-Hash: TKLLR4YBEEXV7IYSYRGM5HRBCVKCT2UA X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 20/10/2025 03:20, David Gibson wrote: > On Fri, Oct 17, 2025 at 12:31:24PM +0200, Laurent Vivier wrote: >> Centralize epoll_add() and epoll_del() helper functions into new >> epoll_ctl.c/h files. >> >> This also moves the union epoll_ref definition from passt.h to >> epoll_ctl.h where it's more logically placed. >> >> The new epoll_add() helper simplifies adding file descriptors to epoll >> by taking an epoll_ref and events, handling error reporting >> consistently across all call sites. >> >> Signed-off-by: Laurent Vivier > > Concept looks good, some minor details in execution. > >> --- >> Makefile | 22 +++++++++++----------- >> epoll_ctl.c | 45 +++++++++++++++++++++++++++++++++++++++++++++ >> epoll_ctl.h | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> icmp.c | 4 +--- >> passt.c | 2 +- >> passt.h | 34 ---------------------------------- >> pasta.c | 7 +++---- >> repair.c | 14 +++++--------- >> tap.c | 13 ++++--------- >> tcp.c | 2 +- >> tcp_splice.c | 2 +- >> udp.c | 2 +- >> udp_flow.c | 1 + >> util.c | 22 +++------------------- >> util.h | 4 +++- >> vhost_user.c | 8 ++------ >> vu_common.c | 2 +- >> 17 files changed, 134 insertions(+), 101 deletions(-) >> create mode 100644 epoll_ctl.c >> create mode 100644 epoll_ctl.h ... >> @@ -1327,14 +1327,12 @@ static void tap_backend_show_hints(struct ctx *c) >> static void tap_sock_unix_init(const struct ctx *c) >> { >> union epoll_ref ref = { .type = EPOLL_TYPE_TAP_LISTEN }; >> - struct epoll_event ev = { 0 }; >> >> listen(c->fd_tap_listen, 0); >> >> ref.fd = c->fd_tap_listen; >> - ev.events = EPOLLIN | EPOLLET; >> - ev.data.u64 = ref.u64; >> - epoll_ctl(c->epollfd, EPOLL_CTL_ADD, c->fd_tap_listen, &ev); >> + >> + epoll_add(c->epollfd, EPOLLIN | EPOLLET, &ref); > > Preexisting, but we should probably check for errors here. > To do what? die() ? err() to report the place where the error happens? Thanks, Laurent