public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
blob e5a78d0792317eb5577810378591ac3c746ca878 3913 bytes (raw)

  1
  2
  3
  4
  5
  6
  7
  8
  9
 10
 11
 12
 13
 14
 15
 16
 17
 18
 19
 20
 21
 22
 23
 24
 25
 26
 27
 28
 29
 30
 31
 32
 33
 34
 35
 36
 37
 38
 39
 40
 41
 42
 43
 44
 45
 46
 47
 48
 49
 50
 51
 52
 53
 54
 55
 56
 57
 58
 59
 60
 61
 62
 63
 64
 65
 66
 67
 68
 69
 70
 71
 72
 73
 74
 75
 76
 77
 78
 79
 80
 81
 82
 83
 84
 85
 86
 87
 88
 89
 90
 91
 92
 93
 94
 95
 96
 97
 98
 99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
 
// SPDX-License-Identifier: GPL-2.0-or-later

/* PASST - Plug A Simple Socket Transport
 *  for qemu/UNIX domain socket mode
 *
 * PASTA - Pack A Subtle Tap Abstraction
 *  for network namespace/tap device mode
 *
 * packet.c - Packet abstraction: add packets to pool, flush, get packet data
 *
 * Copyright (c) 2020-2021 Red Hat GmbH
 * Author: Stefano Brivio <sbrivio@redhat.com>
 */

#include <limits.h>
#include <stddef.h>
#include <stdint.h>

#include <netinet/ip6.h>

#include "packet.h"
#include "util.h"
#include "log.h"

/**
 * packet_check_range() - Check if a packet memory range is valid
 * @p:		Packet pool
 * @offset:	Offset of data range in packet descriptor
 * @len:	Length of desired data range
 * @start:	Start of the packet descriptor
 * @func:	For tracing: name of calling function
 * @line:	For tracing: caller line of function call
 *
 * Return: 0 if the range is valid, -1 otherwise
 */
static int packet_check_range(const struct pool *p, size_t offset, size_t len,
			      const char *start, const char *func, int line)
{
	if (p->buf_size == 0) {
		int ret;

		ret = vu_packet_check_range((void *)p->buf, offset, len, start);

		if (ret == -1)
			trace("cannot find region, %s:%i", func, line);

		return ret;
	}

	if (start < p->buf) {
		trace("packet start %p before buffer start %p, "
		      "%s:%i", (void *)start, (void *)p->buf, func, line);
		return -1;
	}

	if (start + len + offset > p->buf + p->buf_size) {
		trace("packet offset plus length %lu from size %lu, "
		      "%s:%i", start - p->buf + len + offset,
		      p->buf_size, func, line);
		return -1;
	}

	return 0;
}
/**
 * packet_add_do() - Add data as packet descriptor to given pool
 * @p:		Existing pool
 * @len:	Length of new descriptor
 * @start:	Start of data
 * @func:	For tracing: name of calling function, NULL means no trace()
 * @line:	For tracing: caller line of function call
 */
void packet_add_do(struct pool *p, size_t len, const char *start,
		   const char *func, int line)
{
	size_t idx = p->count;

	if (idx >= p->size) {
		trace("add packet index %zu to pool with size %zu, %s:%i",
		      idx, p->size, func, line);
		return;
	}

	if (packet_check_range(p, 0, len, start, func, line))
		return;

	if (len > UINT16_MAX) {
		trace("add packet length %zu, %s:%i", len, func, line);
		return;
	}

	p->pkt[idx].iov_base = (void *)start;
	p->pkt[idx].iov_len = len;

	p->count++;
}

/**
 * packet_get_do() - Get data range from packet descriptor from given pool
 * @p:		Packet pool
 * @idx:	Index of packet descriptor in pool
 * @offset:	Offset of data range in packet descriptor
 * @len:	Length of desired data range
 * @left:	Length of available data after range, set on return, can be NULL
 * @func:	For tracing: name of calling function, NULL means no trace()
 * @line:	For tracing: caller line of function call
 *
 * Return: pointer to start of data range, NULL on invalid range or descriptor
 */
void *packet_get_do(const struct pool *p, size_t idx, size_t offset,
		    size_t len, size_t *left, const char *func, int line)
{
	if (idx >= p->size || idx >= p->count) {
		if (func) {
			trace("packet %zu from pool size: %zu, count: %zu, "
			      "%s:%i", idx, p->size, p->count, func, line);
		}
		return NULL;
	}

	if (len > UINT16_MAX) {
		if (func) {
			trace("packet data length %zu, %s:%i",
			      len, func, line);
		}
		return NULL;
	}

	if (len + offset > p->pkt[idx].iov_len) {
		if (func) {
			trace("data length %zu, offset %zu from length %zu, "
			      "%s:%i", len, offset, p->pkt[idx].iov_len,
			      func, line);
		}
		return NULL;
	}

	if (packet_check_range(p, offset, len, p->pkt[idx].iov_base,
			       func, line))
		return NULL;

	if (left)
		*left = p->pkt[idx].iov_len - offset - len;

	return (char *)p->pkt[idx].iov_base + offset;
}

/**
 * pool_flush() - Flush a packet pool
 * @p:		Pointer to packet pool
 */
void pool_flush(struct pool *p)
{
	p->count = 0;
}

debug log:

solving e5a78d0 ...
found e5a78d0 in https://archives.passt.top/passt-dev/20241009102353.59aa73b7@elisabeth/ ||
	https://archives.passt.top/passt-dev/20241007144054.41868-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241009090716.691361-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241104084004.3544294-8-david@gibson.dropbear.id.au/ ||
	https://archives.passt.top/passt-dev/20241113080411.476646-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241010122903.1188992-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241108103733.3554357-8-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20240913162036.3635783-5-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20240906160455.2088854-5-lvivier@redhat.com/
found 3748996 in https://archives.passt.top/passt-dev/20240815155024.827956-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241113080411.476646-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241108103733.3554357-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241010122903.1188992-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241009090716.691361-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241007144054.41868-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20240913162036.3635783-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20240906160455.2088854-2-lvivier@redhat.com/ ||
	https://archives.passt.top/passt-dev/20241104084004.3544294-2-david@gibson.dropbear.id.au/
found ccfc84607709 in https://passt.top/passt
preparing index
index prepared:
100644 ccfc84607709e49507c987e3598a1c6c41e81084	packet.c

applying [1/2] https://archives.passt.top/passt-dev/20240815155024.827956-2-lvivier@redhat.com/
diff --git a/packet.c b/packet.c
index ccfc84607709..37489961a37e 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20241113080411.476646-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20241108103733.3554357-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20241010122903.1188992-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20241009090716.691361-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20241007144054.41868-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20240913162036.3635783-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20240906160455.2088854-2-lvivier@redhat.com/ for 37489961a37e
skipping https://archives.passt.top/passt-dev/20241104084004.3544294-2-david@gibson.dropbear.id.au/ for 37489961a37e
index at:
100644 37489961a37eb4bb567640a7d6c398a9e31bf2ae	packet.c

applying [2/2] https://archives.passt.top/passt-dev/20241009102353.59aa73b7@elisabeth/
diff --git a/packet.c b/packet.c
index 3748996..e5a78d0 100644

Checking patch packet.c...
Applied patch packet.c cleanly.

skipping https://archives.passt.top/passt-dev/20241007144054.41868-8-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20241009090716.691361-8-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20241104084004.3544294-8-david@gibson.dropbear.id.au/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20241113080411.476646-8-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20241010122903.1188992-8-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20241108103733.3554357-8-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20240913162036.3635783-5-lvivier@redhat.com/ for e5a78d0
skipping https://archives.passt.top/passt-dev/20240906160455.2088854-5-lvivier@redhat.com/ for e5a78d0
index at:
100644 e5a78d0792317eb5577810378591ac3c746ca878	packet.c

Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).