From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 3FE225A004E for ; Fri, 05 Jul 2024 17:06:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1720191977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=o/UuUmykiPhpV3sqzAxs7JRDWFgMy0BYgROjBzDKLHY=; b=Fw4JKA12+o4Z8MOEGnecmaOkHac2iF6tOfBxx7L6AjHFJyW/gorf3X/+i1ENsRjhW65lqs pF9dBiRWoOdIRI8WAfIfuz/j9AoPNwEWWA8RoPTR+8nY8pdWDfx5kOGwEq/0Xb9NNqIHqp fvVTsPChZplmRG3GlnWA24g+BAi1H6Q= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-Xp61reTvPECDuH-cL4AAyg-1; Fri, 05 Jul 2024 11:06:15 -0400 X-MC-Unique: Xp61reTvPECDuH-cL4AAyg-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-79d56e0b68cso225599985a.1 for ; Fri, 05 Jul 2024 08:06:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1720191975; x=1720796775; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o/UuUmykiPhpV3sqzAxs7JRDWFgMy0BYgROjBzDKLHY=; b=fGDfaE6SYEKmsiBTn8GsoDfEGbaoQHU0tK77JJoYlsKxQQWCfRy6gwUaavecpYoRd8 yujgLMM7chIK1fyO42rpLpTbuvgg1THP0cYzAWdk+zXZn3CS+4bWNnq3oObAlX553qEi prymw5z16+jEQuWR6Bbe4wqzMt4z0MkawTJr69yxoQVE2jlNJ+8Mhb3+BRJ+O7VVjNEp gO5pLRlbKCqEtI+sKmB6+ds72CNqCff3NjWaxw0tf6ewQQbxeccOk3IxZwnnOydJL/Df Z8Gid3vpNo50hg3fDH5wT2NkXvXXn6J0Tk/x43lO9y7PCayIgRmAixoCHPj7Sk1cA4W3 m/TQ== X-Gm-Message-State: AOJu0YwrPXOT1Y8LvB4DQmX7soFSWYjOuYp0pg/Sa0VKnMOWQWGZci0q 8bQbKa497OnaTmfPRtH7HfifJeIwuWgVnxYEi4oDpppDVwAXgc8ymKEGDUMx2uRNgVdHgR7sOjR 7UoYRbf8z/zRG0jMhp676IPCo3ZdSSk0zqHaptPN24qWvoMLMsjU+jbUTXQ== X-Received: by 2002:a05:620a:841:b0:79d:6266:33cc with SMTP id af79cd13be357-79eee1c75camr536770885a.2.1720191975153; Fri, 05 Jul 2024 08:06:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhfNbbzNrLiNjrTjG6Gny2BewVn46Z7996nA+2yUs4QWYwT/rtJ2Y0Btgs/PWfnzGF8ZQCrQ== X-Received: by 2002:a05:620a:841:b0:79d:6266:33cc with SMTP id af79cd13be357-79eee1c75camr536767085a.2.1720191974678; Fri, 05 Jul 2024 08:06:14 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:8e19:3414:44f0:befd? ([2a01:e0a:e10:ef90:8e19:3414:44f0:befd]) by smtp.gmail.com with ESMTPSA id af79cd13be357-79d692f0aafsm783675285a.77.2024.07.05.08.06.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Jul 2024 08:06:14 -0700 (PDT) Message-ID: Date: Fri, 5 Jul 2024 17:06:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/5] vhost-user: introduce virtio API To: David Gibson References: <20240621145640.1914287-1-lvivier@redhat.com> <20240621145640.1914287-3-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: PPYEUZZJEKFBGYNVLJ4QG7VWXDWN6P7C X-Message-ID-Hash: PPYEUZZJEKFBGYNVLJ4QG7VWXDWN6P7C X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 24/06/2024 04:56, David Gibson wrote: > On Fri, Jun 21, 2024 at 04:56:37PM +0200, Laurent Vivier wrote: >> Add virtio.c and virtio.h that define the functions needed >> to manage virtqueues. >> >> Signed-off-by: Laurent Vivier >> --- >> Makefile | 4 +- >> util.h | 11 ++ >> virtio.c | 446 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> virtio.h | 123 +++++++++++++++ >> 4 files changed, 582 insertions(+), 2 deletions(-) >> create mode 100644 virtio.c >> create mode 100644 virtio.h >> ... >> diff --git a/virtio.c b/virtio.c >> new file mode 100644 >> index 000000000000..50ec8b5119ed >> --- /dev/null >> +++ b/virtio.c >> @@ -0,0 +1,446 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> + > > Needs an actual "Copyright" invocation as well as the SPDX stuff. > Which, yes, is a bit fiddly given that it's largely taken from qemu. I'm updating that > >> +/* some parts copied from QEMU subprojects/libvhost-user/libvhost-user.c */ > > So, there are obvious stylistic differences between this and the rest > of the passt code for that reason. As I think I said on an earlier > draft, I think we need to go fully one way or the other: either a) > rewrite this entirely in passt style or b) change the whole thing so > little that it's trivial to pull in new versions from qemu. This > seems to be somewhere in the middle. As the orignal code in QEMU don't change a lot I chose to update it to match passt coding style. I'm adding the function headers. What else is missing? ... >> diff --git a/virtio.h b/virtio.h >> new file mode 100644 >> index 000000000000..61398bb432bc >> --- /dev/null >> +++ b/virtio.h >> @@ -0,0 +1,123 @@ >> +// SPDX-License-Identifier: GPL-2.0-or-later >> +// >> +/* come parts copied from QEMU subprojects/libvhost-user/libvhost-user.h */ >> + >> +#ifndef VIRTIO_H >> +#define VIRTIO_H >> + >> +#include >> +#include >> + >> +#define VIRTQUEUE_MAX_SIZE 1024 >> + >> +#define vu_panic(vdev, ...) \ >> + do { \ >> + (vdev)->broken = true; \ >> + err( __VA_ARGS__ ); \ > > Wouldn't it be simpler to just use die() in place of vu_panic(). This > is trying to keep the program running even if the vu device is broken, > but if our channel to the guest is broken, I don't think passt is > really worth saving. > I agree. Thanks, Laurent