From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jBp3qW9o; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 22BB65A0265 for ; Tue, 26 May 2026 10:56:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779785765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dv6h9wfUY1MlZDi2i5wt3A/8SAgMR4Z2V2W7aCBoA3s=; b=jBp3qW9o+/NQrsfO5aczcs7eKpYhePqEQWmTy5/Pkx54h0DS//bHkxXQS1+T3GVFiP2X6g TaACErnZwTI+GJQgOj8PzwZLNtifUJNT5frUC33z4OT6t5agWt62DlwteZxfoVi4PIjLMX 0V7B9w+9nW8QY9UcfRpH3BJ3xG1iUGE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-X_wB8OG4Ol6GuecOrkrfwQ-1; Tue, 26 May 2026 04:56:03 -0400 X-MC-Unique: X_wB8OG4Ol6GuecOrkrfwQ-1 X-Mimecast-MFC-AGG-ID: X_wB8OG4Ol6GuecOrkrfwQ_1779785762 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-49043386b3fso35767735e9.3 for ; Tue, 26 May 2026 01:56:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779785762; x=1780390562; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Dv6h9wfUY1MlZDi2i5wt3A/8SAgMR4Z2V2W7aCBoA3s=; b=c4LugqvGXYBhZxfHr9e/UuoFiTyj0NequR2OGEN+VIxexNduSGwannBizCS0fZhYlF dkhQlV8tuSMdWUFM5ghLYI9VKZ8/d4pSL8vxYbQDLC2C8AW8yyRsoAxcBPHYmNKp9BMT d29Fdx8QDRyjZfTqACaljpKFVvcjoTY6AW0TiIXK6A2WCTAOh6UF0nA6MvFoq2+p7uHc T7XfxXZMK8sP2Q1EmgIYTZPUjzrh21+xZ59SqCcDFcr9n4ymI12/wyb1voMFsx5Y+Ngm 2HvyKjKy7fW0ve06XaY311Y5+ibeXescNGNIn+XmNwTA7IB0y1jmJYvMvIHM4lwaMB2l C6Wg== X-Gm-Message-State: AOJu0YxaZiSpUqCbukEc9GyUCWZiNYK9TMT9UbukhkQkdxduRLhWIvXE aRauenkSv6yDbymuF1Idsf/MdBCsOKxWojhzrlS0XJIjMij/FgzRUvCs341qIGOSgRFQOYQgKWq /fLVwxdv/iyjjOgOaUoJewPeUiXoRX+cYbKHgyWwZiTx0Zd8a7BjRkw== X-Gm-Gg: Acq92OGgXQ1v0rxkRKFPOvgcskYZRinVGrpdiB562nID5urjJfpanNWDFft7HLttoWX ErH3+xjlSL0zn1p5qTIPVnlUN269GPN+uHMbzI/4DpltYIY4lSQRcglwC5Y+Gdf3ReVIlyNFMaH r7SHLLjMgG/O1AOTapXTyZeRsyBKKZCJceAIYLGGkEpaLNeY6MUFGX5Xf7s9zEEFz2EWdTbl+4D XjDLwPARlFkeIBYwlEI01Za1snlS4cVH8WVDgVfYkQ1ZSg1X92e3lFYzS1cLLGFYZzwbbO4CV0M C+WUNzDUlBsAjwMMwWKHZMPJDxbxNu+OgiXgF+LHhsp7HllbRkHRpcChbucJ2YCo/UhIo7brM6S P2dIQFkAaJGzyvoaurwKw/TQ0nFmIivXHpUU4rYEJ/FhL15Al89enOa0= X-Received: by 2002:a05:600c:8681:b0:490:778:4fe8 with SMTP id 5b1f17b1804b1-490428ce8c7mr205660355e9.25.1779785762121; Tue, 26 May 2026 01:56:02 -0700 (PDT) X-Received: by 2002:a05:600c:8681:b0:490:778:4fe8 with SMTP id 5b1f17b1804b1-490428ce8c7mr205660075e9.25.1779785761777; Tue, 26 May 2026 01:56:01 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490454dedd9sm280050675e9.6.2026.05.26.01.56.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 01:56:01 -0700 (PDT) Message-ID: Date: Tue, 26 May 2026 10:56:00 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 1/4] tcp: Encode checksum computation flags in a single parameter To: Stefano Brivio References: <20260520151010.496286-1-lvivier@redhat.com> <20260520151010.496286-2-lvivier@redhat.com> <20260526103758.34941683@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260526103758.34941683@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: xvYp2azdNAecsuPtyI-6UoE6dB7R4mxWCggfDKUyQUg_1779785762 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: RBHOGHRAAJNACEGKZLZKV6R27ZJP3QXW X-Message-ID-Hash: RBHOGHRAAJNACEGKZLZKV6R27ZJP3QXW X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top, David Gibson , Jon Maloy X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/26/26 10:37, Stefano Brivio wrote: > On Wed, 20 May 2026 17:10:07 +0200 > Laurent Vivier wrote: > >> tcp_fill_headers() takes a pointer to a previously computed IPv4 header >> checksum to avoid recalculating it when the payload length doesn't >> change, and a separate bool to skip TCP checksum computation. >> >> Replace both parameters with a single uint32_t csum_flags that encodes: >> - IP4_CSUM (bit 31): compute IPv4 header checksum from scratch >> - TCP_CSUM (bit 30): compute TCP checksum >> - IP4_CMASK (low 16 bits): cached IPv4 header checksum value > > Have you considered something like: > > struct csum_state { > bool compute_tcp; > bool compute_ip; > uint16_t computed_ip; > }; > > ? I think the related documentation would look simpler and it should > also be more robust to future changes. > > Not worth a respin though, if it looks like a good idea I guess it could > be done as a follow-up. > Yes, I think it's a good idea. It looks cleaner. Thanks, Laurent