From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=XjYZbmYl; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 115B65A0265 for ; Mon, 04 May 2026 11:59:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1777888766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3FBiCJUK9BcRTnSbq6dNDMvtyLJ1oXDwywwdtvNrfL0=; b=XjYZbmYlTu77PbB6JADElZeGCG8gbGHb2sraPoUZib1CzFOjfvDy0N85v7cRINaWg0ikVW pGCO3t1oK4+uOZE6ji8LACnnYSb22dnDovUyfDONe/2p+M4HDvf1bBG5kUJHY6/c1YXOtt zVkVMc7uoDCOoXdyCrLaskP78e8puCo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-79-tXKKSinCNvCShUw9OuCsGQ-1; Mon, 04 May 2026 05:59:25 -0400 X-MC-Unique: tXKKSinCNvCShUw9OuCsGQ-1 X-Mimecast-MFC-AGG-ID: tXKKSinCNvCShUw9OuCsGQ_1777888765 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48a588ff84eso32223435e9.1 for ; Mon, 04 May 2026 02:59:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777888764; x=1778493564; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3FBiCJUK9BcRTnSbq6dNDMvtyLJ1oXDwywwdtvNrfL0=; b=H5VfGbw2Glts7q9yBWwanY4GpkXPR2Rqn02E6dTxW8Iz4S44OMT5Edd93bUYBTDrTi NiQj8d5uEdcLWVBJ0aiwtjPha2ErZn/MDCG6gcRV9PGtKN8Z43s/Kcza0tOAxjONH09y JKHo8Aumh6qipoVW7xyVjnidWWPhvTPf65Fq20bX8AR7xkRg6gu7Gx+4/BXgnbQmn2c6 2KsXhdQ684qoo7HUqJ+++I14qlcFrmvTyejyQhE5ExcfbKpVQKcKMHQoqMeC+XuOBU9B 39fUhaJLE89zOkuh1H2nY4zxVm5N8XLFn5xbUHitxgxQpElEDZjM1Whfnjqhzh+11eAu XrVw== X-Forwarded-Encrypted: i=1; AFNElJ8gavWVOmGuWw+v9du8/Y1xCINz0k42DuyX042cESlhAhZ+KufNEESmeWxUCg7UYTx7EVix9Xm8HGc=@passt.top X-Gm-Message-State: AOJu0YxZSGDLQ66gsjIZNL+6pBqN1NoGXlrDku/8TtfmDkVPetyu17gG R0DAIXazQ70ncY+Bp3F80AR5/7lAzDL79psOLWM77nkM+NmvxOP5o6tlPGmHjMtW3gS3ZADYrxZ MjhOlj5tHfGl6eJ41Cw0b2Sh+yGgcQDPN1iIGp9ipsBQI79qxbcQEZJuH83BRkw== X-Gm-Gg: AeBDieuMWtlSkMdK9oGqWllOYNMHZqIswUsODA1zYWmQepIyATgG7OIbmlaX67BSJBw 8VMsMmg6Xr10BJO8r+cqInctvLQigAKnDRvjc0ae6tZPFQbddU1jiHUtDqA0xXXTaDh3QwgH4Ti MBiqUceBgw0fhf/KDOhR704zO9hQyjCrlptOyXlx3YBchZfFj4aKHYDVjTMobUbsyNPeEn1L8wD WOmEttCSqPeKJUVxYSxS1D6Mb9SDkUyyYNLfH8Lgp3V9ISotQoYzKiErZd7ZRWa+DberQr54sf4 3xEYZlonTww9F6ZFo1A0rGRJFJuo6kb986SShANVqGZw6rFohVR8zAI4pHUHSsHJO6ToJUwZbiW T2CVLobtNHjuXL9rdivtIW/VnK+7y53ll9bx8o7o/CifjEc249XjEsu9P3tJ3tVrhQA== X-Received: by 2002:a05:600c:4e11:b0:48a:9562:7a30 with SMTP id 5b1f17b1804b1-48a98670ea9mr146924665e9.24.1777888764517; Mon, 04 May 2026 02:59:24 -0700 (PDT) X-Received: by 2002:a05:600c:4e11:b0:48a:9562:7a30 with SMTP id 5b1f17b1804b1-48a98670ea9mr146924345e9.24.1777888764100; Mon, 04 May 2026 02:59:24 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a8fea5f21sm76276165e9.8.2026.05.04.02.59.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 02:59:23 -0700 (PDT) Message-ID: Date: Mon, 4 May 2026 11:59:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 07/18] fwd_rule: Fix some format specifiers To: Stefano Brivio , passt-dev@passt.top References: <20260503215601.823029-1-sbrivio@redhat.com> <20260503215601.823029-8-sbrivio@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260503215601.823029-8-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w5-Sfi5yBC61Ba8v24_Jzej2-8uXZc-R8_UKSQZ4OZo_1777888765 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: JFLPU2KRRK7LXVWM7JHGPPVG4YMR3EN3 X-Message-ID-Hash: JFLPU2KRRK7LXVWM7JHGPPVG4YMR3EN3 X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Jon Maloy , David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/3/26 23:55, Stefano Brivio wrote: > From: David Gibson > > The new warnings in fwd_rule_add() have some not quite technically correct > format specifiers. For some weird reason these don't trip warnings on > passt itself, but do when we re-use this code in the upcoming configuration > client. Fix them. > > Signed-off-by: David Gibson > Signed-off-by: Stefano Brivio Reviewed-by: Laurent Vivier > --- > fwd_rule.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fwd_rule.c b/fwd_rule.c > index 777282d..7fd20dd 100644 > --- a/fwd_rule.c > +++ b/fwd_rule.c > @@ -208,7 +208,7 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new) > return -EINVAL; > } > if (new->flags & ~allowed_flags) { > - warn("Rule has invalid flags 0x%hhx", > + warn("Rule has invalid flags 0x%x", > new->flags & ~allowed_flags); > return -EINVAL; > } > @@ -267,11 +267,11 @@ static int fwd_rule_add(struct fwd_table *fwd, const struct fwd_rule *new) > } > > if (fwd->count >= ARRAY_SIZE(fwd->rules)) { > - warn("Too many rules (maximum %u)", ARRAY_SIZE(fwd->rules)); > + warn("Too many rules (maximum %d)", ARRAY_SIZE(fwd->rules)); > return -ENOSPC; > } > if ((fwd->sock_count + num) > ARRAY_SIZE(fwd->socks)) { > - warn("Rules require too many listening sockets (maximum %u)", > + warn("Rules require too many listening sockets (maximum %d)", > ARRAY_SIZE(fwd->socks)); > return -ENOSPC; > }