From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 0FBD95A0274 for ; Tue, 12 Mar 2024 11:20:09 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710238809; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zh25ub17Gny5D0d6ZRwDMbknG7QL6gXqe87RARIb4pk=; b=XVhr8hc8Z9iKv+aQolhuTy1cvA6ySCEP+n2HRpnuHNu01qv1s+jgliHP2qNDoTXXgqKtOm tDK94Y+MRBziS3RWgg/h6GyKAw+vL77d7B7336RMJig7cM+kAG1QsdD5ctAB/UUhJMen/0 lXYiuDdaxlaLPI0S7VBB/LHDt4riVZ4= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-35-an8Tl-lkNk6u8iXLvsrJow-1; Tue, 12 Mar 2024 06:20:05 -0400 X-MC-Unique: an8Tl-lkNk6u8iXLvsrJow-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-513b15ac4e0so1868876e87.1 for ; Tue, 12 Mar 2024 03:20:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710238803; x=1710843603; h=content-transfer-encoding:in-reply-to:from:cc:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zh25ub17Gny5D0d6ZRwDMbknG7QL6gXqe87RARIb4pk=; b=bNamkQl+klB7BlWwnw9UIUu41Eo/nq0HONsVk8cjP0RMpf/CLskPHmUf5/tjlY/y08 R2s3IEb/fy1vRtggB+O4qVtEFpzJ8cdBXif6PIz5lT7mX6n6K1uQVGLAZtv+pcgZWlzY PwwqtVgnSj3pXIOe/g9croPSstvWMPhhvMrob4KSdYf4K211N7FO99dBRGcKnBoeDp/P qkh9Uw6Acgf/NrBEgDKKkwd7M7T/1UAikQdde26NvBvbRfq3LsVx2GRoHknz9Ek0cWuy j4PyauR3ybUaD+4AOVvVqM1Uk9y8ADOxe1BkR/Zf8GxpedeHCyuNqcuk6Osz2L5jhL2b Cs9A== X-Gm-Message-State: AOJu0YynuMi9vE7Ph8VsJkoVH83+O0nD0IwjerQFJhS9nn+pxwaRPqpz 7hILKTYhXlKV2RerckIoKfH5A/FfPF4O1m7rmocmqfZpBnW1rwfLwcP7T3g2NNxj3BJ1PZMETxj KvKsmGPDudKbVWI4QR3ZQ4UKTZb5Wm0OEBjHaVADsh9vM2aXSLg== X-Received: by 2002:a05:6512:3136:b0:513:87ed:4db0 with SMTP id p22-20020a056512313600b0051387ed4db0mr5670221lfd.45.1710238803798; Tue, 12 Mar 2024 03:20:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHaUJ89YpqfGz2aLr5eclE+6aQmWKNRClsHm89kgS55oLn3276NnFkRJEyxg9dNXfpPaayUjA== X-Received: by 2002:a05:6512:3136:b0:513:87ed:4db0 with SMTP id p22-20020a056512313600b0051387ed4db0mr5670205lfd.45.1710238803380; Tue, 12 Mar 2024 03:20:03 -0700 (PDT) Received: from [192.168.188.25] ([80.243.52.134]) by smtp.gmail.com with ESMTPSA id je1-20020a05600c1f8100b00412c1d51a0dsm11927612wmb.45.2024.03.12.03.20.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Mar 2024 03:20:02 -0700 (PDT) Message-ID: Date: Tue, 12 Mar 2024 11:20:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] conf: Handle addresses passed via --dns just like the ones from resolv.conf To: Stefano Brivio References: <20240312072136.225197-1-sbrivio@redhat.com> From: Paul Holzinger In-Reply-To: <20240312072136.225197-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: RLST4PXWGKEGU3MPJ37U54RSZI6KYRUY X-Message-ID-Hash: RLST4PXWGKEGU3MPJ37U54RSZI6KYRUY X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 12/03/2024 08:21, Stefano Brivio wrote: > ...that is, call add_dns4() and add_dns6() instead of simply adding > those to the list of servers we advertise. > > Most importantly, this will set the 'dns_host' field for the matching > IP version, so that, as mentioned in the man page, servers passed via > --dns are used for DNS mapping as well, if used in combination with > --dns-forward. > > Reported-by: Paul Holzinger > Link: https://bugs.passt.top/show_bug.cgi?id=82 > Fixes: 89678c515755 ("conf, udp: Introduce basic DNS forwarding") > Signed-off-by: Stefano Brivio Tested-by: Paul Holzinger