public inbox for passt-dev@passt.top
 help / color / mirror / code / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v9 03/30] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER()
Date: Wed, 13 Aug 2025 16:38:01 +0200	[thread overview]
Message-ID: <f2c8ee0b-3da1-4668-8021-acd8ecf466a1@redhat.com> (raw)
In-Reply-To: <aJv7Y69-DoK-tQJ8@zatzit>

On 13/08/2025 04:41, David Gibson wrote:
>> @@ -127,6 +127,7 @@ size_t iov_to_buf(const struct iovec *iov, size_t iov_cnt,
>>   	/* copying data */
>>   	for (copied = 0; copied < bytes && i < iov_cnt; i++) {
>>   		size_t len = MIN(iov[i].iov_len - offset, bytes - copied);
>> +		/* NOLINTNEXTLINE(clang-analyzer-core.NonNullParamChecker) */
> This suppression worries me slightly - I don't really understand why
> clang would be complaining here in the first place.

Honestly, I think it's a bug in clang analyzer, there is no reason to guess that 
iov[i].iov_base will be NULL. It's why I put NOLINTNEXTLINE.

To be sure, I'm going to put an ASSERT(iov[i].iov_base) to shutdown the warning.

Thanks,
Laurent


  reply	other threads:[~2025-08-13 14:38 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-08 14:01 [PATCH v9 00/30] Introduce discontiguous frames management Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 01/30] arp: Don't mix incoming and outgoing buffers Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 02/30] iov: Introduce iov_tail_clone() and iov_tail_drop() Laurent Vivier
2025-08-13  2:37   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 03/30] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() Laurent Vivier
2025-08-13  2:41   ` David Gibson
2025-08-13 14:38     ` Laurent Vivier [this message]
2025-08-08 14:01 ` [PATCH v9 04/30] tap: Use iov_tail with tap_add_packet() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 05/30] packet: Use iov_tail with packet_add() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 06/30] packet: Add packet_data() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 07/30] arp: Convert to iov_tail Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 08/30] ndp: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 09/30] icmp: " Laurent Vivier
2025-08-13  3:09   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 10/30] udp: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 11/30] tcp: Convert tcp_tap_handler() to use iov_tail Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 12/30] tcp: Convert tcp_data_from_tap() " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 13/30] dhcpv6: move offset initialization out of dhcpv6_opt() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 14/30] dhcpv6: Extract sending of NotOnLink status Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 15/30] dhcpv6: Convert to iov_tail Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 16/30] dhcpv6: Use iov_tail in dhcpv6_opt() Laurent Vivier
2025-08-13  3:13   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 17/30] dhcp: Convert to iov_tail Laurent Vivier
2025-08-13  3:17   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 18/30] ip: Use iov_tail in ipv6_l4hdr() Laurent Vivier
2025-08-13  3:20   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 19/30] tap: Convert tap4_handler() to iov_tail Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 20/30] tap: Convert tap6_handler() " Laurent Vivier
2025-08-13  3:22   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 21/30] packet: rename packet_data() to packet_get() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 22/30] arp: use iov_tail rather than pool Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 23/30] dhcp: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 24/30] dhcpv6: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 25/30] icmp: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 26/30] ndp: " Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 27/30] packet: remove PACKET_POOL() and PACKET_POOL_P() Laurent Vivier
2025-08-08 14:01 ` [PATCH v9 28/30] packet: remove unused parameter from PACKET_POOL_DECL() Laurent Vivier
2025-08-13  3:24   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 29/30] packet: Refactor vhost-user memory region handling Laurent Vivier
2025-08-13  3:25   ` David Gibson
2025-08-08 14:01 ` [PATCH v9 30/30] packet: Add support for multi-vector packets Laurent Vivier
2025-08-13  3:26   ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2c8ee0b-3da1-4668-8021-acd8ecf466a1@redhat.com \
    --to=lvivier@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=passt-dev@passt.top \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://passt.top/passt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).