From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=bqJhI0OE; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id 1823B5A0271 for ; Wed, 13 Aug 2025 16:38:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1755095893; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=pojfTGtJmnGMesQyuzHFfUvNdE3KWbhArWq6mpFG1lI=; b=bqJhI0OE/b99pJevDOftKROUnqIk5vYl8SKTsSMPYGQJszjEt85uXT1tOCekZnHEjWLfX4 RbuKPRooHwtwtMaUmqxT+1bE8us4jaFvrp+gR7MpCHfPLUrfAW8EXU++HBSZVSCpJbKBpi Qk+htSidhNzzXlsmbS8SPUe7Svt22OI= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-572-Srp5C0MTMcSPbzfM5IHxMA-1; Wed, 13 Aug 2025 10:38:10 -0400 X-MC-Unique: Srp5C0MTMcSPbzfM5IHxMA-1 X-Mimecast-MFC-AGG-ID: Srp5C0MTMcSPbzfM5IHxMA_1755095890 Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-7073f12d826so63717456d6.0 for ; Wed, 13 Aug 2025 07:38:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755095890; x=1755700690; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=pojfTGtJmnGMesQyuzHFfUvNdE3KWbhArWq6mpFG1lI=; b=Be00x67857u4sDt2ckg3PvAkFB4LQcMboX/dt0Q2Aep4j14FXL63Roja48LLstfGIJ dHawSwX8TP0lkstJig0OA+n7aRTvtQ3CDilnMmg1IePfLE5OQ6sWjp5VdadrAPu+OUV5 IsFU9liRR/chqY5Wxdjbmw8aYbXXdhotAbXn5LfK7IJ965StbnVgACyuSWFLN/SX414O gTiUqpChaGfRc+79lttvPit+2EXsOuAyYjhXzq4ctPVerC9UtA0tpge2kkDc1Tzb2YwD Q7HFfQ2MM15N0WWn2upVADFyyQh4kbx7f0VBHvfTS6pcAVVFZ6TdCVfoMRNb2V/M91R9 Yvvg== X-Gm-Message-State: AOJu0YxPBEYLjK5ZS55Jb+Hd/0Rf7f4zydY6CuZvZLNDrhcqC4AfnzoC JnbqLl8lBWiNtyvUAk013qKQ/vP2L3nrYxcxhQSi5CBDOYPW7rH0Uu2n/xZRAQSBasZTlGOqdIi /znWuM+8E26T73zbpR4iylwwrZ9OMuHVbHjkWPK2VJ+RZfgRWsN/JzN0BdeBHoQ== X-Gm-Gg: ASbGnctGXqo3BhPGo6PoTrAqq0cTsbk9kg8wAnsQySn/ycNm7nTU+W7tPIBrn4q0sCO 20kPasunj76teCU7W4rrblj/SlK6W4Um4+5YSHOI8x3Yr3uzm7Y89Y6wm7aPLqV2hRtKyfQEScF p+2zQLcMhbHBhFUX/ddiASYmfGAoucXdBQLTEyC3SedtI3tCLwXfY2BFhMRm4YeuMolHNN8a/hw 1ygZlqpUrL4p0EhXc4fcs3Xj3ASVF8EDi2spw0fslEVwDy7vE8xDm/HGrLDXs6MsIK7/SlJQGkR P7SxXzbxQpmErcJwyfpUyf3Hcy+mc4ui8eEBnVj5J+8wlTD6ARk49dqOmK9+RQWMwu4cxcr5XN5 tcte+Q8ko X-Received: by 2002:a05:6214:cce:b0:707:3314:793d with SMTP id 6a1803df08f44-709e8961639mr45572906d6.37.1755095884285; Wed, 13 Aug 2025 07:38:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGfx1pstKclh3Mi003HnvaVOZOCTyErTZGxosn4fyzu38mCumsj+OPRuVh5aB/1PXf7hz9p3A== X-Received: by 2002:a05:6214:cce:b0:707:3314:793d with SMTP id 6a1803df08f44-709e8961639mr45572326d6.37.1755095883159; Wed, 13 Aug 2025 07:38:03 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-7077cddc290sm193305816d6.63.2025.08.13.07.38.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Aug 2025 07:38:02 -0700 (PDT) Message-ID: Date: Wed, 13 Aug 2025 16:38:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 03/30] iov: Update IOV_REMOVE_HEADER() and IOV_PEEK_HEADER() To: David Gibson References: <20250808140142.3404325-1-lvivier@redhat.com> <20250808140142.3404325-4-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: w4ojLYBdJoEX_cModEQ8V4FBFA_MRbOciO9qATyAFkM_1755095890 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: T5RJTTMBQPP6Y5KAHXTW47GREGALGHHJ X-Message-ID-Hash: T5RJTTMBQPP6Y5KAHXTW47GREGALGHHJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 13/08/2025 04:41, David Gibson wrote: >> @@ -127,6 +127,7 @@ size_t iov_to_buf(const struct iovec *iov, size_t iov_cnt, >> /* copying data */ >> for (copied = 0; copied < bytes && i < iov_cnt; i++) { >> size_t len = MIN(iov[i].iov_len - offset, bytes - copied); >> + /* NOLINTNEXTLINE(clang-analyzer-core.NonNullParamChecker) */ > This suppression worries me slightly - I don't really understand why > clang would be complaining here in the first place. Honestly, I think it's a bug in clang analyzer, there is no reason to guess that iov[i].iov_base will be NULL. It's why I put NOLINTNEXTLINE. To be sure, I'm going to put an ASSERT(iov[i].iov_base) to shutdown the warning. Thanks, Laurent