Re: [PATCH v11 00/10] Add vhost-user support to passt. (part 3)

[Laurent Vivier <lvivier@redhat.com>]

On 13/11/2024 10:22, Stefano Brivio wrote:
> On Wed, 13 Nov 2024 09:03:59 +0100
> Laurent Vivier <lvivier@redhat.com> wrote:
> 
>> v11:
>>   - rebase
>>   - address comments from David on v10
> 
> Are my comments from before v10 and the peek_offset_cap issue addressed
> now, or should I rather wait reviewing this? Or should I have another
> look at that issue...?

Wait. I will address your comments in the next version. I will work on the peek_offset_cap 
issue once the code is stabilized (so the next next version?).

Thanks,
Laurent
> 
>> v10:
>>   - rebase v9 on top of my changes
>>   - remove last 4 patches from v9 as
>>     'tcp: Pass TCP header and payload separately to tcp_fill_headers[46]()'
>>     introduces a regression in "make check" for me.
>>   - addressed comments from David
>>   - I tried to cleanup iov management, but I was not able to remove the
>>     update of the first iov to point to the header or to the data
>>       - upd_vu_hdrlen()/tcp_vu_hdrlen() includes now the size of the
>>         virtio-net header
>>   - I didn't address comments from Stefano.
>>   - I didn't fix the bug with seek_offset_cap
>