From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=EaligmAB; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 691BB5A08B5 for ; Mon, 17 Nov 2025 16:26:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1763393208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=F3+Sm3kbz/EjzAvhtKT3P5RZStzK4CIuzh9aHYEnrbg=; b=EaligmAB58SsOopWF8/DrHYOPf1yJM6mpMu+rgbFVF4wLZzwsmandTz37nYHVEJI4jD3D+ A7QljMvJbJaZbKarIZdLJtajmWz9EwPAQQpy8pKWu5HC0OuIhqzwQ/GD24N6H8E8+BlM+1 CQSMfy/Zh2O1zocA3D5irUhc9QhKvBE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-LQa5aHNGOO20dEjtzHmo-w-1; Mon, 17 Nov 2025 10:26:46 -0500 X-MC-Unique: LQa5aHNGOO20dEjtzHmo-w-1 X-Mimecast-MFC-AGG-ID: LQa5aHNGOO20dEjtzHmo-w_1763393205 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-42b56125e77so2040972f8f.3 for ; Mon, 17 Nov 2025 07:26:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763393205; x=1763998005; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F3+Sm3kbz/EjzAvhtKT3P5RZStzK4CIuzh9aHYEnrbg=; b=RwmCEHneU2vLXU1AYSYi+yxzfgLOcsb1VTuMI9/ytUD+aHX7RMJ4kFRJuASD+HT3WL zjJ7+KLxfb6U+QW54cCTKe+1cz+C5m76WLsRtOhIOTWe0Eav2iyhVr8/W1VCqRVwiAtB Uq3xXMI4izzFT/USxASGKfHTRfAXeMW5hL1qk3z+fwKlERY2kvESlBtE192IbG5UNpta frTHljlgkiA/TvfVZ4u/Bn9Vc9P7u5CrW5EvINYsSW9/K9wJEzmn09UVgu66r75Cuei5 S1hGuGxp/tRB21rkYw8loGFxsqLWC7eX4Ey59Et/58Zjddtb4XmW44654B5IC4+u1zcw MHfg== X-Gm-Message-State: AOJu0YzSU1HRHdPeAGawozQhIxY1nn4L2lfnhYxL7sUjO0Z5v5MCDecL Dg/R4zaIHSR4QQ4noSsGSkkUhaEhUFD/tiKIQ4j0mrzptKtwoQP+zvw/k+VJlCnK+nvpnk2Oxzs xY32abV93vcOPNmTqQUyIis/Szu/1wjRpv7ZStQsAuHb4p8tPSkslptqygefugg== X-Gm-Gg: ASbGncvJjLu1kKsfwVOwGUkkCICgC/HwwJVTnDX5+A4roil2Yb+RPblhLG6hFlgLtgZ OBFM/Ou2S5OFyaY7sPNVg6uvd0X2Z8pS2FrORyDnqxpuBiqhPN5d8ZsJ0UaHxEWU4sEww/bEQlD S3lkyqGh/XcqLMxv/0BYBP2n+E5pIAVp0KvzjDNfm6wmTii1hKgtFwn3ih3lUWbGr+Rw8IiG5Cc 1ECfv6TVUR7xBR8R33efX/askPY8p7ZmskCV8nsXlbzl+PxLWn2dnmdL/ina5AEQUdqAycXz6CI LTP0rFIbYaEbdCFX7mgpM8puPaqM/SNbxdXoiIjwRht5v4/AfVEHyYZFI/szYlIcqWt1OEDAbzT ZdZbJct1JSy7kPUGABMCOj1qcui1rgblP4l8cXWyQM/W92T1V X-Received: by 2002:a05:6000:4020:b0:42b:3ee9:4771 with SMTP id ffacd0b85a97d-42b593503ffmr12630882f8f.23.1763393205049; Mon, 17 Nov 2025 07:26:45 -0800 (PST) X-Google-Smtp-Source: AGHT+IEH78nrrT80VCAXN9msJU5xcLZaLTVv2nUe+mJ3bFbSGAm5oWnjvUy6CfT5f4vWZ/8jWg0lTg== X-Received: by 2002:a05:6000:4020:b0:42b:3ee9:4771 with SMTP id ffacd0b85a97d-42b593503ffmr12630840f8f.23.1763393204307; Mon, 17 Nov 2025 07:26:44 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42c9628ebacsm13619020f8f.30.2025.11.17.07.26.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Nov 2025 07:26:43 -0800 (PST) Message-ID: Date: Mon, 17 Nov 2025 16:26:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] vhost-user: Enable multiqueue To: David Gibson References: <20251107143901.89955-1-lvivier@redhat.com> <20251107143901.89955-2-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: EFnlHlQEUv0g_DNBtY3C18C3BJgDk2fNS0tuoLPhCvk_1763393205 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: KRATQ3Q3Y3VQS7RUUZXJLVTW6CE27KYF X-Message-ID-Hash: KRATQ3Q3Y3VQS7RUUZXJLVTW6CE27KYF X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/10/25 05:48, David Gibson wrote: >> index aa7c869d9e56..c668159e29b4 100644 >> --- a/vhost_user.c >> +++ b/vhost_user.c >> @@ -323,6 +323,7 @@ static bool vu_get_features_exec(struct vu_dev *vdev, >> uint64_t features = >> 1ULL << VIRTIO_F_VERSION_1 | >> 1ULL << VIRTIO_NET_F_MRG_RXBUF | >> + 1ULL << VIRTIO_NET_F_MQ | > Should this be conditional on max_virtqueues > 2? I don't think it's needed as 1 qpair (2 virtqueues) is a valid value with VIRTIO_NET_F_MQ: https://docs.oasis-open.org/virtio/virtio/v1.3/csd01/virtio-v1.3-csd01.html#x1-2410001 "The device MUST set max_virtqueue_pairs to between 1 and 0x8000 inclusive, if it offers VIRTIO_NET_F_MQ." Thanks, Laurent