From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTP id 66F055A004E for ; Tue, 06 Aug 2024 14:33:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722947587; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R+4KYV2u0MQ15RptRh3BMywNbFiSsst7j1vV/337dPw=; b=T6VQjTCEv+bdFrHTfcu1bIhDzK25C1eVYDyOIXDdbynHjs7jQrB9WP+RyP1BzriMlbmHom 3xhAZ0ueQJuJhWnTWuZRDToteh9LFavC7EpkBlbYVBViEJ6jEqZ31OrWm8QwbUU5s8gp5F MpIEH7gqqGkOAqkBhlh+AyhJDaJosJA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-674-RBImZkGzMEScwU0SC8t1zw-1; Tue, 06 Aug 2024 08:33:05 -0400 X-MC-Unique: RBImZkGzMEScwU0SC8t1zw-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-36873a449dfso3323566f8f.0 for ; Tue, 06 Aug 2024 05:33:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722947585; x=1723552385; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=R+4KYV2u0MQ15RptRh3BMywNbFiSsst7j1vV/337dPw=; b=Hyws8Qx6v6YVItS5BDNx6LJ/yxojDNatnM9tlp6YSyT894VjIIK/atQRHrE9xA6phx g52TGiGV5q66J2qDHvcXhpntVXA16HQOW5j/plz4oQYuSAq7XsojOYs3VYIKDzy5J+uv OcVKs0yYMxJIWxT0F5hLGYOFUbKah2IVPZK48iOxuukwOC8LjiFOUwmPSH38HY6JxdIT PRXiiFOAYnZgDJPo7HJyDJCKBl5sqO4riaLRd4WCHBnF6+bXkn9IdtdI0U+yJHimIcpE epcZEMDTaRIEz0m9L/E3Dbykpn+Edy6/CvmiF4mXZRMmOlg9jHqnP+NvdZf159N+gNVe E/eg== X-Forwarded-Encrypted: i=1; AJvYcCWdSAaSql4CtTWdrvOqu8V4dFxL3cZSpPik27Wu3bt1dluySaLMbhw31WSDrO1KVJeW1lvbHUkFpFU6pV21SFDhOySv X-Gm-Message-State: AOJu0YxmZf7lz6TzDpvpSfyVmwnDqWiYAx7+i8Vba8g1ZTAkJk3yMRei AOrLm/7iaP3boqvfl7nEgwEDKHn0XB2Uz1GCEtHhf+43XtZ4uG0Al7MCKsNSdUFiAR1oVuw9LRG ZNVBFiAGZj/PxzB4u8MuZRWX7ds0oIPIQvKqFGRZXCke2N5s+RA== X-Received: by 2002:a05:6000:1203:b0:367:9049:da2e with SMTP id ffacd0b85a97d-36bbbe3ed02mr12071550f8f.8.1722947584607; Tue, 06 Aug 2024 05:33:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGnemVe69KD1iNEHCqdtjL6Hw8hhTTL9gFfvZRD6pDseDswVOX3ImHX0tU0IBYSeX36RpSGhw== X-Received: by 2002:a05:6000:1203:b0:367:9049:da2e with SMTP id ffacd0b85a97d-36bbbe3ed02mr12071527f8f.8.1722947584107; Tue, 06 Aug 2024 05:33:04 -0700 (PDT) Received: from [192.168.188.25] ([80.243.52.134]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36bbd06d078sm12764327f8f.94.2024.08.06.05.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 05:33:03 -0700 (PDT) Message-ID: Date: Tue, 6 Aug 2024 14:33:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tcp_splice: Fix side in OUT_WAIT flag setting To: Stefano Brivio , passt-dev@passt.top References: <20240806121249.3144030-1-sbrivio@redhat.com> From: Paul Holzinger In-Reply-To: <20240806121249.3144030-1-sbrivio@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: BMNLPZU4NQOHADMHZV3MRBQFYECL4PZ6 X-Message-ID-Hash: BMNLPZU4NQOHADMHZV3MRBQFYECL4PZ6 X-MailFrom: pholzing@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: David Gibson X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 06/08/2024 14:12, Stefano Brivio wrote: > If the "from" (input) side for a given transfer is 0, and we can't > complete the write right away, what we need to be waiting for is for > output readiness on side 1, not 0, and the other way around as well. > > This causes random transfer failures for local TCP connections, > depending if we ever need to wait for output readiness. > > Reported-by: Paul Holzinger > Link: https://github.com/containers/podman/issues/23517 > Signed-off-by: Stefano Brivio Tested-by: Paul Holzinger > --- > tcp_splice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tcp_splice.c b/tcp_splice.c > index 473562b..483e45d 100644 > --- a/tcp_splice.c > +++ b/tcp_splice.c > @@ -577,7 +577,7 @@ eintr: > if (conn->read[fromsidei] == conn->written[fromsidei]) > break; > > - conn_event(c, conn, OUT_WAIT(fromsidei)); > + conn_event(c, conn, OUT_WAIT(!fromsidei)); > break; > } > -- Paul Holzinger