From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=fail (p=quarantine dis=none) header.from=redhat.com Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id 3AE2A5A0265 for ; Fri, 06 Nov 2026 11:47:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1793962076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=/bLkuupn8bNAOsbYqPdNeoUPM/gniO2n1Tkw6K5yQDQ=; b=dIYV1TNleuFGeFM48F4/gMsE0i08TogDq6euJdE/X+IUsnFA7XEcZj9/jIoXczRN33UuzM qeu5QHwDNNgfYJgAlRZYp37XHltYZrEYzN9Yd8Zi+Zz3BCYiQX5qJABZBhqr2+8QPeBWFB 0tQudQxQ+702ALxawvqwZOghVQbWZrQ= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-DIe73o8oPeGuAYI6_MwXtA-1; Fri, 06 Nov 2026 05:47:55 -0500 X-MC-Unique: DIe73o8oPeGuAYI6_MwXtA-1 X-Mimecast-MFC-AGG-ID: DIe73o8oPeGuAYI6_MwXtA_1793962074 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4a2063be13dso4598695e9.3 for ; Fri, 06 Nov 2026 02:47:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793962074; x=1794566874; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/bLkuupn8bNAOsbYqPdNeoUPM/gniO2n1Tkw6K5yQDQ=; b=IUDctYge1nQin5fRls1BErTwRR8vd5F4pDRR7nQP003FZDLFWR40GGveAZg8iSiBkK 5qFc0Hx0TxAIW+KBH/zlX+q6isvkTRkRibephtH8S8NeQjnm+7zpsqIyT6UPE21z90Hp E8WWG5WEeKVzdSkZHMN+BtG0s1pyo52acTS9KA5lq7SDy9aaChlsU4o4QVc/408wW1nm kcZwjcPHThihj7emsXuYBfgkwQs8FogMuPCiUsJAYo8fT8JaFAsLXavBhTNxjWoPkD0m Kh8GfoLEgLEKvXvRIDtX3xdxG55gMA5yH9xRqbjJ2SSZX/PTC3gyRBmwo7hpN7v+JKom DZeA== X-Forwarded-Encrypted: i=1; AKwUvBxn62WSVhlkv1nQTLPX3hfLNgDWgDfvg2y4o/jjeBrs1ZIineOL6jrMi4VcVRNucoGW/AATcDEOg60=@passt.top X-Gm-Message-State: APuU4Z+QaOilEUGxO5l2aOMTUEGXGkByI06VZS0Q5wYJrU5bA/0fjBrq XX2L8s4rUqJEedVXUiILVt8nq4UrXO1LAUCq9G9mezPARJTHhp2JgOW58+LWLcMUsey67Yx+nDk ydlXxK8kHiJysztdO5zpS9OJ8BzPiGiinpJYxBZD2eQLqzPNDHdlMSA== X-Gm-Gg: AYBFou0SafU1HZgfRz/HPLedjt01fCdmQDAZknslHDRpkmkD9utrVEUWaWYCsGInLtu aWGAFqpeaUiSF0iQCvxEPhKg9FR5CZRbJ8edswuvT4UFL1niqm5KQTDewapH58+8uUoYCAy/g9U ctI+uvp1Vvz9MJ/kssm60kt/RMxy6amRY2s5iCzoheyb3zhGRh3wmwACwYdL6izd802eZSz5INB LNzIUwTE/uz9imEnmIF31Bqwx8N2gU+pq/4JrQcPbeJVobZNRDMKoKJvRNGXGPM8LD+frUVP41Z Eh/rdehdWWcf4E0hOAfOMYuD40V/5gJ9M+jrZK9Vg1deL8mEDWD61m3YNVyySORti9pJoWtzN8J d9UAob7rZSG+Ih2B9ycWzwc/KWOBbYBHypnxgv1iJ+sJzpNZeRwWeWXO98IEXIAW2I9dG0mKxqE uirF2VESkbP6TBDcw= X-Received: by 2002:a05:600c:64c5:b0:4a7:4697:dae3 with SMTP id 5b1f17b1804b1-4b6dfca2330mr35504695e9.24.1793962074438; Fri, 06 Nov 2026 02:47:54 -0800 (PST) X-Received: by 2002:a05:600c:64c5:b0:4a7:4697:dae3 with SMTP id 5b1f17b1804b1-4b6dfca2330mr35504415e9.24.1793962073999; Fri, 06 Nov 2026 02:47:53 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b? ([2a01:e0a:e10:ef90:e9e7:d9a0:a4eb:dc4b]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b6e2028d9bsm98609895e9.9.2026.11.06.02.47.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Nov 2026 02:47:53 -0800 (PST) Message-ID: Date: Fri, 6 Nov 2026 11:47:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/7] tap: Move the tap_hdr file to a separate file To: aerosouund , passt-dev@passt.top References: <20261016204940.33190-1-aerosound161@gmail.com> <20261016204940.33190-2-aerosound161@gmail.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20261016204940.33190-2-aerosound161@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: x1Qqad0fO2hqaIu99t8rivs4FlKamz6DzHdVqiAOGzo_1793962074 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: KS72BQ2WRZRJVIBTEBNQWEWO5YTBIIPJ X-Message-ID-Hash: KS72BQ2WRZRJVIBTEBNQWEWO5YTBIIPJ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 10/16/26 22:49, aerosouund wrote: > From: Ammar Yasser > > It was defined in tap.h, put it on its own so that future callers won't > need to depend on all definitions in tap.h. > Also turn it into a union of a vnet_len and virtio_net_mrg_rxbuf > because for vhost acceleration the frames will have this virtio net > header prepended to them. > > Signed-off-by: Ammar Yasser > --- > tap.h | 9 +-------- > tap_hdr.h | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 8 deletions(-) > create mode 100644 tap_hdr.h > > diff --git a/tap.h b/tap.h > index b335933..1625975 100644 > --- a/tap.h > +++ b/tap.h > @@ -10,6 +10,7 @@ > #include > > #include "passt.h" > +#include "tap_hdr.h" > > /** L2_MAX_LEN_PASTA - Maximum frame length for pasta mode (with L2 header) > * > @@ -38,14 +39,6 @@ > > struct udphdr; > > -/** > - * struct tap_hdr - tap backend specific headers > - * @vnet_len: Frame length (for qemu socket transport) > - */ > -struct tap_hdr { > - uint32_t vnet_len; > -} __attribute__((packed)); > - > /** > * tap_hdr_iov() - struct iovec for a tap header > * @c: Execution context > diff --git a/tap_hdr.h b/tap_hdr.h > new file mode 100644 > index 0000000..4156f44 > --- /dev/null > +++ b/tap_hdr.h > @@ -0,0 +1,23 @@ > +/* SPDX-License-Identifier: GPL-2.0-or-later > + * Copyright (c) 2021 Red Hat GmbH > + * Author: David Gibson > + */ > + > +#ifndef TAP_HDR_H > +#define TAP_HDR_H > + > +#include > +#include > + > +/** > + * struct tap_hdr - tap backend specific headers > + * @vnet_len: Frame length (for qemu socket transport) Add the new entry @hdr in the description > + */ > +struct tap_hdr { > + union { > + uint32_t vnet_len; > + struct virtio_net_hdr_mrg_rxbuf hdr; > + }; > +}; > + As mentioned in my comment of v1, you need to update in this patch tap_hdr_iov() to use sizeof(thdr->vnet_len) rather than sizeof(*thdr), otherwise it's broken. > +#endif /* TAP_HDR_H */ > -- > 2.39.5 (Apple Git-154) Thanks, Laurent