From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TdByJ4y4; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by passt.top (Postfix) with ESMTPS id B17C95A027E for ; Wed, 14 May 2025 11:51:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1747216283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=52mheB5xpfIZSxu2l1A1ahCmAXwv6aoFj9y1SJdG0T4=; b=TdByJ4y4uhJ4VI/BspIfpjVZ76X0bNG1EBs7KdlWsL4FuPSMjB7DXLiw3pJ5oJ+FEpC5FQ 6HkBLxyKAAHAMjvcAr+EOfU8wvdyI3ZXSzKFxFBf8xb3DD8sfGsQyHwzphD2du3YCoMYgC zhDEUOXrYohvq7Ae/dQIGddxa+/yJjY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-104-OHFO8NkUOx-wOmnMNmlBiQ-1; Wed, 14 May 2025 05:51:22 -0400 X-MC-Unique: OHFO8NkUOx-wOmnMNmlBiQ-1 X-Mimecast-MFC-AGG-ID: OHFO8NkUOx-wOmnMNmlBiQ_1747216281 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-442dc702850so26742205e9.1 for ; Wed, 14 May 2025 02:51:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747216280; x=1747821080; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=52mheB5xpfIZSxu2l1A1ahCmAXwv6aoFj9y1SJdG0T4=; b=sSyIJQBFeJUK4+Woc0LADL+c8oMXJSd1/Rb1+rOOT1rBRdH9NaSa7TtyPLzeAq33W+ LVUaPh7Qf4gg1QwOAKTV5BPNe2Y2vvygSxUYZs7njib+1+kcs2Ak+zgR14MypoL+ROoh IKathW2e3H1FkN3if7Dk5H+mQ/8K+5hJxSRFctBIiTZrd4F3mkNobJ0Ok9ptaQiphlBf BsUuTPdXzAlILNUJPWRmCy0LV+Ro/mChC5JSXvX8BlyI9GKHG+ZFYcu1dh6wamcNFCV7 FvS7O7Y/zc3kY7qc2bTnVy3m558BYEks9QwzhsSUNIgI4O9X6H9HW6+A7HeF4rsuVZJ3 QVlw== X-Gm-Message-State: AOJu0YzYjcyPfD1Eq6GcQQFy7kY6C1Y/2uGDmCwOASDFK9PyqS1ReLb6 o3pb6xARxzK7N6qWq3C9DjfP+elneP1yRlYwE7TkpRdzKW2k6Bx6TYDwSbHef+s1ROo40c74pur /CrYrMxngB93jYKvkaWFTOSz7QJuWvqVE16YdkYQTohjxiqdvCfCeAiyIQeXbUfhPG7VJIBfozI gm4iPNU/MaVszktKDCHBDoItCrOAYXcaKe X-Gm-Gg: ASbGnctmfXWk20OtawyhF9ZCilFcTd+net0tEJqT9ZItBErgRe45OZ13sP1WCOqk2/X iJ/eMj39XHoeqF+upiYD67YFRoQSQ8zktSr062s1bAYKwcQFlIFs02j70s0uHfMkEW7rviQt0SM Uf+K1l1Vk48jaDojICStpEInkh6KQpscShKIPpAR/FrTqhOOmJMoHrKPJZBi3w5oHF0eNzNGnKu D07sPlwZBWnRKGEk4uMiylI16PZ3JpF03I/9gKgZr1PX64oOxIlbTpa/3DxMEO641mPzlhHV47X LoxlXHYOFqr8cppwFDz2Z8PFTE0QsVjQOxzmfPO6EDt7mFdvhg== X-Received: by 2002:a05:600c:358b:b0:442:e9ec:4654 with SMTP id 5b1f17b1804b1-442f20e1ad3mr25253955e9.8.1747216280534; Wed, 14 May 2025 02:51:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtvkttX/qL+xMhMl9NXxrexEsx2Zvu6KthCTQmXMb04SQcjSBik10+K2wploAXwlHQkgc+zg== X-Received: by 2002:a05:600c:358b:b0:442:e9ec:4654 with SMTP id 5b1f17b1804b1-442f20e1ad3mr25253535e9.8.1747216279990; Wed, 14 May 2025 02:51:19 -0700 (PDT) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-442f39e84acsm23371055e9.25.2025.05.14.02.51.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 May 2025 02:51:19 -0700 (PDT) Message-ID: Date: Wed, 14 May 2025 11:51:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] test: Display count of skipped tests in status and summary To: passt-dev@passt.top References: <20250514072009.3541188-1-lvivier@redhat.com> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20250514072009.3541188-1-lvivier@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6Q3lOARs__TvqLXj1WabIGJvxyH4mMMFqIuIpT41Hsw_1747216281 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: AMLPYVHGYBOBL2BI7GOBQVSKXRWMDVSZ X-Message-ID-Hash: AMLPYVHGYBOBL2BI7GOBQVSKXRWMDVSZ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 14/05/2025 09:20, Laurent Vivier wrote: > This commit enhances test reporting by tracking and displaying the > number of skipped tests. > > The skipped test count is now visible in the tmux status bar during > execution and included in the final test summary log. This provides > a more complete overview of test suite results. > > Signed-off-by: Laurent Vivier > --- > > Notes: > v2: add missing comma before SKIPPED in report log > > test/lib/term | 7 +++++-- > test/run | 4 ++-- > 2 files changed, 7 insertions(+), 4 deletions(-) > > diff --git a/test/lib/term b/test/lib/term > index ed690de82c20..089364c67f85 100755 > --- a/test/lib/term > +++ b/test/lib/term > @@ -19,6 +19,7 @@ STATUS_FILE_INDEX=0 > STATUS_COLS= > STATUS_PASS=0 > STATUS_FAIL=0 > +STATUS_SKIPPED=0 > > PR_RED='\033[1;31m' > PR_GREEN='\033[1;32m' > @@ -439,19 +440,21 @@ info_layout() { > # status_test_ok() - Update counter of passed tests, log and display message > status_test_ok() { > STATUS_PASS=$((STATUS_PASS + 1)) > - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)" > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_passed > } > > # status_test_fail() - Update counter of failed tests, log and display message > status_test_fail() { > STATUS_FAIL=$((STATUS_FAIL + 1)) > - tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | #(TZ="UTC" date -Iseconds)" > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_failed > } > > # status_test_fail() - Update counter of failed tests, log and display message > status_test_skip() { > + STATUS_SKIPPED=$((STATUS_SKIPPED + 1)) > + tmux set status-right "PASS: ${STATUS_PASS} | FAIL: ${STATUS_FAIL} | SKIPPED: ${STATUS_SKIPPED} | #(TZ="UTC" date -Iseconds)" > info_skipped > } > > diff --git a/test/run b/test/run > index 4e86f30fb750..51e5a3351f7a 100755 > --- a/test/run > +++ b/test/run > @@ -202,7 +202,7 @@ skip_distro() { > perf_finish > [ ${CI} -eq 1 ] && video_stop > > - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}" > + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}, SKIPPED: ${STATUS_SKIPPED}" > > pause_continue \ > "Press any key to keep test session open" \ > @@ -236,7 +236,7 @@ run_selected() { > done > teardown "${__setup}" > > - log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}" > + log "PASS: ${STATUS_PASS}, FAIL: ${STATUS_FAIL}, SKIPPED: ${STATUS_SKIPPED}" > > pause_continue \ > "Press any key to keep test session open" \ In fact, we need to update also: exit $(tail -n1 ${LOGFILE} | sed -n 's/.*FAIL: \(.*\)$/\1/p') New version coming... Thanks, Laurent