From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=N4rdjOTA; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTP id 6FE465A0623 for ; Thu, 14 Nov 2024 11:29:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731580182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M9Fg41IPgq31HB7NGij291H0Ve/7Lu1ztAnQXfcKzLU=; b=N4rdjOTAIOujV3vnfR8VWfZAJcewy3uELi9b0a7aa1cTtwFEYQZjeUwnVG/G2scJck/mzn /axkMsk0OIdd86l/mOLj0Wxw8MbRVTfN/GHF5NIq9V1Ieunup9JkeDh5AyTsefsMmGSWlX a7ev5K7e3ARwsAQW0EzMd5NpFfnHITE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-19-zNujanEPMH68XHjwYhASfQ-1; Thu, 14 Nov 2024 05:29:39 -0500 X-MC-Unique: zNujanEPMH68XHjwYhASfQ-1 X-Mimecast-MFC-AGG-ID: zNujanEPMH68XHjwYhASfQ Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4315c1b5befso3898115e9.1 for ; Thu, 14 Nov 2024 02:29:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731580178; x=1732184978; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M9Fg41IPgq31HB7NGij291H0Ve/7Lu1ztAnQXfcKzLU=; b=ngSXkrAmro7h3AJ/M/jF/W/huQ6WeFeYEVpZdJSv+HE6KDLDdeAUzyXch6caDA86pK vlEM6QH9BaCafBJBqonkhqEssyD6JpoCFTAPTcK4IzX/e6dBdFO4aqztrO7mXgoEDGqQ KfOIB/vxkLR6NmnQ+Nd703mgNv8xCPIlirPGHqGK9i2CbCTdLdYS65wBTg+5d9s5w7LG vtKoDsV2UlrHGxolgROvdVPZEYNdw14E/y7RM2LtD3F+ZB3u+sjU/Ssp5z6gD0O+GHfL TjdX0+Rfus/t/73nHjZ6VOEh2DWcVv4Qe/IXfkTwRiAlQUk3glUvDGJ69ujhi4tBdE4N yMyw== X-Gm-Message-State: AOJu0Yxf16UOg20a0eQJ09yGWSNNegHnYwYFOLBRlWPYjAVRFSvfL56W 22QwyeUPB12bp2h7v3Z2WVKBuwXqOqgHNk1OWAWqRWp1lU8X4iuQZEH7ojT5u83g8dNHDxWlJI+ mubYQR9kJxb+03Inq5X1EtqZ736HVu+y8FNoKCIxjXw8UUjW5/g== X-Received: by 2002:a05:600c:524b:b0:431:4f29:4a98 with SMTP id 5b1f17b1804b1-432b75183c0mr184752505e9.20.1731580178426; Thu, 14 Nov 2024 02:29:38 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8brIejXFM1iHdqWBC3q99R3BsTfCaBwaEEk/CDaoqLlOvkw+zUUb/gShDWWQ1M6/IoGq5Vg== X-Received: by 2002:a05:600c:524b:b0:431:4f29:4a98 with SMTP id 5b1f17b1804b1-432b75183c0mr184752255e9.20.1731580177910; Thu, 14 Nov 2024 02:29:37 -0800 (PST) Received: from ?IPV6:2a01:e0a:e10:ef90:343a:68f:2e91:95c? ([2a01:e0a:e10:ef90:343a:68f:2e91:95c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-432dab807d4sm15414455e9.21.2024.11.14.02.29.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2024 02:29:37 -0800 (PST) Message-ID: Date: Thu, 14 Nov 2024 11:29:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 7/8] vhost-user: add vhost-user To: Stefano Brivio References: <20241010122903.1188992-1-lvivier@redhat.com> <20241010122903.1188992-8-lvivier@redhat.com> <20241017021034.437f3757@elisabeth> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20241017021034.437f3757@elisabeth> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZbH-U56TyZ8fKFJyzIvkwOwZ-xP3NY4QeShaqTL4u2g_1731580178 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: 5K4MDQEYBZO3VGXNBVK3VNQ45B3MK3DQ X-Message-ID-Hash: 5K4MDQEYBZO3VGXNBVK3VNQ45B3MK3DQ X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: passt-dev@passt.top X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 17/10/2024 02:10, Stefano Brivio wrote: >> +/** >> + * tcp_vu_prepare() - Prepare the packet header >> + * @c: Execution context >> + * @conn: Connection pointer >> + * @first: Pointer to the array of IO vectors >> + * @dlen: Packet data length >> + * @check: Checksum, if already known >> + */ >> +static void tcp_vu_prepare(const struct ctx *c, >> + struct tcp_tap_conn *conn, struct iovec *first, >> + size_t dlen, const uint16_t **check) >> +{ >> + const struct flowside *toside = TAPFLOW(conn); >> + char *base = first->iov_base; >> + struct ethhdr *eh; >> + >> + /* we guess the first iovec provided by the guest can embed >> + * all the headers needed by L2 frame >> + */ > What happens if it doesn't (buggy guest)? Do we have a way to make sure > it's the case? I guess it's more straightforward to do this in > tcp_vu_data_from_sock() where we check and set iov_len (even though the > implication of VIRTIO_NET_F_MRG_RXBUF isn't totally clear to me). According to spec, minimum size of a buffer is 1526 bytes (https://docs.oasis-open.org/virtio/virtio/v1.2/csd01/virtio-v1.2-csd01.html#x1-2340003) So if the guest is buggy, we will write in the guest memory out of the (buggy) provided buffer, and we can crash the guest. But it's what happens to a buggy guest. We can't fix the guest, IMO passt should crash in this case (add an ASSERT()?). Thanks, Laurent