From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: passt.top; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: passt.top; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HZCKTOyG; dkim-atps=neutral Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by passt.top (Postfix) with ESMTPS id B52E15A0265 for ; Mon, 11 May 2026 14:51:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778503903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ve5yJdwJZw7E0pxll0WOxN6oPktp6JJ8PsN9H599PEk=; b=HZCKTOyGaKomWjzGizSXsSe7B+qArc89L9zIzZqiOiNZcfwdTPISIug06nKF89Y9lo7wUM nWRVocLOTZkhhddlciLzFAEnbirvda2TxBSLeqoS7TuuQn8rg743XDXVkYT+dLU1VeggIk q6EvMmNop0UuuUv/GPZQ16LcJBch2lo= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-zxWYQafSPlep2B_cc0IYmg-1; Mon, 11 May 2026 08:51:40 -0400 X-MC-Unique: zxWYQafSPlep2B_cc0IYmg-1 X-Mimecast-MFC-AGG-ID: zxWYQafSPlep2B_cc0IYmg_1778503899 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488c2aa6becso35814035e9.2 for ; Mon, 11 May 2026 05:51:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778503899; x=1779108699; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ve5yJdwJZw7E0pxll0WOxN6oPktp6JJ8PsN9H599PEk=; b=o8+EGdCY+1GqtY57QAqpO8/u2eKhzRkVEEYYRFmyV1PBUKRBHh9f7RdMaQxtstKbg/ z9GTOZPCeGWMXU5vBmpGLbZ/4m6MQFIFtTmutjIoKJCtQ0sD9Q0coF48e1Bf/wN9lBjc ryTCgoYnn5deIdL4VSpxzMC8m0QfvCj1CKK+EukiXJY8BoJdPcWrPGjof6bJJygiF91a tsl1/tG260UAXFCgVDdvB4XSM2Oxv3lQNz92lx5xAnUVdMVsfgS8kfzle2ZM6XGpcxxw b6IShkJNAOYPCBUYTIgjGiPp0fe+Bm464CpQsGMNlV4V9tMu2qn+ZQoyzWspj4MbDt9D wH5Q== X-Forwarded-Encrypted: i=1; AFNElJ/R2kYGDqdJYTeA77ggHOL5k3TPig/PpTY6vU/+VuHkegOKaH0oU7wY9MOnGR3CaGuMX/EiH0SH1Mg=@passt.top X-Gm-Message-State: AOJu0YxajQzYJK1IMb2QBMX27ZI6VO3Gwh6errEv5aA7mj/6f1bMwzzm /jJF9X2lSqN6pNJBxtZa/Bs+fDKfzeeB92aOqVZ0ZPN2B/A1Itg89Wz51rOTJVV91CBMclznqi8 FBAirTE/AZDVQI9aUkrmnWIXleA68Ypnw5V9rS7JU8xLVNmgmaQzg1g== X-Gm-Gg: Acq92OE0qUS0h84Hur3Kh7h6OFP8tgW7Zc0zj9nwSFT6d/QU1BWFVpkF7a46Y8NKfU6 DltFztT4SI6rpB4N02ed8QxZGMc97+Dbzp/l8DBdUD9JV3BXyWJtDJVRTMUITwJcUTpH2/yE0Gc ZfA9tcG6JQmTTnheYGM/CXXVOpJzfd3XhUTdfSlwwUWowejWxKWlCUWEqZChVou/i3gFyyAVTuV JcN5K0tEbllTKYpaF8Nj1kcQHTuahIG7LrRgUR5kiX+2uf54df3umgCfl4hZbq7JnCiq1WEqwjr OTQbsyQ2a8dUYaOXWl3CCxwUk1aj4RWCsU1IgBAefFnrFRmJvlkGO+upizpAO3cS0U0FFTTOoWi u0KzgyVbuOjeVqYVvWJqPDo1slpzOo6wDuGWp+ddZoXW0BXobPuOAmK4= X-Received: by 2002:a05:600c:34cd:b0:48e:707f:cdfd with SMTP id 5b1f17b1804b1-48e707fce07mr163467005e9.2.1778503898988; Mon, 11 May 2026 05:51:38 -0700 (PDT) X-Received: by 2002:a05:600c:34cd:b0:48e:707f:cdfd with SMTP id 5b1f17b1804b1-48e707fce07mr163466625e9.2.1778503898429; Mon, 11 May 2026 05:51:38 -0700 (PDT) Received: from [192.168.100.100] (82-64-211-94.subs.proxad.net. [82.64.211.94]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491ca383asm24972745f8f.28.2026.05.11.05.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 05:51:38 -0700 (PDT) Message-ID: Date: Mon, 11 May 2026 14:51:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/8] virtio: Reduce scope of variable To: David Gibson , passt-dev@passt.top, Stefano Brivio References: <20260511100322.1016757-1-david@gibson.dropbear.id.au> <20260511100322.1016757-3-david@gibson.dropbear.id.au> From: Laurent Vivier Autocrypt: addr=lvivier@redhat.com; keydata= xsFNBFYFJhkBEAC2me7w2+RizYOKZM+vZCx69GTewOwqzHrrHSG07MUAxJ6AY29/+HYf6EY2 WoeuLWDmXE7A3oJoIsRecD6BXHTb0OYS20lS608anr3B0xn5g0BX7es9Mw+hV/pL+63EOCVm SUVTEQwbGQN62guOKnJJJfphbbv82glIC/Ei4Ky8BwZkUuXd7d5NFJKC9/GDrbWdj75cDNQx UZ9XXbXEKY9MHX83Uy7JFoiFDMOVHn55HnncflUncO0zDzY7CxFeQFwYRbsCXOUL9yBtqLer Ky8/yjBskIlNrp0uQSt9LMoMsdSjYLYhvk1StsNPg74+s4u0Q6z45+l8RAsgLw5OLtTa+ePM JyS7OIGNYxAX6eZk1+91a6tnqfyPcMbduxyBaYXn94HUG162BeuyBkbNoIDkB7pCByed1A7q q9/FbuTDwgVGVLYthYSfTtN0Y60OgNkWCMtFwKxRaXt1WFA5ceqinN/XkgA+vf2Ch72zBkJL RBIhfOPFv5f2Hkkj0MvsUXpOWaOjatiu0fpPo6Hw14UEpywke1zN4NKubApQOlNKZZC4hu6/ 8pv2t4HRi7s0K88jQYBRPObjrN5+owtI51xMaYzvPitHQ2053LmgsOdN9EKOqZeHAYG2SmRW LOxYWKX14YkZI5j/TXfKlTpwSMvXho+efN4kgFvFmP6WT+tPnwARAQABzSNMYXVyZW50IFZp dmllciA8bHZpdmllckByZWRoYXQuY29tPsLBeAQTAQIAIgUCVgVQgAIbAwYLCQgHAwIGFQgC CQoLBBYCAwECHgECF4AACgkQ8ww4vT8vvjwpgg//fSGy0Rs/t8cPFuzoY1cex4limJQfReLr SJXCANg9NOWy/bFK5wunj+h/RCFxIFhZcyXveurkBwYikDPUrBoBRoOJY/BHK0iZo7/WQkur 6H5losVZtrotmKOGnP/lJYZ3H6OWvXzdz8LL5hb3TvGOP68K8Bn8UsIaZJoeiKhaNR0sOJyI YYbgFQPWMHfVwHD/U+/gqRhD7apVysxv5by/pKDln1I5v0cRRH6hd8M8oXgKhF2+rAOL7gvh jEHSSWKUlMjC7YwwjSZmUkL+TQyE18e2XBk85X8Da3FznrLiHZFHQ/NzETYxRjnOzD7/kOVy gKD/o7asyWQVU65mh/ECrtjfhtCBSYmIIVkopoLaVJ/kEbVJQegT2P6NgERC/31kmTF69vn8 uQyW11Hk8tyubicByL3/XVBrq4jZdJW3cePNJbTNaT0d/bjMg5zCWHbMErUib2Nellnbg6bc 2HLDe0NLVPuRZhHUHM9hO/JNnHfvgiRQDh6loNOUnm9Iw2YiVgZNnT4soUehMZ7au8PwSl4I KYE4ulJ8RRiydN7fES3IZWmOPlyskp1QMQBD/w16o+lEtY6HSFEzsK3o0vuBRBVp2WKnssVH qeeV01ZHw0bvWKjxVNOksP98eJfWLfV9l9e7s6TaAeySKRRubtJ+21PRuYAxKsaueBfUE7ZT 7zfOwU0EVgUmGQEQALxSQRbl/QOnmssVDxWhHM5TGxl7oLNJms2zmBpcmlrIsn8nNz0rRyxT 460k2niaTwowSRK8KWVDeAW6ZAaWiYjLlTunoKwvF8vP3JyWpBz0diTxL5o+xpvy/Q6YU3BN efdq8Vy3rFsxgW7mMSrI/CxJ667y8ot5DVugeS2NyHfmZlPGE0Nsy7hlebS4liisXOrN3jFz asKyUws3VXek4V65lHwB23BVzsnFMn/bw/rPliqXGcwl8CoJu8dSyrCcd1Ibs0/Inq9S9+t0 VmWiQWfQkz4rvEeTQkp/VfgZ6z98JRW7S6l6eophoWs0/ZyRfOm+QVSqRfFZdxdP2PlGeIFM C3fXJgygXJkFPyWkVElr76JTbtSHsGWbt6xUlYHKXWo+xf9WgtLeby3cfSkEchACrxDrQpj+ Jt/JFP+q997dybkyZ5IoHWuPkn7uZGBrKIHmBunTco1+cKSuRiSCYpBIXZMHCzPgVDjk4viP brV9NwRkmaOxVvye0vctJeWvJ6KA7NoAURplIGCqkCRwg0MmLrfoZnK/gRqVJ/f6adhU1oo6 z4p2/z3PemA0C0ANatgHgBb90cd16AUxpdEQmOCmdNnNJF/3Zt3inzF+NFzHoM5Vwq6rc1JP jfC3oqRLJzqAEHBDjQFlqNR3IFCIAo4SYQRBdAHBCzkM4rWyRhuVABEBAAHCwV8EGAECAAkF AlYFJhkCGwwACgkQ8ww4vT8vvjwg9w//VQrcnVg3TsjEybxDEUBm8dBmnKqcnTBFmxN5FFtI WlEuY8+YMiWRykd8Ln9RJ/98/ghABHz9TN8TRo2b6WimV64FmlVn17Ri6FgFU3xNt9TTEChq AcNg88eYryKsYpFwegGpwUlaUaaGh1m9OrTzcQy+klVfZWaVJ9Nw0keoGRGb8j4XjVpL8+2x OhXKrM1fzzb8JtAuSbuzZSQPDwQEI5CKKxp7zf76J21YeRrEW4WDznPyVcDTa+tz++q2S/Bp P4W98bXCBIuQgs2m+OflERv5c3Ojldp04/S4NEjXEYRWdiCxN7ca5iPml5gLtuvhJMSy36gl U6IW9kn30IWuSoBpTkgV7rLUEhh9Ms82VWW/h2TxL8enfx40PrfbDtWwqRID3WY8jLrjKfTd R3LW8BnUDNkG+c4FzvvGUs8AvuqxxyHbXAfDx9o/jXfPHVRmJVhSmd+hC3mcQ+4iX5bBPBPM oDqSoLt5w9GoQQ6gDVP2ZjTWqwSRMLzNr37rJjZ1pt0DCMMTbiYIUcrhX8eveCJtY7NGWNyx FCRkhxRuGcpwPmRVDwOl39MB3iTsRighiMnijkbLXiKoJ5CDVvX5yicNqYJPKh5MFXN1bvsB kmYiStMRbrD0HoY1kx5/VozBtc70OU0EB8Wrv9hZD+Ofp0T3KOr1RUHvCZoLURfFhSQ= In-Reply-To: <20260511100322.1016757-3-david@gibson.dropbear.id.au> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: UyEoFKtjubaYgxIroziRJ66lrNPg32rpKLkVWbS-FhY_1778503899 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Message-ID-Hash: UKXUWY5TFRZTZ4ZMLB7GG3BDHJG7GBCV X-Message-ID-Hash: UKXUWY5TFRZTZ4ZMLB7GG3BDHJG7GBCV X-MailFrom: lvivier@redhat.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: Development discussion and patches for passt Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/11/26 12:03, David Gibson wrote: > As cppcheck points out, the 'min' variable in vu_log_queue_fill() can have > its scope reduced. Do so. > > Signed-off-by: David Gibson > --- > virtio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/virtio.c b/virtio.c > index b283de66..d7016cc3 100644 > --- a/virtio.c > +++ b/virtio.c > @@ -630,9 +630,9 @@ static void vu_log_queue_fill(const struct vu_dev *vdev, struct vu_virtq *vq, > { > struct vring_desc desc_buf[VIRTQUEUE_MAX_SIZE]; > struct vring_desc *desc = vq->vring.desc; > - unsigned int max, min; > unsigned num_bufs = 0; > uint64_t read_len; > + unsigned int max; > > if (!vdev->log_table || !len || !vu_has_feature(vdev, VHOST_F_LOG_ALL)) > return; > @@ -672,7 +672,7 @@ static void vu_log_queue_fill(const struct vu_dev *vdev, struct vu_virtq *vq, > die("Looped descriptor"); > > if (le16toh(desc[index].flags) & VRING_DESC_F_WRITE) { > - min = MIN(le32toh(desc[index].len), len); > + unsigned min = MIN(le32toh(desc[index].len), len); > vu_log_write(vdev, le64toh(desc[index].addr), min); > len -= min; > } Reviewed-by: Laurent Vivier