From: Laurent Vivier <lvivier@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: passt-dev@passt.top
Subject: Re: [PATCH v4 4/8] util: move IP stuff from util.[ch] to ip.[ch]
Date: Fri, 1 Mar 2024 13:06:47 +0100 [thread overview]
Message-ID: <1642c691-af65-4c13-8cf5-9ad895a707f3@redhat.com> (raw)
In-Reply-To: <ZeERF6F99DYPNJ0u@zatzit>
On 3/1/24 00:19, David Gibson wrote:
> On Thu, Feb 29, 2024 at 05:59:51PM +0100, Laurent Vivier wrote:
>> Introduce ip.[ch] file to encapsulate IP protocol handling functions and
>> structures. Modify various files to include the new header ip.h when
>> it's needed.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
>> ---
>>
>> Notes:
>> v4:
>> - rebase
>>
>> v3:
>> - rewrap rationale
>> - add David's R-b
>>
>> v2:
>> - update rationale and comments
>>
>> Makefile | 10 +++---
>> conf.c | 1 +
>> dhcp.c | 1 +
>> flow.c | 1 +
>> fwd.c | 1 +
>> icmp.c | 1 +
>> inany.c | 1 +
>> ip.c | 72 +++++++++++++++++++++++++++++++++++++++++++
>> ip.h | 86 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>
> Noe that ip.h exists, in4addr_loopback and in4addr_any should probably
> go in there rather than inany.h. That can be a followup change
> though.
>
Not sure they should be moved to ip.h: they depend on inany_loopback4 and inany_any4 that
are both defined in inany.c and the structure inany_addr is defined in inany.h
I think it's better to let them where they are.
Thanks,
Laurent
next prev parent reply other threads:[~2024-03-01 12:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 16:59 [PATCH v4 0/8] Add vhost-user support to passt (part 1) Laurent Vivier
2024-02-29 16:59 ` [PATCH v4 1/8] pcap: add pcap_iov() Laurent Vivier
2024-02-29 23:16 ` David Gibson
2024-02-29 16:59 ` [PATCH v4 2/8] checksum: align buffers Laurent Vivier
2024-02-29 16:59 ` [PATCH v4 3/8] checksum: add csum_iov() Laurent Vivier
2024-02-29 16:59 ` [PATCH v4 4/8] util: move IP stuff from util.[ch] to ip.[ch] Laurent Vivier
2024-02-29 23:19 ` David Gibson
2024-03-01 12:06 ` Laurent Vivier [this message]
2024-02-29 16:59 ` [PATCH v4 5/8] checksum: use csum_ip4_header() in udp.c and tcp.c Laurent Vivier
2024-02-29 23:25 ` David Gibson
2024-03-01 12:31 ` Laurent Vivier
2024-02-29 16:59 ` [PATCH v4 6/8] checksum: introduce functions to compute the header part checksum for TCP/UDP Laurent Vivier
2024-02-29 23:42 ` David Gibson
2024-02-29 16:59 ` [PATCH v4 7/8] tap: make tap_update_mac() generic Laurent Vivier
2024-02-29 16:59 ` [PATCH v4 8/8] tcp: Introduce ipv4_fill_headers()/ipv6_fill_headers() Laurent Vivier
2024-02-29 23:54 ` David Gibson
2024-03-03 13:50 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1642c691-af65-4c13-8cf5-9ad895a707f3@redhat.com \
--to=lvivier@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=passt-dev@passt.top \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://passt.top/passt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for IMAP folder(s).